Please review this change to just move two classes from one package to another. The move was done as a single simple IDE operation, which also had a not-unwelcome side-effect of cleaning up some unrelated imports.
The change is an indirect consequence of the recent change to use the new `HtmlId` and `HtmlIds` classes, which introduced an undesirable package dependence in the `Table` class. The changes are just to move the classes and update imports. There are no functional changes. ------------- Commit messages: - JDK-8259723: Move Table class to formats.html package Changes: https://git.openjdk.java.net/jdk/pull/2065/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2065&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259723 Stats: 58 lines in 24 files changed: 8 ins; 44 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/2065.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2065/head:pull/2065 PR: https://git.openjdk.java.net/jdk/pull/2065 |
On Wed, 13 Jan 2021 18:44:41 GMT, Jonathan Gibbons <[hidden email]> wrote:
> Please review this change to just move two classes from one package to another. The move was done as a single simple IDE operation, which also had a not-unwelcome side-effect of cleaning up some unrelated imports. > > The change is an indirect consequence of the recent change to use the new `HtmlId` and `HtmlIds` classes, which introduced an undesirable package dependence in the `Table` class. > > The changes are just to move the classes and update imports. There are no functional changes. A not-reasonable extension of this change would be to move `TableHeader` to be a nested class in `Table` itself, `Table.Header`, or maybe `Table.Head`. ------------- PR: https://git.openjdk.java.net/jdk/pull/2065 |
In reply to this post by Jonathan Gibbons-2
On Wed, 13 Jan 2021 18:44:41 GMT, Jonathan Gibbons <[hidden email]> wrote:
> Please review this change to just move two classes from one package to another. The move was done as a single simple IDE operation, which also had a not-unwelcome side-effect of cleaning up some unrelated imports. > > The change is an indirect consequence of the recent change to use the new `HtmlId` and `HtmlIds` classes, which introduced an undesirable package dependence in the `Table` class. > > The changes are just to move the classes and update imports. There are no functional changes. Looks good! ------------- Marked as reviewed by hannesw (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2065 |
In reply to this post by Jonathan Gibbons-2
On Wed, 13 Jan 2021 18:44:41 GMT, Jonathan Gibbons <[hidden email]> wrote:
> Please review this change to just move two classes from one package to another. The move was done as a single simple IDE operation, which also had a not-unwelcome side-effect of cleaning up some unrelated imports. > > The change is an indirect consequence of the recent change to use the new `HtmlId` and `HtmlIds` classes, which introduced an undesirable package dependence in the `Table` class. > > The changes are just to move the classes and update imports. There are no functional changes. This pull request has now been integrated. Changeset: 1620664e Author: Jonathan Gibbons <[hidden email]> URL: https://git.openjdk.java.net/jdk/commit/1620664e Stats: 58 lines in 24 files changed: 8 ins; 44 del; 6 mod 8259723: Move Table class to formats.html package Reviewed-by: hannesw ------------- PR: https://git.openjdk.java.net/jdk/pull/2065 |
Free forum by Nabble | Edit this page |