RFR: JDK-8259726: Use of HashSet leads to undefined order in test output

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8259726: Use of HashSet leads to undefined order in test output

Jonathan Gibbons-2
Small cleanup in code, changing `HashSet` to `ArrayList`, with a corresponding beneficial impact on tests.

The irony is that this was originally done with the intent to change the element type from `String` to `HtmlId`, but having tried that, it seems better to localize the conversion from ids to class names, so I just cleaned up the expository comment a bit.

I rewrapped some of the long text block lines as well.

-------------

Commit messages:
 - Merge remote-tracking branch 'upstream/master' into tabClasses
 - JDK-8259726: Use of HashSet leads to undefined order in test output

Changes: https://git.openjdk.java.net/jdk/pull/2086/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2086&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8259726
  Stats: 244 lines in 18 files changed: 34 ins; 2 del; 208 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2086.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2086/head:pull/2086

PR: https://git.openjdk.java.net/jdk/pull/2086
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8259726: Use of HashSet leads to undefined order in test output

Hannes Wallnöfer
On Thu, 14 Jan 2021 23:33:38 GMT, Jonathan Gibbons <[hidden email]> wrote:

> Small cleanup in code, changing `HashSet` to `ArrayList`, with a corresponding beneficial impact on tests.
>
> The irony is that this was originally done with the intent to change the element type from `String` to `HtmlId`, but having tried that, it seems better to localize the conversion from ids to class names, so I just cleaned up the expository comment a bit.
>
> I rewrapped some of the long text block lines as well.

Looks good!

-------------

Marked as reviewed by hannesw (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2086
Reply | Threaded
Open this post in threaded view
|

Integrated: JDK-8259726: Use of HashSet leads to undefined order in test output

Jonathan Gibbons-2
In reply to this post by Jonathan Gibbons-2
On Thu, 14 Jan 2021 23:33:38 GMT, Jonathan Gibbons <[hidden email]> wrote:

> Small cleanup in code, changing `HashSet` to `ArrayList`, with a corresponding beneficial impact on tests.
>
> The irony is that this was originally done with the intent to change the element type from `String` to `HtmlId`, but having tried that, it seems better to localize the conversion from ids to class names, so I just cleaned up the expository comment a bit.
>
> I rewrapped some of the long text block lines as well.

This pull request has now been integrated.

Changeset: 982e42b8
Author:    Jonathan Gibbons <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/982e42b8
Stats:     244 lines in 18 files changed: 34 ins; 2 del; 208 mod

8259726: Use of HashSet leads to undefined order in test output

Reviewed-by: hannesw

-------------

PR: https://git.openjdk.java.net/jdk/pull/2086