RFR: JDK-8259727: Remove redundant "target" arguments to methods in Links

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8259727: Remove redundant "target" arguments to methods in Links

Jonathan Gibbons-2
Please remove a simple change to eliminate a now-unused parameter from various methods on `Links`, to set the `target` attribute of a link.

In times past, when frames were used to display pages, the `target` attribute was used to specify the target frame to use when clicking the link.

-------------

Commit messages:
 - JDK-8259727: Remove redundant "target" arguments to methods in Links

Changes: https://git.openjdk.java.net/jdk/pull/2068/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2068&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8259727
  Stats: 65 lines in 6 files changed: 0 ins; 28 del; 37 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2068.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2068/head:pull/2068

PR: https://git.openjdk.java.net/jdk/pull/2068
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8259727: Remove redundant "target" arguments to methods in Links

Hannes Wallnöfer
On Wed, 13 Jan 2021 21:03:12 GMT, Jonathan Gibbons <[hidden email]> wrote:

> Please remove a simple change to eliminate a now-unused parameter from various methods on `Links`, to set the `target` attribute of a link.
>
> In times past, when frames were used to display pages, the `target` attribute was used to specify the target frame to use when clicking the link.

Nice cleanup!

-------------

Marked as reviewed by hannesw (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2068
Reply | Threaded
Open this post in threaded view
|

Integrated: JDK-8259727: Remove redundant "target" arguments to methods in Links

Jonathan Gibbons-2
In reply to this post by Jonathan Gibbons-2
On Wed, 13 Jan 2021 21:03:12 GMT, Jonathan Gibbons <[hidden email]> wrote:

> Please remove a simple change to eliminate a now-unused parameter from various methods on `Links`, to set the `target` attribute of a link.
>
> In times past, when frames were used to display pages, the `target` attribute was used to specify the target frame to use when clicking the link.

This pull request has now been integrated.

Changeset: c2a3c7ef
Author:    Jonathan Gibbons <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/c2a3c7ef
Stats:     65 lines in 6 files changed: 0 ins; 28 del; 37 mod

8259727: Remove redundant "target" arguments to methods in Links

Reviewed-by: hannesw

-------------

PR: https://git.openjdk.java.net/jdk/pull/2068