RFR: JDK-8260858: Implementation specific property xsltcIsStandalone for XSLTC Serializer

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8260858: Implementation specific property xsltcIsStandalone for XSLTC Serializer

Joe Wang-2
Adds a property similar to 'isStandalone' in JDK-8249867.

Please note that the test received an auto-format. The material changes were the two tests marked with bug id 8260858 and related data and methods.

-------------

Commit messages:
 - JDK-8260858: Implementation specific property xsltcIsStandalone for XSLTC Serializer

Changes: https://git.openjdk.java.net/jdk/pull/2559/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2559&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8260858
  Stats: 243 lines in 7 files changed: 167 ins; 4 del; 72 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2559.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2559/head:pull/2559

PR: https://git.openjdk.java.net/jdk/pull/2559
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8260858: Implementation specific property xsltcIsStandalone for XSLTC Serializer

Lance Andersen
On Sat, 13 Feb 2021 00:16:50 GMT, Joe Wang <[hidden email]> wrote:

> Adds a property similar to 'isStandalone' in JDK-8249867.
>
> Please note that the test received an auto-format. The material changes were the two tests marked with bug id 8260858 and related data and methods.

Marked as reviewed by lancea (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2559
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8260858: Implementation specific property xsltcIsStandalone for XSLTC Serializer

Naoto Sato-2
In reply to this post by Joe Wang-2
On Sat, 13 Feb 2021 00:16:50 GMT, Joe Wang <[hidden email]> wrote:

> Adds a property similar to 'isStandalone' in JDK-8249867.
>
> Please note that the test received an auto-format. The material changes were the two tests marked with bug id 8260858 and related data and methods.

test/jaxp/javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java line 107:

> 105:             + "\n"
> 106:             + "</xsl:stylesheet>";
> 107:

Could be better to use text blocks?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2559
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8260858: Implementation specific property xsltcIsStandalone for XSLTC Serializer

Joe Wang-2
On Sun, 14 Feb 2021 21:27:49 GMT, Naoto Sato <[hidden email]> wrote:

>> Adds a property similar to 'isStandalone' in JDK-8249867.
>>
>> Please note that the test received an auto-format. The material changes were the two tests marked with bug id 8260858 and related data and methods.
>
> test/jaxp/javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java line 107:
>
>> 105:             + "\n"
>> 106:             + "</xsl:stylesheet>";
>> 107:
>
> Could be better to use text blocks?

In general, we're keeping it at source level 8 to facilitate backports. As a result, only a few projects so far have been done using more advanced features.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2559
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8260858: Implementation specific property xsltcIsStandalone for XSLTC Serializer

Naoto Sato-2
In reply to this post by Joe Wang-2
On Sat, 13 Feb 2021 00:16:50 GMT, Joe Wang <[hidden email]> wrote:

> Adds a property similar to 'isStandalone' in JDK-8249867.
>
> Please note that the test received an auto-format. The material changes were the two tests marked with bug id 8260858 and related data and methods.

Marked as reviewed by naoto (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2559
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8260858: Implementation specific property xsltcIsStandalone for XSLTC Serializer

Naoto Sato-2
In reply to this post by Joe Wang-2
On Tue, 16 Feb 2021 17:23:35 GMT, Joe Wang <[hidden email]> wrote:

>> test/jaxp/javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java line 107:
>>
>>> 105:             + "\n"
>>> 106:             + "</xsl:stylesheet>";
>>> 107:
>>
>> Could be better to use text blocks?
>
> In general, we're keeping it at source level 8 to facilitate backports. As a result, only a few projects so far have been done using more advanced features.

Makes sense. Thanks for the explanation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2559
Reply | Threaded
Open this post in threaded view
|

Integrated: JDK-8260858: Implementation specific property xsltcIsStandalone for XSLTC Serializer

Joe Wang-2
In reply to this post by Joe Wang-2
On Sat, 13 Feb 2021 00:16:50 GMT, Joe Wang <[hidden email]> wrote:

> Adds a property similar to 'isStandalone' in JDK-8249867.
>
> Please note that the test received an auto-format. The material changes were the two tests marked with bug id 8260858 and related data and methods.

This pull request has now been integrated.

Changeset: c99eeb01
Author:    Joe Wang <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/c99eeb01
Stats:     243 lines in 7 files changed: 167 ins; 4 del; 72 mod

8260858: Implementation specific property xsltcIsStandalone for XSLTC Serializer

Reviewed-by: lancea, naoto

-------------

PR: https://git.openjdk.java.net/jdk/pull/2559