RFR: JDK-8261623: reference to javac internals in Extern class

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8261623: reference to javac internals in Extern class

Jonathan Gibbons-2
Trivial patch to move some code that accesses javac-internals into the `WorkArounds` class.

-------------

Commit messages:
 - JDK-8261623: reference to javac internals in Extern class

Changes: https://git.openjdk.java.net/jdk/pull/2537/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2537&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261623
  Stats: 24 lines in 2 files changed: 11 ins; 12 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2537.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2537/head:pull/2537

PR: https://git.openjdk.java.net/jdk/pull/2537
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8261623: reference to javac internals in Extern class [v2]

Jonathan Gibbons-2
> Trivial patch to move some code that accesses javac-internals into the `WorkArounds` class.

Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:

  add bug reference

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2537/files
  - new: https://git.openjdk.java.net/jdk/pull/2537/files/3ae30c81..708dfcb7

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2537&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2537&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2537.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2537/head:pull/2537

PR: https://git.openjdk.java.net/jdk/pull/2537
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8261623: reference to javac internals in Extern class [v2]

Hannes Wallnöfer
On Fri, 12 Feb 2021 01:01:58 GMT, Jonathan Gibbons <[hidden email]> wrote:

>> Trivial patch to move some code that accesses javac-internals into the `WorkArounds` class.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>
>   add bug reference

Marked as reviewed by hannesw (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2537
Reply | Threaded
Open this post in threaded view
|

Integrated: JDK-8261623: reference to javac internals in Extern class

Jonathan Gibbons-2
In reply to this post by Jonathan Gibbons-2
On Fri, 12 Feb 2021 00:46:39 GMT, Jonathan Gibbons <[hidden email]> wrote:

> Trivial patch to move some code that accesses javac-internals into the `WorkArounds` class.

This pull request has now been integrated.

Changeset: 3aa1b4c7
Author:    Jonathan Gibbons <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/3aa1b4c7
Stats:     25 lines in 2 files changed: 12 ins; 12 del; 1 mod

8261623: reference to javac internals in Extern class

Reviewed-by: hannesw

-------------

PR: https://git.openjdk.java.net/jdk/pull/2537