RFR: JDK-8261969: SNIHostName would check if the encoded hostname conform to RFC 3490

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8261969: SNIHostName would check if the encoded hostname conform to RFC 3490

John Jiang
Similar to the constructor SNIHostName(String hostname), the constructor SNIHostName(byte[] encoded) also needs to check if the encoded hostname conform to RFC 3490.

-------------

Commit messages:
 - JDK-8261969: SNIHostName would check if the encoded hostname conform to RFC 3490

Changes: https://git.openjdk.java.net/jdk/pull/2639/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2639&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261969
  Stats: 39 lines in 2 files changed: 24 ins; 5 del; 10 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2639.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2639/head:pull/2639

PR: https://git.openjdk.java.net/jdk/pull/2639
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8261969: SNIHostName would check if the encoded hostname conform to RFC 3490

Rajan Halade-2
On Fri, 19 Feb 2021 08:39:23 GMT, John Jiang <[hidden email]> wrote:

> Similar to the constructor SNIHostName(String hostname), the constructor SNIHostName(byte[] encoded) also needs to check if the encoded hostname conform to RFC 3490.

Changes requested by rhalade (Reviewer).

test/jdk/javax/net/ssl/ServerName/IllegalSNIName.java line 40:

> 38:         try {
> 39:             new SNIHostName(hostname);
> 40:             throw new Exception("Expected to get IllegalArgumentException for "

Suggestion:

            throw new RuntimeException("Expected to get IllegalArgumentException for "

test/jdk/javax/net/ssl/ServerName/IllegalSNIName.java line 50:

> 48:         try {
> 49:             new SNIHostName(encodedHostname);
> 50:             throw new Exception("Expected to get IllegalArgumentException for "

Suggestion:

            throw new RuntimeException("Expected to get IllegalArgumentException for "

-------------

PR: https://git.openjdk.java.net/jdk/pull/2639
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8261969: SNIHostName should check if the encoded hostname conform to RFC 3490 [v2]

John Jiang
In reply to this post by John Jiang
> Similar to the constructor SNIHostName(String hostname), the constructor SNIHostName(byte[] encoded) also needs to check if the encoded hostname conform to RFC 3490.

John Jiang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into jdk-8261969
 - JDK-8261969: SNIHostName would check if the encoded hostname conform to RFC 3490

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2639/files
  - new: https://git.openjdk.java.net/jdk/pull/2639/files/59ba1c47..35041c54

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2639&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2639&range=00-01

  Stats: 3642 lines in 114 files changed: 2487 ins; 569 del; 586 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2639.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2639/head:pull/2639

PR: https://git.openjdk.java.net/jdk/pull/2639
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8261969: SNIHostName should check if the encoded hostname conform to RFC 3490 [v2]

John Jiang
In reply to this post by Rajan Halade-2
On Mon, 22 Feb 2021 16:17:28 GMT, Rajan Halade <[hidden email]> wrote:

>> John Jiang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>>
>>  - Merge branch 'master' into jdk-8261969
>>  - JDK-8261969: SNIHostName would check if the encoded hostname conform to RFC 3490
>
> Changes requested by rhalade (Reviewer).

I wouldn't merge the master to this branch :-(

-------------

PR: https://git.openjdk.java.net/jdk/pull/2639
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8261969: SNIHostName should check if the encoded hostname conform to RFC 3490 [v3]

John Jiang
In reply to this post by John Jiang
> Similar to the constructor SNIHostName(String hostname), the constructor SNIHostName(byte[] encoded) also needs to check if the encoded hostname conform to RFC 3490.

John Jiang has updated the pull request incrementally with one additional commit since the last revision:

  Throw RuntimeException instead of Exception

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2639/files
  - new: https://git.openjdk.java.net/jdk/pull/2639/files/35041c54..5801cf3f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2639&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2639&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2639.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2639/head:pull/2639

PR: https://git.openjdk.java.net/jdk/pull/2639
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8261969: SNIHostName should check if the encoded hostname conform to RFC 3490 [v3]

John Jiang
In reply to this post by John Jiang
On Mon, 22 Feb 2021 22:38:19 GMT, John Jiang <[hidden email]> wrote:

>> Changes requested by rhalade (Reviewer).
>
> I wouldn't merge the master to this branch :-(

Could the latest patch be reviewed?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2639
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8261969: SNIHostName should check if the encoded hostname conform to RFC 3490 [v3]

Xue-Lei Andrew Fan
In reply to this post by John Jiang
On Tue, 23 Feb 2021 02:10:58 GMT, John Jiang <[hidden email]> wrote:

>> Similar to the constructor SNIHostName(String hostname), the constructor SNIHostName(byte[] encoded) also needs to check if the encoded hostname conform to RFC 3490.
>
> John Jiang has updated the pull request incrementally with one additional commit since the last revision:
>
>   Throw RuntimeException instead of Exception

Marked as reviewed by xuelei (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2639
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8261969: SNIHostName should check if the encoded hostname conform to RFC 3490 [v3]

Rajan Halade-2
In reply to this post by John Jiang
On Tue, 23 Feb 2021 02:10:58 GMT, John Jiang <[hidden email]> wrote:

>> Similar to the constructor SNIHostName(String hostname), the constructor SNIHostName(byte[] encoded) also needs to check if the encoded hostname conform to RFC 3490.
>
> John Jiang has updated the pull request incrementally with one additional commit since the last revision:
>
>   Throw RuntimeException instead of Exception

Thanks for updating the test.

-------------

Marked as reviewed by rhalade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2639
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8261969: SNIHostName should check if the encoded hostname conform to RFC 3490 [v3]

John Jiang
On Tue, 2 Mar 2021 21:36:36 GMT, Rajan Halade <[hidden email]> wrote:

>> John Jiang has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   Throw RuntimeException instead of Exception
>
> Thanks for updating the test.

@rhalade @XueleiFan Thanks for your reviews!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2639
Reply | Threaded
Open this post in threaded view
|

Integrated: JDK-8261969: SNIHostName should check if the encoded hostname conform to RFC 3490

John Jiang
In reply to this post by John Jiang
On Fri, 19 Feb 2021 08:39:23 GMT, John Jiang <[hidden email]> wrote:

> Similar to the constructor SNIHostName(String hostname), the constructor SNIHostName(byte[] encoded) also needs to check if the encoded hostname conform to RFC 3490.

This pull request has now been integrated.

Changeset: 4f4d0f53
Author:    John Jiang <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/4f4d0f53
Stats:     39 lines in 2 files changed: 24 ins; 5 del; 10 mod

8261969: SNIHostName should check if the encoded hostname conform to RFC 3490

Reviewed-by: rhalade, xuelei

-------------

PR: https://git.openjdk.java.net/jdk/pull/2639