RFR: JDK-8264572 reinsert common pool parallelism assignment

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8264572 reinsert common pool parallelism assignment

Doug Lea-2
This reinserts setting common pool parallelism inadvertently clobbered in JDK-8259800

-------------

Commit messages:
 - Reinsert omitted assignment
 - Reinsert omitted assignment

Changes: https://git.openjdk.java.net/jdk/pull/3324/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3324&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264572
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3324.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3324/head:pull/3324

PR: https://git.openjdk.java.net/jdk/pull/3324
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8264572 reinsert common pool parallelism assignment

Alan Bateman-2
On Fri, 2 Apr 2021 10:52:45 GMT, Doug Lea <[hidden email]> wrote:

> This reinserts setting common pool parallelism inadvertently clobbered in JDK-8259800

This looks okay to me, I just wonder if we should have a test to the value of getCommonPoolParallelism.

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3324
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8264572 reinsert common pool parallelism assignment

Doug Lea-2
On Fri, 2 Apr 2021 13:20:44 GMT, Alan Bateman <[hidden email]> wrote:

>> This reinserts setting common pool parallelism inadvertently clobbered in JDK-8259800
>
> This looks okay to me, I just wonder if we should have a test to the value of getCommonPoolParallelism.

We once had a test, but now that Runtime.availableProcessors (the only means of checking) can return varying values, we can't include in tck  tests. The error here wasn't caught  because we didn't run the usual performance tests (that catch these problems immediately) because I was focused only on JDK-8259800. Sorry.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3324
Reply | Threaded
Open this post in threaded view
|

Integrated: JDK-8264572: ForkJoinPool.getCommonPoolParallelism() reports always 1

Doug Lea-2
In reply to this post by Doug Lea-2
On Fri, 2 Apr 2021 10:52:45 GMT, Doug Lea <[hidden email]> wrote:

> This reinserts setting common pool parallelism inadvertently clobbered in JDK-8259800

This pull request has now been integrated.

Changeset: cec66cf8
Author:    Doug Lea <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/cec66cf8
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8264572: ForkJoinPool.getCommonPoolParallelism() reports always 1

Reviewed-by: alanb

-------------

PR: https://git.openjdk.java.net/jdk/pull/3324