RFR (JDK10/JAXP Doc-only) 8184431: References to @sun.com

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR (JDK10/JAXP Doc-only) 8184431: References to @sun.com

huizhe wang
Hi,

This change uses a process to strip off the @sun.com email addresses and
links, and keep just the name of the authors.

Please review:

JBS: https://bugs.openjdk.java.net/browse/JDK-8184431
webrev: http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html

Thanks,
Joe
Reply | Threaded
Open this post in threaded view
|

Re: RFR (JDK10/JAXP Doc-only) 8184431: References to @sun.com

Lance Andersen
Hi Joe,

Overall, this is fine, a few things to consider if you want to address

Happy Holidays

Best
Lance

Do we really need to keep the name in comments such as these:

final class TestSeq {
--- old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java 2017-12-21 11:04:12.188400062 -0800
+++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java 2017-12-21 11:04:11.423325345 -0800
@@ -682,7 +682,7 @@
                     // If the new name has a different prefix, the list may become unsorted.
                     // Maybe it would be better to resort the list, but the simplest
                     // fix seems to be to remove the old attribute and re-insert it.
-                    // -- [hidden email], 2 Feb 2007
+                    // -- Norman Walsh, 2 Feb 2007


Do we need Sun Microsystems, Inc  as we are not consistent

--- old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 11:05:03.519413044 -0800
+++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 11:05:02.758338717 -0800
@@ -40,7 +40,7 @@
  * calling NamespaceSupport methods.
  *
  * @author  Neeraj Bajaj, Sun Microsystems, inc.
- * @author [hidden email]
+ * @author Santiago PericasGeertsen
  *
  */
public class LocationImpl implements Location{
     String systemId;
--- old/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java 2017-12-21 11:05:31.112107741 -0800
+++ new/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java 2017-12-21 11:05:30.352033512 -0800
@@ -32,7 +32,7 @@
 import javax.xml.XMLConstants;
 /**
  *
- * @author  Neeraj Bajaj,[hidden email]  Sun Microsystems.
+ * @author  Neeraj Bajaj,K Venugopal  Sun Microsystems.
  */

> On Dec 21, 2017, at 2:23 PM, Joe Wang <[hidden email]> wrote:
>
> http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html <http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>



Reply | Threaded
Open this post in threaded view
|

Re: RFR (JDK10/JAXP Doc-only) 8184431: References to @sun.com

huizhe wang
Hi Lance,

Thanks for the review! As you suggested, the names in comments, and "Sun
Microsystems" in a few cases in the following classes are removed.

Updated webrevs:  
http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html

Happy Holidays!

Best,
Joe

+++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java 2017-12-21 15:18:42.614522112 -0800
@@ -682,7 +682,6 @@
                      // If the new name has a different prefix, the list may become unsorted.
                      // Maybe it would be better to resort the list, but the simplest
                      // fix seems to be to remove the old attribute and re-insert it.
-                    // -- [hidden email], 2 Feb 2007
                      newAttr = (Attr) attributes.removeItem(newAttr, false);
                      attributes.addItem(newAttr);

+++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XML11NSDocumentScannerImpl.java 2017-12-21 15:18:47.069957104 -0800
@@ -741,7 +741,7 @@
          // Take advantage of the fact that next string _should_ be "fElementQName.rawName",
          //In scanners most of the time is consumed on checks done for XML characters, we can
          // optimize on it and avoid the checks done for endElement,
-        //we will also avoid symbol table lookup - [hidden email]
+        //we will also avoid symbol table lookup.


+++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java 2017-12-21 15:18:49.697213609 -0800
@@ -1670,7 +1670,7 @@
          // Take advantage of the fact that next string _should_ be "fElementQName.rawName",
          //In scanners most of the time is consumed on checks done for XML characters, we can
          // optimize on it and avoid the checks done for endElement,
-        //we will also avoid symbol table lookup - [hidden email]
+        //we will also avoid symbol table lookup.

          // this should work both for namespace processing true or false...

@@ -2461,7 +2461,6 @@
           * we dont need to set the value for every end element encouterd.
           * For Well formedness checks we can have the same QName object that was pushed.
           * the values will be set only if application need to know about the endElement
-         * -- [hidden email]
           */

+++ new/src/java.xml/share/classes/com/sun/xml/internal/stream/writers/XMLStreamWriterImpl.java 2017-12-21 15:37:09.426583713 -0800
@@ -64,8 +64,8 @@
   *
   * @author Neeraj Bajaj
   * @author K.Venugopal
- * @author [hidden email]
- * @author [hidden email]
+ * @author Santiago Pericas-Geertsen
+ * @author Sunitha Reddy
   */
  public final class XMLStreamWriterImpl extends AbstractMap<Object, Object>
          implements XMLStreamWriterBase {
@@ -2041,7 +2041,6 @@
           * we dont need to set the value for every end element we encouter.
           * For Well formedness checks we can have the same QName object that was pushed.
           * the values will be set only if application need to know about the endElement
-         * -- [hidden email]
           */
          public ElementState peek() {
              return fElements[fDepth - 1];



--- old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 15:19:37.505881261 -0800
+++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 15:19:36.670799729 -0800
@@ -39,8 +39,8 @@
   * can be exposed to the application, we must intern all Strings before
   * calling NamespaceSupport methods.
   *
- * @author  Neeraj Bajaj, Sun Microsystems, inc.
- * @author [hidden email]
+ * @author  Neeraj Bajaj
+ * @author Santiago PericasGeertsen

+++ new/src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/BaseMarkupSerializer.java 2017-12-21 15:19:47.796885990 -0800
@@ -118,9 +118,9 @@
   *
   *
   * @author<a href="mailto:[hidden email]">Assaf Arkin</a>
- * @author<a href="mailto:[hidden email]">Rahul Srivastava</a>
+ * @author Rahul Srivastava
   * @author Elena Litani, IBM
- * @author Sunitha Reddy, Sun Microsystems
+ * @author Sunitha Reddy
   * @see Serializer
   * @see org.w3c.dom.ls.LSSerializer

+++ new/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java 2017-12-21 15:20:05.831646762 -0800
@@ -32,7 +32,7 @@
  import javax.xml.XMLConstants;
  /**
   *
- * @author  Neeraj Bajaj,[hidden email]  Sun Microsystems.
+ * @author  Neeraj Bajaj,K Venugopal




On 12/21/17, 2:35 PM, Lance Andersen wrote:

> Hi Joe,
>
> Overall, this is fine, a few things to consider if you want to address
>
> Happy Holidays
>
> Best
> Lance
>
> Do we really need to keep the name in comments such as these:
>
> final class TestSeq {
> --- old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java 2017-12-21 11:04:12.188400062 -0800
> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java 2017-12-21 11:04:11.423325345 -0800
> @@ -682,7 +682,7 @@
>                       // If the new name has a different prefix, the list may become unsorted.
>                       // Maybe it would be better to resort the list, but the simplest
>                       // fix seems to be to remove the old attribute and re-insert it.
> -                    // --[hidden email]  <mailto:[hidden email]>, 2 Feb 2007
> +                    // -- Norman Walsh, 2 Feb 2007
>
>
> Do we need Sun Microsystems, Inc  as we are not consistent
>
> --- old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 11:05:03.519413044 -0800
> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 11:05:02.758338717 -0800
> @@ -40,7 +40,7 @@
>    * calling NamespaceSupport methods.
>    *
>    * @author  Neeraj Bajaj, Sun Microsystems, inc.
> - * @[hidden email]  <mailto:[hidden email]>
> + * @author Santiago PericasGeertsen
>    *
>    */
> public class LocationImpl implements Location{
>       String systemId;
> --- old/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java 2017-12-21 11:05:31.112107741 -0800
> +++ new/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java 2017-12-21 11:05:30.352033512 -0800
> @@ -32,7 +32,7 @@
>   import javax.xml.XMLConstants;
>   /**
>    *
> - * @author  Neeraj Bajaj,[hidden email]  <mailto:[hidden email]>   Sun Microsystems.
> + * @author  Neeraj Bajaj,K Venugopal  Sun Microsystems.
>    */
>
>> On Dec 21, 2017, at 2:23 PM, Joe Wang <[hidden email]
>> <mailto:[hidden email]>> wrote:
>>
>> http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html 
>> <http://cr.openjdk.java.net/%7Ejoehw/jdk10/8184431/webrev/index.html>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> [hidden email] <mailto:[hidden email]>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR (JDK10/JAXP Doc-only) 8184431: References to @sun.com

Lance Andersen
Hi joe

Looks fine

Best
Lance


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email]
Sent from my iPad

> On Dec 21, 2017, at 6:48 PM, Joe Wang <[hidden email]> wrote:
>
> Hi Lance,
>
> Thanks for the review! As you suggested, the names in comments, and "Sun Microsystems" in a few cases in the following classes are removed.
>
> Updated webrevs:  http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html
>
> Happy Holidays!
>
> Best,
> Joe
>
> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java 2017-12-21 15:18:42.614522112 -0800
> @@ -682,7 +682,6 @@
>                      // If the new name has a different prefix, the list may become unsorted.
>                      // Maybe it would be better to resort the list, but the simplest
>                      // fix seems to be to remove the old attribute and re-insert it.
> -                    // -- [hidden email], 2 Feb 2007
>                      newAttr = (Attr) attributes.removeItem(newAttr, false);
>                      attributes.addItem(newAttr);
>
> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XML11NSDocumentScannerImpl.java 2017-12-21 15:18:47.069957104 -0800
> @@ -741,7 +741,7 @@
>          // Take advantage of the fact that next string _should_ be "fElementQName.rawName",
>          //In scanners most of the time is consumed on checks done for XML characters, we can
>          // optimize on it and avoid the checks done for endElement,
> -        //we will also avoid symbol table lookup - [hidden email]
> +        //we will also avoid symbol table lookup.
>
> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java 2017-12-21 15:18:49.697213609 -0800
> @@ -1670,7 +1670,7 @@
>          // Take advantage of the fact that next string _should_ be "fElementQName.rawName",
>          //In scanners most of the time is consumed on checks done for XML characters, we can
>          // optimize on it and avoid the checks done for endElement,
> -        //we will also avoid symbol table lookup - [hidden email]
> +        //we will also avoid symbol table lookup.
>  
>          // this should work both for namespace processing true or false...
>  
> @@ -2461,7 +2461,6 @@
>           * we dont need to set the value for every end element encouterd.
>           * For Well formedness checks we can have the same QName object that was pushed.
>           * the values will be set only if application need to know about the endElement
> -         * -- [hidden email]
>           */
>  
> +++ new/src/java.xml/share/classes/com/sun/xml/internal/stream/writers/XMLStreamWriterImpl.java 2017-12-21 15:37:09.426583713 -0800
> @@ -64,8 +64,8 @@
>   *
>   * @author Neeraj Bajaj
>   * @author K.Venugopal
> - * @author [hidden email]
> - * @author [hidden email]
> + * @author Santiago Pericas-Geertsen
> + * @author Sunitha Reddy
>   */
>  public final class XMLStreamWriterImpl extends AbstractMap<Object, Object>
>          implements XMLStreamWriterBase {
> @@ -2041,7 +2041,6 @@
>           * we dont need to set the value for every end element we encouter.
>           * For Well formedness checks we can have the same QName object that was pushed.
>           * the values will be set only if application need to know about the endElement
> -         * -- [hidden email]
>           */
>          public ElementState peek() {
>              return fElements[fDepth - 1];
>
>
> --- old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 15:19:37.505881261 -0800
> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 15:19:36.670799729 -0800
> @@ -39,8 +39,8 @@
>   * can be exposed to the application, we must intern all Strings before
>   * calling NamespaceSupport methods.
>   *
> - * @author  Neeraj Bajaj, Sun Microsystems, inc.
> - * @author [hidden email]
> + * @author  Neeraj Bajaj
> + * @author Santiago PericasGeertsen
>
> +++ new/src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/BaseMarkupSerializer.java 2017-12-21 15:19:47.796885990 -0800
> @@ -118,9 +118,9 @@
>   *
>   *
>   * @author <a href="mailto:[hidden email]">Assaf Arkin</a>
> - * @author <a href="mailto:[hidden email]">Rahul Srivastava</a>
> + * @author Rahul Srivastava
>   * @author Elena Litani, IBM
> - * @author Sunitha Reddy, Sun Microsystems
> + * @author Sunitha Reddy
>   * @see Serializer
>   * @see org.w3c.dom.ls.LSSerializer
>
> +++ new/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java 2017-12-21 15:20:05.831646762 -0800
> @@ -32,7 +32,7 @@
>  import javax.xml.XMLConstants;
>  /**
>   *
> - * @author  Neeraj Bajaj,[hidden email]  Sun Microsystems.
> + * @author  Neeraj Bajaj,K Venugopal
>
>
>
>> On 12/21/17, 2:35 PM, Lance Andersen wrote:
>> Hi Joe,
>>
>> Overall, this is fine, a few things to consider if you want to address
>>
>> Happy Holidays
>>
>> Best
>> Lance
>>
>> Do we really need to keep the name in comments such as these:
>>
>> final class TestSeq {
>> --- old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java 2017-12-21 11:04:12.188400062 -0800
>> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java 2017-12-21 11:04:11.423325345 -0800
>> @@ -682,7 +682,7 @@
>>                      // If the new name has a different prefix, the list may become unsorted.
>>                      // Maybe it would be better to resort the list, but the simplest
>>                      // fix seems to be to remove the old attribute and re-insert it.
>> -                    // -- [hidden email], 2 Feb 2007
>> +                    // -- Norman Walsh, 2 Feb 2007
>>
>>
>> Do we need Sun Microsystems, Inc  as we are not consistent
>>
>> --- old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 11:05:03.519413044 -0800
>> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 11:05:02.758338717 -0800
>> @@ -40,7 +40,7 @@
>>   * calling NamespaceSupport methods.
>>   *
>>   * @author  Neeraj Bajaj, Sun Microsystems, inc.
>> - * @author [hidden email]
>> + * @author Santiago PericasGeertsen
>>   *
>>   */
>> public class LocationImpl implements Location{
>>      String systemId;
>> --- old/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java 2017-12-21 11:05:31.112107741 -0800
>> +++ new/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java 2017-12-21 11:05:30.352033512 -0800
>> @@ -32,7 +32,7 @@
>>  import javax.xml.XMLConstants;
>>  /**
>>   *
>> - * @author  Neeraj Bajaj,[hidden email]  Sun Microsystems.
>> + * @author  Neeraj Bajaj,K Venugopal  Sun Microsystems.
>>   */
>>
>>> On Dec 21, 2017, at 2:23 PM, Joe Wang <[hidden email]> wrote:
>>>
>>> http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html
>>
>> <mime-attachment.gif>
>>
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> [hidden email]
>>
>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: RFR (JDK10/JAXP Doc-only) 8184431: References to @sun.com

huizhe wang
Thanks Lance!

On 12/21/17, 4:12 PM, Lance @ Oracle wrote:

> Hi joe
>
> Looks fine
>
> Best
> Lance
>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> <tel:+1.781.442.2037>
> Oracle Java Engineering
> 1 Network Drive <x-apple-data-detectors://34/0>
> Burlington, MA 01803 <x-apple-data-detectors://34/0>
> [hidden email] <mailto:[hidden email]>
> Sent from my iPad
>
> On Dec 21, 2017, at 6:48 PM, Joe Wang <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>> Hi Lance,
>>
>> Thanks for the review! As you suggested, the names in comments, and
>> "Sun Microsystems" in a few cases in the following classes are removed.
>>
>> Updated webrevs:
>> http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html
>>
>> Happy Holidays!
>>
>> Best,
>> Joe
>>
>> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java 2017-12-21 15:18:42.614522112 -0800
>> @@ -682,7 +682,6 @@
>>                       // If the new name has a different prefix, the list may become unsorted.
>>                       // Maybe it would be better to resort the list, but the simplest
>>                       // fix seems to be to remove the old attribute and re-insert it.
>> -                    // --[hidden email], 2 Feb 2007
>>                       newAttr = (Attr) attributes.removeItem(newAttr, false);
>>                       attributes.addItem(newAttr);
>>
>> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XML11NSDocumentScannerImpl.java 2017-12-21 15:18:47.069957104 -0800
>> @@ -741,7 +741,7 @@
>>           // Take advantage of the fact that next string _should_ be "fElementQName.rawName",
>>           //In scanners most of the time is consumed on checks done for XML characters, we can
>>           // optimize on it and avoid the checks done for endElement,
>> -        //we will also avoid symbol table lookup -[hidden email]
>> +        //we will also avoid symbol table lookup.
>> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java 2017-12-21 15:18:49.697213609 -0800
>> @@ -1670,7 +1670,7 @@
>>           // Take advantage of the fact that next string _should_ be "fElementQName.rawName",
>>           //In scanners most of the time is consumed on checks done for XML characters, we can
>>           // optimize on it and avoid the checks done for endElement,
>> -        //we will also avoid symbol table lookup -[hidden email]
>> +        //we will also avoid symbol table lookup.
>>
>>           // this should work both for namespace processing true or false...
>>
>> @@ -2461,7 +2461,6 @@
>>            * we dont need to set the value for every end element encouterd.
>>            * For Well formedness checks we can have the same QName object that was pushed.
>>            * the values will be set only if application need to know about the endElement
>> -         * --[hidden email]
>>            */
>>
>> +++ new/src/java.xml/share/classes/com/sun/xml/internal/stream/writers/XMLStreamWriterImpl.java 2017-12-21 15:37:09.426583713 -0800
>> @@ -64,8 +64,8 @@
>>    *
>>    * @author Neeraj Bajaj
>>    * @author K.Venugopal
>> - * @[hidden email]
>> - * @[hidden email]
>> + * @author Santiago Pericas-Geertsen
>> + * @author Sunitha Reddy
>>    */
>>   public final class XMLStreamWriterImpl extends AbstractMap<Object, Object>
>>           implements XMLStreamWriterBase {
>> @@ -2041,7 +2041,6 @@
>>            * we dont need to set the value for every end element we encouter.
>>            * For Well formedness checks we can have the same QName object that was pushed.
>>            * the values will be set only if application need to know about the endElement
>> -         * --[hidden email]
>>            */
>>           public ElementState peek() {
>>               return fElements[fDepth - 1];
>>
>> --- old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 15:19:37.505881261 -0800
>> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 15:19:36.670799729 -0800
>> @@ -39,8 +39,8 @@
>>    * can be exposed to the application, we must intern all Strings before
>>    * calling NamespaceSupport methods.
>>    *
>> - * @author  Neeraj Bajaj, Sun Microsystems, inc.
>> - * @[hidden email]
>> + * @author  Neeraj Bajaj
>> + * @author Santiago PericasGeertsen
>>
>> +++ new/src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/BaseMarkupSerializer.java 2017-12-21 15:19:47.796885990 -0800
>> @@ -118,9 +118,9 @@
>>    *
>>    *
>>    * @author<a href="mailto:[hidden email]">Assaf Arkin</a>
>> - * @author<a href="mailto:[hidden email]">Rahul Srivastava</a>
>> + * @author Rahul Srivastava
>>    * @author Elena Litani, IBM
>> - * @author Sunitha Reddy, Sun Microsystems
>> + * @author Sunitha Reddy
>>    * @see Serializer
>>    * @see org.w3c.dom.ls.LSSerializer
>>
>> +++ new/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java 2017-12-21 15:20:05.831646762 -0800
>> @@ -32,7 +32,7 @@
>>   import javax.xml.XMLConstants;
>>   /**
>>    *
>> - * @author  Neeraj Bajaj,[hidden email]   Sun Microsystems.
>> + * @author  Neeraj Bajaj,K Venugopal
>>
>>
>> On 12/21/17, 2:35 PM, Lance Andersen wrote:
>>> Hi Joe,
>>>
>>> Overall, this is fine, a few things to consider if you want to address
>>>
>>> Happy Holidays
>>>
>>> Best
>>> Lance
>>>
>>> Do we really need to keep the name in comments such as these:
>>>
>>> final class TestSeq {
>>> --- old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java 2017-12-21 11:04:12.188400062 -0800
>>> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java 2017-12-21 11:04:11.423325345 -0800
>>> @@ -682,7 +682,7 @@
>>>                       // If the new name has a different prefix, the list may become unsorted.
>>>                       // Maybe it would be better to resort the list, but the simplest
>>>                       // fix seems to be to remove the old attribute and re-insert it.
>>> -                    // --[hidden email]  <mailto:[hidden email]>, 2 Feb 2007
>>> +                    // -- Norman Walsh, 2 Feb 2007
>>>
>>>
>>> Do we need Sun Microsystems, Inc  as we are not consistent
>>>
>>> --- old/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 11:05:03.519413044 -0800
>>> +++ new/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java 2017-12-21 11:05:02.758338717 -0800
>>> @@ -40,7 +40,7 @@
>>>    * calling NamespaceSupport methods.
>>>    *
>>>    * @author  Neeraj Bajaj, Sun Microsystems, inc.
>>> - * @[hidden email]  <mailto:[hidden email]>
>>> + * @author Santiago PericasGeertsen
>>>    *
>>>    */
>>> public class LocationImpl implements Location{
>>>       String systemId;
>>> --- old/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java 2017-12-21 11:05:31.112107741 -0800
>>> +++ new/src/java.xml/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java 2017-12-21 11:05:30.352033512 -0800
>>> @@ -32,7 +32,7 @@
>>>   import javax.xml.XMLConstants;
>>>   /**
>>>    *
>>> - * @author  Neeraj Bajaj,[hidden email]  <mailto:[hidden email]>   Sun Microsystems.
>>> + * @author  Neeraj Bajaj,K Venugopal  Sun Microsystems.
>>>    */
>>>
>>>> On Dec 21, 2017, at 2:23 PM, Joe Wang <[hidden email]
>>>> <mailto:[hidden email]>> wrote:
>>>>
>>>> http://cr.openjdk.java.net/~joehw/jdk10/8184431/webrev/index.html 
>>>> <http://cr.openjdk.java.net/%7Ejoehw/jdk10/8184431/webrev/index.html>
>>>
>>> <mime-attachment.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
>>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> [hidden email] <mailto:[hidden email]>
>>>
>>>
>>>