RFR (JDK10/JAXP Doc-only) 8193568 : @LastModified tag in license header

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR (JDK10/JAXP Doc-only) 8193568 : @LastModified tag in license header

Joe Wang
Hi,

Refer to the previous change for JDK-8191938[1], the @LastModified tag
needs to be moved to the class description section. This change affects
341 files and may be hard to look through. But it's done with a script
that simply moves the tag from the top header to the class description
section, the majority therefore are two-line changes ( e.g "2 lines
changed"). If the original description section didn't have any tags, an
additional comment-line is added to separate the tag with the
description ( look for "3 lines changed"). If a class didn't have a
class description at all, a new one is added (therefore "4 lines changed").

Please review:
JBS: https://bugs.openjdk.java.net/browse/JDK-8193568
webrev: http://cr.openjdk.java.net/~joehw/jdk10/8193568/webrev/


[1] https://bugs.openjdk.java.net/browse/JDK-8191938

Thanks,
Joe
Reply | Threaded
Open this post in threaded view
|

Re: RFR (JDK10/JAXP Doc-only) 8193568 : @LastModified tag in license header

roger riggs
Hi Joe,

Looks fine

Thanks, Roger


On 12/20/2017 5:35 PM, Joe Wang wrote:

> Hi,
>
> Refer to the previous change for JDK-8191938[1], the @LastModified tag
> needs to be moved to the class description section. This change
> affects 341 files and may be hard to look through. But it's done with
> a script that simply moves the tag from the top header to the class
> description section, the majority therefore are two-line changes ( e.g
> "2 lines changed"). If the original description section didn't have
> any tags, an additional comment-line is added to separate the tag with
> the description ( look for "3 lines changed"). If a class didn't have
> a class description at all, a new one is added (therefore "4 lines
> changed").
>
> Please review:
> JBS: https://bugs.openjdk.java.net/browse/JDK-8193568
> webrev: http://cr.openjdk.java.net/~joehw/jdk10/8193568/webrev/
>
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8191938
>
> Thanks,
> Joe

Reply | Threaded
Open this post in threaded view
|

Re: RFR (JDK10/JAXP Doc-only) 8193568 : @LastModified tag in license header

Joe Wang
Thanks Roger!

On 12/21/17, 9:02 AM, Roger Riggs wrote:

> Hi Joe,
>
> Looks fine
>
> Thanks, Roger
>
>
> On 12/20/2017 5:35 PM, Joe Wang wrote:
>> Hi,
>>
>> Refer to the previous change for JDK-8191938[1], the @LastModified
>> tag needs to be moved to the class description section. This change
>> affects 341 files and may be hard to look through. But it's done with
>> a script that simply moves the tag from the top header to the class
>> description section, the majority therefore are two-line changes (
>> e.g "2 lines changed"). If the original description section didn't
>> have any tags, an additional comment-line is added to separate the
>> tag with the description ( look for "3 lines changed"). If a class
>> didn't have a class description at all, a new one is added (therefore
>> "4 lines changed").
>>
>> Please review:
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8193568
>> webrev: http://cr.openjdk.java.net/~joehw/jdk10/8193568/webrev/
>>
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8191938
>>
>> Thanks,
>> Joe
>