RFR(M): 8167457: Fixes for InetAddressImpl native coding on Windows

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

RFR(M): 8167457: Fixes for InetAddressImpl native coding on Windows

Langer, Christoph

Hi again,

 

after pushing the change for 8171077 (http://hg.openjdk.java.net/jdk9/dev/jdk/rev/24f8703890b2), I have updated my patch for 8167457 and I have also updated the bug description to reflect the reduced scope.

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8167457

Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8167457.0/

 

The change now merely is code cleanup which should not change the current behavior apart from removing the isspace(hostname[0]) check and the isDottedIPAddress check in Java_java_net_Inet4AddressImpl_lookupAllHostAddr. But testing lets me think it is not needed any longer for the supported Windows versions of JDK9.

 

Same as with 8167420, from my point of view this change is ready to push and it runs nightly in our builds/tests of OpenJDK on several platforms. Though I guess you want to postpone this to JDK10, I’d be glad if you could still consider it for JDK9. But I won’t pressure otherwise ;-)

 

Thanks & Best regards

Christoph