RFR (S) 8130072: Add a flag to print out statistics for both system dictionary and shared dictionary

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR (S) 8130072: Add a flag to print out statistics for both system dictionary and shared dictionary

coleen.phillimore
Summary: Include Shared Dictionary printing when printing system
dictionaries in jcmd

Also already included in -XX:+PrintSystemDictionaryAtExit. -Xshare:dump
also has already added for -XX:+PrintSystemDictionaryAtExit.

Tested with runThese in background and running jcmds, also see added test.

open webrev at http://cr.openjdk.java.net/~coleenp/8130072.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8130072

Thanks,
Coleen
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (S) 8130072: Add a flag to print out statistics for both system dictionary and shared dictionary

Aleksey Shipilev-4
On 08/02/2017 09:42 PM, [hidden email] wrote:
> open webrev at http://cr.openjdk.java.net/~coleenp/8130072.01/webrev

Looks good.

-Aleksey


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (S) 8130072: Add a flag to print out statistics for both system dictionary and shared dictionary

coleen.phillimore


On 8/2/17 3:44 PM, Aleksey Shipilev wrote:
> On 08/02/2017 09:42 PM, [hidden email] wrote:
>> open webrev at http://cr.openjdk.java.net/~coleenp/8130072.01/webrev
> Looks good.

Thank you for the fast code review!
Coleen

> -Aleksey
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (S) 8130072: Add a flag to print out statistics for both system dictionary and shared dictionary

George Triantafillou
In reply to this post by coleen.phillimore
Hi Coleen,

Looks good!

-George

On 8/2/2017 3:42 PM, [hidden email] wrote:

> Summary: Include Shared Dictionary printing when printing system
> dictionaries in jcmd
>
> Also already included in -XX:+PrintSystemDictionaryAtExit.
> -Xshare:dump also has already added for -XX:+PrintSystemDictionaryAtExit.
>
> Tested with runThese in background and running jcmds, also see added
> test.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8130072.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8130072
>
> Thanks,
> Coleen

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (S) 8130072: Add a flag to print out statistics for both system dictionary and shared dictionary

coleen.phillimore


On 8/2/17 4:25 PM, George Triantafillou wrote:
> Hi Coleen,
>
> Looks good!
>
Thanks, George!
Coleen

> -George
>
> On 8/2/2017 3:42 PM, [hidden email] wrote:
>> Summary: Include Shared Dictionary printing when printing system
>> dictionaries in jcmd
>>
>> Also already included in -XX:+PrintSystemDictionaryAtExit.
>> -Xshare:dump also has already added for
>> -XX:+PrintSystemDictionaryAtExit.
>>
>> Tested with runThese in background and running jcmds, also see added
>> test.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8130072.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8130072
>>
>> Thanks,
>> Coleen
>

Loading...