Quantcast

RFR(S): 8172050 - some compiler/calls/ tests should have /native option

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR(S): 8172050 - some compiler/calls/ tests should have /native option

dmitrij pochepko
Hi,

please review small fix for: 8172050 - some compiler/calls/ tests should
have /native option

According to jtreg guidelines, a /native option should be added to tests
run directive in case test use native libraries.

This fix adds this option. This change is going to be pushed to
jdk9/hs/hotspot since current push restrictions are not applied to test
fixes.


webrev:  http://cr.openjdk.java.net/~dpochepk/8172050/webrev.01/

CR: https://bugs.openjdk.java.net/browse/JDK-8172050

I've tested this change on linux-x64.

Thanks,

Dmitrij

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(S): 8172050 - some compiler/calls/ tests should have /native option

Vladimir Kozlov
Bug should be P3 to be in jdk9.

Changes looks good.

Thanks,
Vladimir

On 2/13/17 8:47 AM, Dmitrij Pochepko wrote:

> Hi,
>
> please review small fix for: 8172050 - some compiler/calls/ tests should have /native option
>
> According to jtreg guidelines, a /native option should be added to tests run directive in case test use native libraries.
>
> This fix adds this option. This change is going to be pushed to jdk9/hs/hotspot since current push restrictions are not applied to test fixes.
>
>
> webrev:  http://cr.openjdk.java.net/~dpochepk/8172050/webrev.01/
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8172050
>
> I've tested this change on linux-x64.
>
> Thanks,
>
> Dmitrij
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(S): 8172050 - some compiler/calls/ tests should have /native option

dmitrij pochepko
Thank you!


On 14.02.2017 00:45, Vladimir Kozlov wrote:

> Bug should be P3 to be in jdk9.
>
> Changes looks good.
>
> Thanks,
> Vladimir
>
> On 2/13/17 8:47 AM, Dmitrij Pochepko wrote:
>> Hi,
>>
>> please review small fix for: 8172050 - some compiler/calls/ tests
>> should have /native option
>>
>> According to jtreg guidelines, a /native option should be added to
>> tests run directive in case test use native libraries.
>>
>> This fix adds this option. This change is going to be pushed to
>> jdk9/hs/hotspot since current push restrictions are not applied to
>> test fixes.
>>
>>
>> webrev:  http://cr.openjdk.java.net/~dpochepk/8172050/webrev.01/
>>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8172050
>>
>> I've tested this change on linux-x64.
>>
>> Thanks,
>>
>> Dmitrij
>>

Loading...