RFR (S): 8176885: Clear Claimed Marks log message at wrong location in the log

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR (S): 8176885: Clear Claimed Marks log message at wrong location in the log

Thomas Schatzl
Hi all,

  can I have quick reviews for this change to the order of the "Clear
Claimed Marks" log message?

Two issues: it's at the wrong location, printed in the "Post Evacuate
Collection Set" section as it is executed during the "Evacuate
Collection Set" phase, and in the middle of the "(Parallel) Redirty"
log output.

Second, this task should actually be part of the "Pre Evacuate
Collection Set" phase, as the "Evacuate Collection Set" phase should
only contain the bare (parallel) evacuation itself.

I moved the log message and the actual code to the "pre evacuate
collection set" phase.

CR:
https://bugs.openjdk.java.net/browse/JDK-8176885
Webrev:
http://cr.openjdk.java.net/~tschatzl/8176885/webrev/
Testing:
local testing, inspecting log

Thanks,
  Thomas

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (S): 8176885: Clear Claimed Marks log message at wrong location in the log

Thomas Schatzl
Hi,

  could someone have a look at this "move some code around" change?

Thanks,
  Thomas

On Thu, 2017-03-16 at 18:53 +0100, Thomas Schatzl wrote:

> Hi all,
>
>   can I have quick reviews for this change to the order of the "Clear
> Claimed Marks" log message?
>
> Two issues: it's at the wrong location, printed in the "Post Evacuate
> Collection Set" section as it is executed during the "Evacuate
> Collection Set" phase, and in the middle of the "(Parallel) Redirty"
> log output.
>
> Second, this task should actually be part of the "Pre Evacuate
> Collection Set" phase, as the "Evacuate Collection Set" phase should
> only contain the bare (parallel) evacuation itself.
>
> I moved the log message and the actual code to the "pre evacuate
> collection set" phase.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8176885
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8176885/webrev/
> Testing:
> local testing, inspecting log
>
> Thanks,
>   Thomas
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (S): 8176885: Clear Claimed Marks log message at wrong location in the log

Stefan Johansson
Looks good,
Thanks for cleaning this up,
StefanJ

On 2017-03-24 13:30, Thomas Schatzl wrote:

> Hi,
>
>    could someone have a look at this "move some code around" change?
>
> Thanks,
>    Thomas
>
> On Thu, 2017-03-16 at 18:53 +0100, Thomas Schatzl wrote:
>> Hi all,
>>
>>    can I have quick reviews for this change to the order of the "Clear
>> Claimed Marks" log message?
>>
>> Two issues: it's at the wrong location, printed in the "Post Evacuate
>> Collection Set" section as it is executed during the "Evacuate
>> Collection Set" phase, and in the middle of the "(Parallel) Redirty"
>> log output.
>>
>> Second, this task should actually be part of the "Pre Evacuate
>> Collection Set" phase, as the "Evacuate Collection Set" phase should
>> only contain the bare (parallel) evacuation itself.
>>
>> I moved the log message and the actual code to the "pre evacuate
>> collection set" phase.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8176885
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8176885/webrev/
>> Testing:
>> local testing, inspecting log
>>
>> Thanks,
>>    Thomas
>>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (S): 8176885: Clear Claimed Marks log message at wrong location in the log

Thomas Schatzl
Hi Stefan,

On Mon, 2017-03-27 at 14:26 +0200, Stefan Johansson wrote:
> Looks good,
> Thanks for cleaning this up,
> StefanJ
>

  thanks for your review.

Thomas

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (S): 8176885: Clear Claimed Marks log message at wrong location in the log

sangheon.kim@oracle.com
In reply to this post by Thomas Schatzl
Hi Thomas,

This clean up looks good to me.

Thanks,
Sangheon


On 03/24/2017 05:30 AM, Thomas Schatzl wrote:

> Hi,
>
>    could someone have a look at this "move some code around" change?
>
> Thanks,
>    Thomas
>
> On Thu, 2017-03-16 at 18:53 +0100, Thomas Schatzl wrote:
>> Hi all,
>>
>>    can I have quick reviews for this change to the order of the "Clear
>> Claimed Marks" log message?
>>
>> Two issues: it's at the wrong location, printed in the "Post Evacuate
>> Collection Set" section as it is executed during the "Evacuate
>> Collection Set" phase, and in the middle of the "(Parallel) Redirty"
>> log output.
>>
>> Second, this task should actually be part of the "Pre Evacuate
>> Collection Set" phase, as the "Evacuate Collection Set" phase should
>> only contain the bare (parallel) evacuation itself.
>>
>> I moved the log message and the actual code to the "pre evacuate
>> collection set" phase.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8176885
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8176885/webrev/
>> Testing:
>> local testing, inspecting log
>>
>> Thanks,
>>    Thomas
>>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (S): 8176885: Clear Claimed Marks log message at wrong location in the log

Thomas Schatzl
Hi Sangheon,

On Mon, 2017-03-27 at 10:18 -0700, sangheon wrote:
> Hi Thomas,
>
> This clean up looks good to me.
>

  thanks for your review.

Thomas

Loading...