RFR(S): 8180003: Remove sys/ prefix from poll.h and signal.h includes

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(S): 8180003: Remove sys/ prefix from poll.h and signal.h includes

Mikael Vidstedt-3

Please review this small change which removes the sys/ prefix from a bunch of includes of poll.h and signal.h.

hotspot: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/hotspot/webrev/
jdk: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/jdk/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/jdk/webrev/>

Using the sys/ prefix works on many platforms, but the posix spec makes it clear that the poll.h and signal.h header files should be included without the prefix.

I have verified that this change works on all the Oracle supported platforms, but I could use some help verifying it on AIX.

Cheers,
Mikael

Reply | Threaded
Open this post in threaded view
|

Re: RFR(S): 8180003: Remove sys/ prefix from poll.h and signal.h includes

Brian Burkhalter-2

On May 9, 2017, at 2:29 PM, Mikael Vidstedt <[hidden email]> wrote:

> Please review this small change which removes the sys/ prefix from a bunch of includes of poll.h and signal.h.
>
> hotspot: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/hotspot/webrev/
> jdk: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/jdk/webrev/

The JDK NIO changes look fine at least.

> Using the sys/ prefix works on many platforms, but the posix spec makes it clear that the poll.h and signal.h header files should be included without the prefix.

Just had to look …

[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/poll.h.html
[2] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html

> I have verified that this change works on all the Oracle supported platforms, but I could use some help verifying it on AIX.

Good about the Oracle platforms.

Brian
Reply | Threaded
Open this post in threaded view
|

Re: RFR(S): 8180003: Remove sys/ prefix from poll.h and signal.h includes

David Holmes
In reply to this post by Mikael Vidstedt-3
Hi Mikael,

To repeat myself from:

http://mail.openjdk.java.net/pipermail/portola-dev/2017-April/000025.html

Changes look okay. I agree with the rationale.

Looking at actual implementations, linux and mac OS are trivially fine
(poll.h just includes sys/poll.h). Solaris is non-trivially fine -
poll.h does more than what sys/poll.h does, but nothing that affects our
sources.

Thanks,
David

:)

On 10/05/2017 7:29 AM, Mikael Vidstedt wrote:

>
> Please review this small change which removes the sys/ prefix from a bunch of includes of poll.h and signal.h.
>
> hotspot: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/hotspot/webrev/
> jdk: http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/jdk/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8180003/webrev.00/jdk/webrev/>
>
> Using the sys/ prefix works on many platforms, but the posix spec makes it clear that the poll.h and signal.h header files should be included without the prefix.
>
> I have verified that this change works on all the Oracle supported platforms, but I could use some help verifying it on AIX.
>
> Cheers,
> Mikael
>