RFR(S) : 8180037 : move jdk.test.lib.InMemoryJavaCompiler to a separate package

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(S) : 8180037 : move jdk.test.lib.InMemoryJavaCompiler to a separate package

Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8180037/webrev.00/index.html
> 41 lines changed: 3 ins; 13 del; 25 mod;

Hi all,

could you please review this small patch which moves jdk.test.lib.InMemoryJavaCompiler to  jdk.test.lib.compiler package and updates the tests?
InMemoryJavaCompiler depends on java.compiler module, so in order to avoid unneeded module dependency it should be moved to a separate package.

webrev: http://cr.openjdk.java.net/~iignatyev//8180037/webrev.00/index.html
JBS: https://bugs.openjdk.java.net/browse/JDK-8180037
testing: :hotspot_all

Thanks,
-- Igor
Reply | Threaded
Open this post in threaded view
|

Re: RFR(S) : 8180037 : move jdk.test.lib.InMemoryJavaCompiler to a separate package

Mikhailo Seledtsov
Hi Igor,

     Changes look good,


Misha

On 05/09/2017 09:30 PM, Igor Ignatyev wrote:

> http://cr.openjdk.java.net/~iignatyev//8180037/webrev.00/index.html
>> 41 lines changed: 3 ins; 13 del; 25 mod;
> Hi all,
>
> could you please review this small patch which moves jdk.test.lib.InMemoryJavaCompiler to  jdk.test.lib.compiler package and updates the tests?
> InMemoryJavaCompiler depends on java.compiler module, so in order to avoid unneeded module dependency it should be moved to a separate package.
>
> webrev: http://cr.openjdk.java.net/~iignatyev//8180037/webrev.00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8180037
> testing: :hotspot_all
>
> Thanks,
> -- Igor

Reply | Threaded
Open this post in threaded view
|

Re: RFR(S) : 8180037 : move jdk.test.lib.InMemoryJavaCompiler to a separate package

Vladimir Ivanov
In reply to this post by Igor Ignatyev
Reviewed.

Best regards,
Vladimir Ivanov

On 5/10/17 7:30 AM, Igor Ignatyev wrote:

> http://cr.openjdk.java.net/~iignatyev//8180037/webrev.00/index.html
>> 41 lines changed: 3 ins; 13 del; 25 mod;
>
> Hi all,
>
> could you please review this small patch which moves jdk.test.lib.InMemoryJavaCompiler to  jdk.test.lib.compiler package and updates the tests?
> InMemoryJavaCompiler depends on java.compiler module, so in order to avoid unneeded module dependency it should be moved to a separate package.
>
> webrev: http://cr.openjdk.java.net/~iignatyev//8180037/webrev.00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8180037
> testing: :hotspot_all
>
> Thanks,
> -- Igor
>