RFR(S): 8182755: [JVMCI] Deoptimization in synchronized methods can lead to a crash or exception when using EnableJVMCI but not UseJVMCICompiler

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(S): 8182755: [JVMCI] Deoptimization in synchronized methods can lead to a crash or exception when using EnableJVMCI but not UseJVMCICompiler

Gilles Duboscq-2
Please review the following fix for deoptimization when using +EnableJVMCI and -UseJVMCICompiler.
In this mode there can still be methods compiled by JVMCI so the interpreter needs to support potential pending monitors.

Bug: https://bugs.openjdk.java.net/browse/JDK-8182755
Webrev: http://cr.openjdk.java.net/~gdub/webrev-8182755/

 Gilles
Reply | Threaded
Open this post in threaded view
|

Re: RFR(S): 8182755: [JVMCI] Deoptimization in synchronized methods can lead to a crash or exception when using EnableJVMCI but not UseJVMCICompiler

Vladimir Kozlov
Looks good.

Thanks,
Vladimir

On 11/6/17 6:40 AM, Gilles Duboscq wrote:
> Please review the following fix for deoptimization when using +EnableJVMCI and -UseJVMCICompiler.
> In this mode there can still be methods compiled by JVMCI so the interpreter needs to support potential pending monitors.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8182755
> Webrev: http://cr.openjdk.java.net/~gdub/webrev-8182755/
>
>   Gilles
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR(S): 8182755: [JVMCI] Deoptimization in synchronized methods can lead to a crash or exception when using EnableJVMCI but not UseJVMCICompiler

Tobias Hartmann-2
In reply to this post by Gilles Duboscq-2
Hi Gilles,

looks good to me as well.

Thanks,
Tobias

On 06.11.2017 15:40, Gilles Duboscq wrote:
> Please review the following fix for deoptimization when using +EnableJVMCI and -UseJVMCICompiler.
> In this mode there can still be methods compiled by JVMCI so the interpreter needs to support potential pending monitors.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8182755
> Webrev: http://cr.openjdk.java.net/~gdub/webrev-8182755/
>
>  Gilles
>