RFR(S) : 8184689 : Test applications/ctw/Modules.java fails with AssertionError in sun.hotspot.tools.ctw.Utils.fileNameToClassName

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR(S) : 8184689 : Test applications/ctw/Modules.java fails with AssertionError in sun.hotspot.tools.ctw.Utils.fileNameToClassName

Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8184689/webrev.00/index.html
> 13 lines changed: 7 ins; 4 del; 2 mod;

Hi all,

could you please review this bugfix for CTW library?

problem: assert in sun.hotspot.tools.ctw.Utils fails for jimage entry, b/c such entries have "/<module_name>/" prefix and module_name can have a period in it, e.g. '/java.activation/com/sun/activation/registries/LineTokenizer.class'
fix: remove module name from jimage entry names, so they will pass assert. this also made workaround in Utils::fileNameToClassName redundant, so it has been removed.

bug: https://bugs.openjdk.java.net/browse/JDK-8184689
webrev: http://cr.openjdk.java.net/~iignatyev//8184689/webrev.00/index.html
testing: hotspot/test/applications/ctw/Modules.java w/ '-ea -esa'

Thanks,
-- Igor
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(S) : 8184689 : Test applications/ctw/Modules.java fails with AssertionError in sun.hotspot.tools.ctw.Utils.fileNameToClassName

Vladimir Kozlov
Good.

Thanks,
Vladimir

On 8/9/17 7:56 PM, Igor Ignatyev wrote:

> http://cr.openjdk.java.net/~iignatyev//8184689/webrev.00/index.html
>> 13 lines changed: 7 ins; 4 del; 2 mod;
>
> Hi all,
>
> could you please review this bugfix for CTW library?
>
> problem: assert in sun.hotspot.tools.ctw.Utils fails for jimage entry, b/c such entries have "/<module_name>/" prefix and module_name can have a period in it, e.g. '/java.activation/com/sun/activation/registries/LineTokenizer.class'
> fix: remove module name from jimage entry names, so they will pass assert. this also made workaround in Utils::fileNameToClassName redundant, so it has been removed.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8184689
> webrev: http://cr.openjdk.java.net/~iignatyev//8184689/webrev.00/index.html
> testing: hotspot/test/applications/ctw/Modules.java w/ '-ea -esa'
>
> Thanks,
> -- Igor
>
Loading...