RFR(S): 8185046: jtreg: introduce keyword to disable aot tests

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR(S): 8185046: jtreg: introduce keyword to disable aot tests

Lindenmaier, Goetz

Hi,

 

if we build without INCLUDE_AOT, we need to exclude the aot tests.

I added keyword ‘aot’ to all those that fail if AOT is missing.

 

Please review this change. I please need a sponsor.

http://cr.openjdk.java.net/~goetz/wr17/8185046-aotKey/webrev.01/index.html

 

Best regards,

  Goetz.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests

Vladimir Kozlov
Thank you, Goetz

I think you missed few tests.

There are 7 junit tests:

compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*

And 4 calls tests:

compiler/aot/calls/fromAot/AotInvokeDynamic*

Thanks,
Vladimir

On 7/21/17 3:57 AM, Lindenmaier, Goetz wrote:

> Hi,
>
> if we build without INCLUDE_AOT, we need to exclude the aot tests.
>
> I added keyword ‘aot’ to all those that fail if AOT is missing.
>
> Please review this change. I please need a sponsor.
>
> http://cr.openjdk.java.net/~goetz/wr17/8185046-aotKey/webrev.01/index.html
>
> Best regards,
>
>    Goetz.
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests

Lindenmaier, Goetz
Hi Vladimir,

I left them out because they didn't cause errors even without INCLUDE_AOT.
I must add the AotInvokeDynamic ones, as they will fail once the @ignore is
removed.
But as I understand the
> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
don't depend on aot. Should I tag them anyways?  

Best regards,
  Goetz.

> -----Original Message-----
> From: Vladimir Kozlov [mailto:[hidden email]]
> Sent: Freitag, 21. Juli 2017 18:49
> To: Lindenmaier, Goetz <[hidden email]>; hotspot-compiler-
> [hidden email]
> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
>
> Thank you, Goetz
>
> I think you missed few tests.
>
> There are 7 junit tests:
>
> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
>
> And 4 calls tests:
>
> compiler/aot/calls/fromAot/AotInvokeDynamic*
>
> Thanks,
> Vladimir
>
> On 7/21/17 3:57 AM, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > if we build without INCLUDE_AOT, we need to exclude the aot tests.
> >
> > I added keyword 'aot' to all those that fail if AOT is missing.
> >
> > Please review this change. I please need a sponsor.
> >
> > http://cr.openjdk.java.net/~goetz/wr17/8185046-
> aotKey/webrev.01/index.html
> >
> > Best regards,
> >
> >    Goetz.
> >
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests

Vladimir Kozlov
On 7/23/17 11:31 PM, Lindenmaier, Goetz wrote:
> Hi Vladimir,
>
> I left them out because they didn't cause errors even without INCLUDE_AOT.
> I must add the AotInvokeDynamic ones, as they will fail once the @ignore is
> removed.
> But as I understand the
>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
> don't depend on aot. Should I tag them anyways?

Yes, please.

Vladimir

>
> Best regards,
>    Goetz.
>
>> -----Original Message-----
>> From: Vladimir Kozlov [mailto:[hidden email]]
>> Sent: Freitag, 21. Juli 2017 18:49
>> To: Lindenmaier, Goetz <[hidden email]>; hotspot-compiler-
>> [hidden email]
>> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
>>
>> Thank you, Goetz
>>
>> I think you missed few tests.
>>
>> There are 7 junit tests:
>>
>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
>>
>> And 4 calls tests:
>>
>> compiler/aot/calls/fromAot/AotInvokeDynamic*
>>
>> Thanks,
>> Vladimir
>>
>> On 7/21/17 3:57 AM, Lindenmaier, Goetz wrote:
>>> Hi,
>>>
>>> if we build without INCLUDE_AOT, we need to exclude the aot tests.
>>>
>>> I added keyword 'aot' to all those that fail if AOT is missing.
>>>
>>> Please review this change. I please need a sponsor.
>>>
>>> http://cr.openjdk.java.net/~goetz/wr17/8185046-
>> aotKey/webrev.01/index.html
>>>
>>> Best regards,
>>>
>>>     Goetz.
>>>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests

Lindenmaier, Goetz
Hi Vladimir,

I added all of them.  And I think I got the copyrights right, now.
http://cr.openjdk.java.net/~goetz/wr17/8185046-aotKey/webrev.02/index.html

Best regards,
  Goetz.

> -----Original Message-----
> From: Vladimir Kozlov [mailto:[hidden email]]
> Sent: Montag, 24. Juli 2017 18:19
> To: Lindenmaier, Goetz <[hidden email]>; hotspot-compiler-
> [hidden email]
> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
>
> On 7/23/17 11:31 PM, Lindenmaier, Goetz wrote:
> > Hi Vladimir,
> >
> > I left them out because they didn't cause errors even without
> INCLUDE_AOT.
> > I must add the AotInvokeDynamic ones, as they will fail once the @ignore is
> > removed.
> > But as I understand the
> >> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
> > don't depend on aot. Should I tag them anyways?
>
> Yes, please.
>
> Vladimir
>
> >
> > Best regards,
> >    Goetz.
> >
> >> -----Original Message-----
> >> From: Vladimir Kozlov [mailto:[hidden email]]
> >> Sent: Freitag, 21. Juli 2017 18:49
> >> To: Lindenmaier, Goetz <[hidden email]>; hotspot-
> compiler-
> >> [hidden email]
> >> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
> >>
> >> Thank you, Goetz
> >>
> >> I think you missed few tests.
> >>
> >> There are 7 junit tests:
> >>
> >> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
> >>
> >> And 4 calls tests:
> >>
> >> compiler/aot/calls/fromAot/AotInvokeDynamic*
> >>
> >> Thanks,
> >> Vladimir
> >>
> >> On 7/21/17 3:57 AM, Lindenmaier, Goetz wrote:
> >>> Hi,
> >>>
> >>> if we build without INCLUDE_AOT, we need to exclude the aot tests.
> >>>
> >>> I added keyword 'aot' to all those that fail if AOT is missing.
> >>>
> >>> Please review this change. I please need a sponsor.
> >>>
> >>> http://cr.openjdk.java.net/~goetz/wr17/8185046-
> >> aotKey/webrev.01/index.html
> >>>
> >>> Best regards,
> >>>
> >>>     Goetz.
> >>>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests

Thomas Stüfe-2
Hi Goetz,

This looks fine. 

Best Regards, Thomas

On Jul 25, 2017 09:38, "Lindenmaier, Goetz" <[hidden email]> wrote:
Hi Vladimir,

I added all of them.  And I think I got the copyrights right, now.
http://cr.openjdk.java.net/~goetz/wr17/8185046-aotKey/webrev.02/index.html

Best regards,
  Goetz.

> -----Original Message-----
> From: Vladimir Kozlov [mailto:[hidden email]]
> Sent: Montag, 24. Juli 2017 18:19
> To: Lindenmaier, Goetz <[hidden email]>; hotspot-compiler-
> [hidden email]
> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
>
> On 7/23/17 11:31 PM, Lindenmaier, Goetz wrote:
> > Hi Vladimir,
> >
> > I left them out because they didn't cause errors even without
> INCLUDE_AOT.
> > I must add the AotInvokeDynamic ones, as they will fail once the @ignore is
> > removed.
> > But as I understand the
> >> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
> > don't depend on aot. Should I tag them anyways?
>
> Yes, please.
>
> Vladimir
>
> >
> > Best regards,
> >    Goetz.
> >
> >> -----Original Message-----
> >> From: Vladimir Kozlov [mailto:[hidden email]]
> >> Sent: Freitag, 21. Juli 2017 18:49
> >> To: Lindenmaier, Goetz <[hidden email]>; hotspot-
> compiler-
> >> [hidden email]
> >> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
> >>
> >> Thank you, Goetz
> >>
> >> I think you missed few tests.
> >>
> >> There are 7 junit tests:
> >>
> >> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
> >>
> >> And 4 calls tests:
> >>
> >> compiler/aot/calls/fromAot/AotInvokeDynamic*
> >>
> >> Thanks,
> >> Vladimir
> >>
> >> On 7/21/17 3:57 AM, Lindenmaier, Goetz wrote:
> >>> Hi,
> >>>
> >>> if we build without INCLUDE_AOT, we need to exclude the aot tests.
> >>>
> >>> I added keyword 'aot' to all those that fail if AOT is missing.
> >>>
> >>> Please review this change. I please need a sponsor.
> >>>
> >>> http://cr.openjdk.java.net/~goetz/wr17/8185046-
> >> aotKey/webrev.01/index.html
> >>>
> >>> Best regards,
> >>>
> >>>     Goetz.
> >>>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests

Lindenmaier, Goetz
Hi Thomas,

thanks for reviewing!

Best regards,
  Goetz.

> -----Original Message-----
> From: Thomas Stüfe [mailto:[hidden email]]
> Sent: Dienstag, 25. Juli 2017 16:11
> To: Lindenmaier, Goetz <[hidden email]>
> Cc: hotspot compiler <[hidden email]>
> Subject: RE: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
>
> Hi Goetz,
>
> This looks fine.
>
> Best Regards, Thomas
>
> On Jul 25, 2017 09:38, "Lindenmaier, Goetz" <[hidden email]
> <mailto:[hidden email]> > wrote:
>
>
> Hi Vladimir,
>
> I added all of them.  And I think I got the copyrights right, now.
> http://cr.openjdk.java.net/~goetz/wr17/8185046-
> aotKey/webrev.02/index.html
> <http://cr.openjdk.java.net/~goetz/wr17/8185046-
> aotKey/webrev.02/index.html>
>
> Best regards,
>  Goetz.
>
> > -----Original Message-----
> > From: Vladimir Kozlov [mailto:[hidden email]
> <mailto:[hidden email]> ]
> > Sent: Montag, 24. Juli 2017 18:19
> > To: Lindenmaier, Goetz <[hidden email]
> <mailto:[hidden email]> >; hotspot-compiler-
> > [hidden email] <mailto:[hidden email]>
> > Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable
> aot tests
> >
> > On 7/23/17 11:31 PM, Lindenmaier, Goetz wrote:
> > > Hi Vladimir,
> > >
> > > I left them out because they didn't cause errors even without
> > INCLUDE_AOT.
> > > I must add the AotInvokeDynamic ones, as they will fail once the
> @ignore is
> > > removed.
> > > But as I understand the
> > >> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
> > > don't depend on aot. Should I tag them anyways?
> >
> > Yes, please.
> >
> > Vladimir
> >
> > >
> > > Best regards,
> > >    Goetz.
> > >
> > >> -----Original Message-----
> > >> From: Vladimir Kozlov [mailto:[hidden email]
> <mailto:[hidden email]> ]
> > >> Sent: Freitag, 21. Juli 2017 18:49
> > >> To: Lindenmaier, Goetz <[hidden email]
> <mailto:[hidden email]> >; hotspot-
> > compiler-
> > >> [hidden email] <mailto:[hidden email]>
> > >> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable
> aot tests
> > >>
> > >> Thank you, Goetz
> > >>
> > >> I think you missed few tests.
> > >>
> > >> There are 7 junit tests:
> > >>
> > >> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
> > >>
> > >> And 4 calls tests:
> > >>
> > >> compiler/aot/calls/fromAot/AotInvokeDynamic*
> > >>
> > >> Thanks,
> > >> Vladimir
> > >>
> > >> On 7/21/17 3:57 AM, Lindenmaier, Goetz wrote:
> > >>> Hi,
> > >>>
> > >>> if we build without INCLUDE_AOT, we need to exclude the aot
> tests.
> > >>>
> > >>> I added keyword 'aot' to all those that fail if AOT is missing.
> > >>>
> > >>> Please review this change. I please need a sponsor.
> > >>>
> > >>> http://cr.openjdk.java.net/~goetz/wr17/8185046-
> <http://cr.openjdk.java.net/~goetz/wr17/8185046->
> > >> aotKey/webrev.01/index.html
> > >>>
> > >>> Best regards,
> > >>>
> > >>>     Goetz.
> > >>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests

Vladimir Kozlov
In reply to this post by Lindenmaier, Goetz
Looks good.

Vladimir

On 7/25/17 12:37 AM, Lindenmaier, Goetz wrote:

> Hi Vladimir,
>
> I added all of them.  And I think I got the copyrights right, now.
> http://cr.openjdk.java.net/~goetz/wr17/8185046-aotKey/webrev.02/index.html
>
> Best regards,
>    Goetz.
>
>> -----Original Message-----
>> From: Vladimir Kozlov [mailto:[hidden email]]
>> Sent: Montag, 24. Juli 2017 18:19
>> To: Lindenmaier, Goetz <[hidden email]>; hotspot-compiler-
>> [hidden email]
>> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
>>
>> On 7/23/17 11:31 PM, Lindenmaier, Goetz wrote:
>>> Hi Vladimir,
>>>
>>> I left them out because they didn't cause errors even without
>> INCLUDE_AOT.
>>> I must add the AotInvokeDynamic ones, as they will fail once the @ignore is
>>> removed.
>>> But as I understand the
>>>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
>>> don't depend on aot. Should I tag them anyways?
>>
>> Yes, please.
>>
>> Vladimir
>>
>>>
>>> Best regards,
>>>     Goetz.
>>>
>>>> -----Original Message-----
>>>> From: Vladimir Kozlov [mailto:[hidden email]]
>>>> Sent: Freitag, 21. Juli 2017 18:49
>>>> To: Lindenmaier, Goetz <[hidden email]>; hotspot-
>> compiler-
>>>> [hidden email]
>>>> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
>>>>
>>>> Thank you, Goetz
>>>>
>>>> I think you missed few tests.
>>>>
>>>> There are 7 junit tests:
>>>>
>>>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
>>>>
>>>> And 4 calls tests:
>>>>
>>>> compiler/aot/calls/fromAot/AotInvokeDynamic*
>>>>
>>>> Thanks,
>>>> Vladimir
>>>>
>>>> On 7/21/17 3:57 AM, Lindenmaier, Goetz wrote:
>>>>> Hi,
>>>>>
>>>>> if we build without INCLUDE_AOT, we need to exclude the aot tests.
>>>>>
>>>>> I added keyword 'aot' to all those that fail if AOT is missing.
>>>>>
>>>>> Please review this change. I please need a sponsor.
>>>>>
>>>>> http://cr.openjdk.java.net/~goetz/wr17/8185046-
>>>> aotKey/webrev.01/index.html
>>>>>
>>>>> Best regards,
>>>>>
>>>>>      Goetz.
>>>>>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests

Vladimir Kozlov
And I will sponsor it since we have 2 okay reviews.

Vladimir

On 7/25/17 9:11 AM, Vladimir Kozlov wrote:

> Looks good.
>
> Vladimir
>
> On 7/25/17 12:37 AM, Lindenmaier, Goetz wrote:
>> Hi Vladimir,
>>
>> I added all of them.  And I think I got the copyrights right, now.
>> http://cr.openjdk.java.net/~goetz/wr17/8185046-aotKey/webrev.02/index.html
>>
>> Best regards,
>>    Goetz.
>>
>>> -----Original Message-----
>>> From: Vladimir Kozlov [mailto:[hidden email]]
>>> Sent: Montag, 24. Juli 2017 18:19
>>> To: Lindenmaier, Goetz <[hidden email]>; hotspot-compiler-
>>> [hidden email]
>>> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
>>>
>>> On 7/23/17 11:31 PM, Lindenmaier, Goetz wrote:
>>>> Hi Vladimir,
>>>>
>>>> I left them out because they didn't cause errors even without
>>> INCLUDE_AOT.
>>>> I must add the AotInvokeDynamic ones, as they will fail once the @ignore is
>>>> removed.
>>>> But as I understand the
>>>>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
>>>> don't depend on aot. Should I tag them anyways?
>>>
>>> Yes, please.
>>>
>>> Vladimir
>>>
>>>>
>>>> Best regards,
>>>>     Goetz.
>>>>
>>>>> -----Original Message-----
>>>>> From: Vladimir Kozlov [mailto:[hidden email]]
>>>>> Sent: Freitag, 21. Juli 2017 18:49
>>>>> To: Lindenmaier, Goetz <[hidden email]>; hotspot-
>>> compiler-
>>>>> [hidden email]
>>>>> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
>>>>>
>>>>> Thank you, Goetz
>>>>>
>>>>> I think you missed few tests.
>>>>>
>>>>> There are 7 junit tests:
>>>>>
>>>>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
>>>>>
>>>>> And 4 calls tests:
>>>>>
>>>>> compiler/aot/calls/fromAot/AotInvokeDynamic*
>>>>>
>>>>> Thanks,
>>>>> Vladimir
>>>>>
>>>>> On 7/21/17 3:57 AM, Lindenmaier, Goetz wrote:
>>>>>> Hi,
>>>>>>
>>>>>> if we build without INCLUDE_AOT, we need to exclude the aot tests.
>>>>>>
>>>>>> I added keyword 'aot' to all those that fail if AOT is missing.
>>>>>>
>>>>>> Please review this change. I please need a sponsor.
>>>>>>
>>>>>> http://cr.openjdk.java.net/~goetz/wr17/8185046-
>>>>> aotKey/webrev.01/index.html
>>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>>      Goetz.
>>>>>>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests

Lindenmaier, Goetz
Thanks a lot!

Best regards,
  Götz

> Am 25.07.2017 um 19:09 schrieb Vladimir Kozlov <[hidden email]>:
>
> And I will sponsor it since we have 2 okay reviews.
>
> Vladimir
>
>> On 7/25/17 9:11 AM, Vladimir Kozlov wrote:
>> Looks good.
>> Vladimir
>>> On 7/25/17 12:37 AM, Lindenmaier, Goetz wrote:
>>> Hi Vladimir,
>>>
>>> I added all of them.  And I think I got the copyrights right, now.
>>> http://cr.openjdk.java.net/~goetz/wr17/8185046-aotKey/webrev.02/index.html
>>>
>>> Best regards,
>>>   Goetz.
>>>
>>>> -----Original Message-----
>>>> From: Vladimir Kozlov [mailto:[hidden email]]
>>>> Sent: Montag, 24. Juli 2017 18:19
>>>> To: Lindenmaier, Goetz <[hidden email]>; hotspot-compiler-
>>>> [hidden email]
>>>> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
>>>>
>>>>> On 7/23/17 11:31 PM, Lindenmaier, Goetz wrote:
>>>>> Hi Vladimir,
>>>>>
>>>>> I left them out because they didn't cause errors even without
>>>> INCLUDE_AOT.
>>>>> I must add the AotInvokeDynamic ones, as they will fail once the @ignore is
>>>>> removed.
>>>>> But as I understand the
>>>>>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
>>>>> don't depend on aot. Should I tag them anyways?
>>>>
>>>> Yes, please.
>>>>
>>>> Vladimir
>>>>
>>>>>
>>>>> Best regards,
>>>>>    Goetz.
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Vladimir Kozlov [mailto:[hidden email]]
>>>>>> Sent: Freitag, 21. Juli 2017 18:49
>>>>>> To: Lindenmaier, Goetz <[hidden email]>; hotspot-
>>>> compiler-
>>>>>> [hidden email]
>>>>>> Subject: Re: RFR(S): 8185046: jtreg: introduce keyword to disable aot tests
>>>>>>
>>>>>> Thank you, Goetz
>>>>>>
>>>>>> I think you missed few tests.
>>>>>>
>>>>>> There are 7 junit tests:
>>>>>>
>>>>>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/*
>>>>>>
>>>>>> And 4 calls tests:
>>>>>>
>>>>>> compiler/aot/calls/fromAot/AotInvokeDynamic*
>>>>>>
>>>>>> Thanks,
>>>>>> Vladimir
>>>>>>
>>>>>>> On 7/21/17 3:57 AM, Lindenmaier, Goetz wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> if we build without INCLUDE_AOT, we need to exclude the aot tests.
>>>>>>>
>>>>>>> I added keyword 'aot' to all those that fail if AOT is missing.
>>>>>>>
>>>>>>> Please review this change. I please need a sponsor.
>>>>>>>
>>>>>>> http://cr.openjdk.java.net/~goetz/wr17/8185046-
>>>>>> aotKey/webrev.01/index.html
>>>>>>>
>>>>>>> Best regards,
>>>>>>>
>>>>>>>     Goetz.
>>>>>>>
Loading...