RFR(S) : 8185536 : @key aot should be replaced w/ @requires vm.aot

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR(S) : 8185536 : @key aot should be replaced w/ @requires vm.aot

Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8185536/webrev.00/index.html
> 81 lines changed: 19 ins; 0 del; 62 mod

Hi all,

could you please review this small patch which introduces 'vm.aot' property into jtreg @requires context and replaces all '@key aot' added by 8185046[1] w/ '@requiers vm.aot'?
Goetz(author of 8185046) is checking that it works for their configurations.

JBS: https://bugs.openjdk.java.net/browse/JDK-8185536
webrev: http://cr.openjdk.java.net/~iignatyev//8185536/webrev.00/index.html
testing: hotspot/test/compiler/aot tests
 - on linux-x64 : 56 tests selected/run
 - on linux-x86 : 0 tests selected/run
 - on windows-x64 (after remove tests from problemlist) : 56 tests selected/run
 - on windows-x86 (after remove tests from problemlist) : 0 tests selected/run

[1] https://bugs.openjdk.java.net/browse/JDK-8185046

Thanks,
-- Igor
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(S) : 8185536 : @key aot should be replaced w/ @requires vm.aot

Vladimir Kozlov
Looks good.

Thanks,
Vladimir

On 8/1/17 8:51 AM, Igor Ignatyev wrote:

> http://cr.openjdk.java.net/~iignatyev//8185536/webrev.00/index.html
>> 81 lines changed: 19 ins; 0 del; 62 mod
>
> Hi all,
>
> could you please review this small patch which introduces 'vm.aot' property into jtreg @requires context and replaces all '@key aot' added by 8185046[1] w/ '@requiers vm.aot'?
> Goetz(author of 8185046) is checking that it works for their configurations.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8185536
> webrev: http://cr.openjdk.java.net/~iignatyev//8185536/webrev.00/index.html
> testing: hotspot/test/compiler/aot tests
>   - on linux-x64 : 56 tests selected/run
>   - on linux-x86 : 0 tests selected/run
>   - on windows-x64 (after remove tests from problemlist) : 56 tests selected/run
>   - on windows-x86 (after remove tests from problemlist) : 0 tests selected/run
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8185046
>
> Thanks,
> -- Igor
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: RFR(S) : 8185536 : @key aot should be replaced w/ @requires vm.aot

Lindenmaier, Goetz
In reply to this post by Igor Ignatyev
Hi Igor,

the change is looking good.

A small thing, I would spell vmAot() as vmAOT(), all abbreviations
(except for Jvmci) are capitalized here.

It passed the tests on all platforms that have been running so far.
(Some had an unrelated issue tonight).

Best regards,
  Goetz.

> -----Original Message-----
> From: Igor Ignatyev [mailto:[hidden email]]
> Sent: Dienstag, 1. August 2017 17:51
> To: [hidden email] compiler <hotspot-compiler-
> [hidden email]>
> Cc: Lindenmaier, Goetz <[hidden email]>
> Subject: RFR(S) : 8185536 : @key aot should be replaced w/ @requires
> vm.aot
>
> http://cr.openjdk.java.net/~iignatyev//8185536/webrev.00/index.html
> > 81 lines changed: 19 ins; 0 del; 62 mod
>
> Hi all,
>
> could you please review this small patch which introduces 'vm.aot' property
> into jtreg @requires context and replaces all '@key aot' added by 8185046[1]
> w/ '@requiers vm.aot'?
> Goetz(author of 8185046) is checking that it works for their configurations.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8185536
> webrev:
> http://cr.openjdk.java.net/~iignatyev//8185536/webrev.00/index.html
> testing: hotspot/test/compiler/aot tests
>  - on linux-x64 : 56 tests selected/run
>  - on linux-x86 : 0 tests selected/run
>  - on windows-x64 (after remove tests from problemlist) : 56 tests
> selected/run
>  - on windows-x86 (after remove tests from problemlist) : 0 tests
> selected/run
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8185046
>
> Thanks,
> -- Igor
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(S) : 8185536 : @key aot should be replaced w/ @requires vm.aot

Igor Ignatyev
Vladimir, Goetz,

thank you for your review. Although abbreviations should not be upper-cased in method names, I've renamed vmAot to vmAOT to be consistent w/ the rest of the class.

-- Igor

> On Aug 2, 2017, at 5:49 AM, Lindenmaier, Goetz <[hidden email]> wrote:
>
> Hi Igor,
>
> the change is looking good.
>
> A small thing, I would spell vmAot() as vmAOT(), all abbreviations
> (except for Jvmci) are capitalized here.
>
> It passed the tests on all platforms that have been running so far.
> (Some had an unrelated issue tonight).
>
> Best regards,
>  Goetz.
>
>> -----Original Message-----
>> From: Igor Ignatyev [mailto:[hidden email]]
>> Sent: Dienstag, 1. August 2017 17:51
>> To: [hidden email] compiler <hotspot-compiler-
>> [hidden email]>
>> Cc: Lindenmaier, Goetz <[hidden email]>
>> Subject: RFR(S) : 8185536 : @key aot should be replaced w/ @requires
>> vm.aot
>>
>> http://cr.openjdk.java.net/~iignatyev//8185536/webrev.00/index.html
>>> 81 lines changed: 19 ins; 0 del; 62 mod
>>
>> Hi all,
>>
>> could you please review this small patch which introduces 'vm.aot' property
>> into jtreg @requires context and replaces all '@key aot' added by 8185046[1]
>> w/ '@requiers vm.aot'?
>> Goetz(author of 8185046) is checking that it works for their configurations.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8185536
>> webrev:
>> http://cr.openjdk.java.net/~iignatyev//8185536/webrev.00/index.html
>> testing: hotspot/test/compiler/aot tests
>> - on linux-x64 : 56 tests selected/run
>> - on linux-x86 : 0 tests selected/run
>> - on windows-x64 (after remove tests from problemlist) : 56 tests
>> selected/run
>> - on windows-x86 (after remove tests from problemlist) : 0 tests
>> selected/run
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8185046
>>
>> Thanks,
>> -- Igor

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(S) : 8185536 : @key aot should be replaced w/ @requires vm.aot

Vladimir Kozlov
Okay.

Thanks
Vladimir

Sent from my iPhone

> On Aug 2, 2017, at 10:53 AM, Igor Ignatyev <[hidden email]> wrote:
>
> Vladimir, Goetz,
>
> thank you for your review. Although abbreviations should not be upper-cased in method names, I've renamed vmAot to vmAOT to be consistent w/ the rest of the class.
>
> -- Igor
>
>> On Aug 2, 2017, at 5:49 AM, Lindenmaier, Goetz <[hidden email]> wrote:
>>
>> Hi Igor,
>>
>> the change is looking good.
>>
>> A small thing, I would spell vmAot() as vmAOT(), all abbreviations
>> (except for Jvmci) are capitalized here.
>>
>> It passed the tests on all platforms that have been running so far.
>> (Some had an unrelated issue tonight).
>>
>> Best regards,
>> Goetz.
>>
>>> -----Original Message-----
>>> From: Igor Ignatyev [mailto:[hidden email]]
>>> Sent: Dienstag, 1. August 2017 17:51
>>> To: [hidden email] compiler <hotspot-compiler-
>>> [hidden email]>
>>> Cc: Lindenmaier, Goetz <[hidden email]>
>>> Subject: RFR(S) : 8185536 : @key aot should be replaced w/ @requires
>>> vm.aot
>>>
>>> http://cr.openjdk.java.net/~iignatyev//8185536/webrev.00/index.html
>>>> 81 lines changed: 19 ins; 0 del; 62 mod
>>>
>>> Hi all,
>>>
>>> could you please review this small patch which introduces 'vm.aot' property
>>> into jtreg @requires context and replaces all '@key aot' added by 8185046[1]
>>> w/ '@requiers vm.aot'?
>>> Goetz(author of 8185046) is checking that it works for their configurations.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8185536
>>> webrev:
>>> http://cr.openjdk.java.net/~iignatyev//8185536/webrev.00/index.html
>>> testing: hotspot/test/compiler/aot tests
>>> - on linux-x64 : 56 tests selected/run
>>> - on linux-x86 : 0 tests selected/run
>>> - on windows-x64 (after remove tests from problemlist) : 56 tests
>>> selected/run
>>> - on windows-x86 (after remove tests from problemlist) : 0 tests
>>> selected/run
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8185046
>>>
>>> Thanks,
>>> -- Igor
>

Loading...