RFR(S): 8186540: [TESTBUG] serviceability/dcmd/jvmti/LoadAgentDcmdTest.java failed to clean up files in agentvm mode

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(S): 8186540: [TESTBUG] serviceability/dcmd/jvmti/LoadAgentDcmdTest.java failed to clean up files in agentvm mode

Chris Plummer

Hello,

Please review the following:

https://bugs.openjdk.java.net/browse/JDK-8186540
http://cr.openjdk.java.net/~cjplummer/8186540/webrev.00/

The fix is to use "othervm" mode to avoid issues with the agent.jar file not being closed when jtreg does cleanup on exit.

thanks,

Chris

Reply | Threaded
Open this post in threaded view
|

Re: RFR(S): 8186540: [TESTBUG] serviceability/dcmd/jvmti/LoadAgentDcmdTest.java failed to clean up files in agentvm mode

David Holmes
Looks fine.

Thanks,
David

On 16/11/2017 2:16 PM, Chris Plummer wrote:

> Hello,
>
> Please review the following:
>
> https://bugs.openjdk.java.net/browse/JDK-8186540
> http://cr.openjdk.java.net/~cjplummer/8186540/webrev.00/
>
> The fix is to use "othervm" mode to avoid issues with the agent.jar file
> not being closed when jtreg does cleanup on exit.
>
> thanks,
>
> Chris
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR(S): 8186540: [TESTBUG] serviceability/dcmd/jvmti/LoadAgentDcmdTest.java failed to clean up files in agentvm mode

serguei.spitsyn@oracle.com
+1

Thanks,
Serguei


On 11/15/17 20:28, David Holmes wrote:

> Looks fine.
>
> Thanks,
> David
>
> On 16/11/2017 2:16 PM, Chris Plummer wrote:
>> Hello,
>>
>> Please review the following:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8186540
>> http://cr.openjdk.java.net/~cjplummer/8186540/webrev.00/
>>
>> The fix is to use "othervm" mode to avoid issues with the agent.jar
>> file not being closed when jtreg does cleanup on exit.
>>
>> thanks,
>>
>> Chris
>>

Reply | Threaded
Open this post in threaded view
|

Re: RFR(S): 8186540: [TESTBUG] serviceability/dcmd/jvmti/LoadAgentDcmdTest.java failed to clean up files in agentvm mode

Chris Plummer
Thanks David and Serguei!

Chris

On 11/15/17 10:18 PM, [hidden email] wrote:

> +1
>
> Thanks,
> Serguei
>
>
> On 11/15/17 20:28, David Holmes wrote:
>> Looks fine.
>>
>> Thanks,
>> David
>>
>> On 16/11/2017 2:16 PM, Chris Plummer wrote:
>>> Hello,
>>>
>>> Please review the following:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8186540
>>> http://cr.openjdk.java.net/~cjplummer/8186540/webrev.00/
>>>
>>> The fix is to use "othervm" mode to avoid issues with the agent.jar
>>> file not being closed when jtreg does cleanup on exit.
>>>
>>> thanks,
>>>
>>> Chris
>>>
>