RFR(S) 8189840: CheckCachedResolvedReferencesApp has no cached resolved references

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(S) 8189840: CheckCachedResolvedReferencesApp has no cached resolved references

Jiangli Zhou
Please review the fix for 8189840. CheckCachedResolvedReferencesApp currently is still a closed AppCDS test. The following webrev only contains the WhiteBox change with the new API (WhiteBox.openrchiveHeapObjectsMapped()) added. CheckCachedResolvedReferencesApp calls the new API to detect if the ‘open archive’ heap objects are mapped successfully in the current JVM execution. CheckCachedResolvedReferencesApp test change is not included in the webrev.

webrev: http://cr.openjdk.java.net/~jiangli/8189840/webrev.00/ <http://cr.openjdk.java.net/~jiangli/8189840/webrev.00/>
bug: https://bugs.openjdk.java.net/browse/JDK-8189840?filter=14921 <https://bugs.openjdk.java.net/browse/JDK-8189840?filter=14921>

Tested on linux-x64. Also running hs-tier1, hs-tier2 tests.

Thanks,
Jiangli

Reply | Threaded
Open this post in threaded view
|

Re: RFR(S) 8189840: CheckCachedResolvedReferencesApp has no cached resolved references

Ioi Lam
Hi Jiangli,

Just one nit - I think the method openArchiveHeapObjectsMapped should be
renamed to areOpenArchiveHeapObjectsMapped to be consistent with the
other methods.

     {CC"isShared",           CC"(Ljava/lang/Object;)Z",
(void*)&WB_IsShared },
     {CC"isSharedClass",      CC"(Ljava/lang/Class;)Z",
(void*)&WB_IsSharedClass },
     {CC"areSharedStringsIgnored",           CC"()Z",
(void*)&WB_AreSharedStringsIgnored },
     {CC"getResolvedReferences",
CC"(Ljava/lang/Class;)Ljava/lang/Object;",
(void*)&WB_GetResolvedReferences},
+   {CC"openArchiveHeapObjectsMapped",      CC"()Z",
(void*)&WB_OpenArchiveHeapObjectsMapped},

Thanks
- Ioi

On 11/3/17 4:46 PM, Jiangli Zhou wrote:

> Please review the fix for 8189840. CheckCachedResolvedReferencesApp currently is still a closed AppCDS test. The following webrev only contains the WhiteBox change with the new API (WhiteBox.openrchiveHeapObjectsMapped()) added. CheckCachedResolvedReferencesApp calls the new API to detect if the ‘open archive’ heap objects are mapped successfully in the current JVM execution. CheckCachedResolvedReferencesApp test change is not included in the webrev.
>
> webrev: http://cr.openjdk.java.net/~jiangli/8189840/webrev.00/ <http://cr.openjdk.java.net/~jiangli/8189840/webrev.00/>
> bug: https://bugs.openjdk.java.net/browse/JDK-8189840?filter=14921 <https://bugs.openjdk.java.net/browse/JDK-8189840?filter=14921>
>
> Tested on linux-x64. Also running hs-tier1, hs-tier2 tests.
>
> Thanks,
> Jiangli
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR(S) 8189840: CheckCachedResolvedReferencesApp has no cached resolved references

Jiangli Zhou
Hi Ioi,

Thanks for the suggestion. Will do.

Thanks,
Jiangli

> On Nov 6, 2017, at 7:47 PM, Ioi Lam <[hidden email]> wrote:
>
> Hi Jiangli,
>
> Just one nit - I think the method openArchiveHeapObjectsMapped should be renamed to areOpenArchiveHeapObjectsMapped to be consistent with the other methods.
>
>     {CC"isShared",           CC"(Ljava/lang/Object;)Z", (void*)&WB_IsShared },
>     {CC"isSharedClass",      CC"(Ljava/lang/Class;)Z", (void*)&WB_IsSharedClass },
>     {CC"areSharedStringsIgnored",           CC"()Z", (void*)&WB_AreSharedStringsIgnored },
>     {CC"getResolvedReferences", CC"(Ljava/lang/Class;)Ljava/lang/Object;", (void*)&WB_GetResolvedReferences},
> +   {CC"openArchiveHeapObjectsMapped",      CC"()Z", (void*)&WB_OpenArchiveHeapObjectsMapped},
>
> Thanks
> - Ioi
>
>> On 11/3/17 4:46 PM, Jiangli Zhou wrote:
>> Please review the fix for 8189840. CheckCachedResolvedReferencesApp currently is still a closed AppCDS test. The following webrev only contains the WhiteBox change with the new API (WhiteBox.openrchiveHeapObjectsMapped()) added. CheckCachedResolvedReferencesApp calls the new API to detect if the ‘open archive’ heap objects are mapped successfully in the current JVM execution. CheckCachedResolvedReferencesApp test change is not included in the webrev.
>>
>> webrev: http://cr.openjdk.java.net/~jiangli/8189840/webrev.00/ <http://cr.openjdk.java.net/~jiangli/8189840/webrev.00/>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8189840?filter=14921 <https://bugs.openjdk.java.net/browse/JDK-8189840?filter=14921>
>>
>> Tested on linux-x64. Also running hs-tier1, hs-tier2 tests.
>>
>> Thanks,
>> Jiangli
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR(S) 8189840: CheckCachedResolvedReferencesApp has no cached resolved references

Calvin Cheung
Hi Jiangli,

I agree with Ioi's suggestion on the method name. Looks good otherwise.

thanks,
Calvin

On 11/6/17, 10:24 PM, Jiangli Zhou wrote:

> Hi Ioi,
>
> Thanks for the suggestion. Will do.
>
> Thanks,
> Jiangli
>
>> On Nov 6, 2017, at 7:47 PM, Ioi Lam<[hidden email]>  wrote:
>>
>> Hi Jiangli,
>>
>> Just one nit - I think the method openArchiveHeapObjectsMapped should be renamed to areOpenArchiveHeapObjectsMapped to be consistent with the other methods.
>>
>>      {CC"isShared",           CC"(Ljava/lang/Object;)Z", (void*)&WB_IsShared },
>>      {CC"isSharedClass",      CC"(Ljava/lang/Class;)Z", (void*)&WB_IsSharedClass },
>>      {CC"areSharedStringsIgnored",           CC"()Z", (void*)&WB_AreSharedStringsIgnored },
>>      {CC"getResolvedReferences", CC"(Ljava/lang/Class;)Ljava/lang/Object;", (void*)&WB_GetResolvedReferences},
>> +   {CC"openArchiveHeapObjectsMapped",      CC"()Z", (void*)&WB_OpenArchiveHeapObjectsMapped},
>>
>> Thanks
>> - Ioi
>>
>>> On 11/3/17 4:46 PM, Jiangli Zhou wrote:
>>> Please review the fix for 8189840. CheckCachedResolvedReferencesApp currently is still a closed AppCDS test. The following webrev only contains the WhiteBox change with the new API (WhiteBox.openrchiveHeapObjectsMapped()) added. CheckCachedResolvedReferencesApp calls the new API to detect if the ‘open archive’ heap objects are mapped successfully in the current JVM execution. CheckCachedResolvedReferencesApp test change is not included in the webrev.
>>>
>>> webrev: http://cr.openjdk.java.net/~jiangli/8189840/webrev.00/<http://cr.openjdk.java.net/~jiangli/8189840/webrev.00/>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8189840?filter=14921<https://bugs.openjdk.java.net/browse/JDK-8189840?filter=14921>
>>>
>>> Tested on linux-x64. Also running hs-tier1, hs-tier2 tests.
>>>
>>> Thanks,
>>> Jiangli
Reply | Threaded
Open this post in threaded view
|

Re: RFR(S) 8189840: CheckCachedResolvedReferencesApp has no cached resolved references

Jiangli Zhou
Thanks for the review, Calvin!

Jiangli

> On Nov 7, 2017, at 9:24 AM, Calvin Cheung <[hidden email]> wrote:
>
> Hi Jiangli,
>
> I agree with Ioi's suggestion on the method name. Looks good otherwise.
>
> thanks,
> Calvin
>
> On 11/6/17, 10:24 PM, Jiangli Zhou wrote:
>> Hi Ioi,
>>
>> Thanks for the suggestion. Will do.
>>
>> Thanks,
>> Jiangli
>>
>>> On Nov 6, 2017, at 7:47 PM, Ioi Lam<[hidden email]>  wrote:
>>>
>>> Hi Jiangli,
>>>
>>> Just one nit - I think the method openArchiveHeapObjectsMapped should be renamed to areOpenArchiveHeapObjectsMapped to be consistent with the other methods.
>>>
>>>     {CC"isShared",           CC"(Ljava/lang/Object;)Z", (void*)&WB_IsShared },
>>>     {CC"isSharedClass",      CC"(Ljava/lang/Class;)Z", (void*)&WB_IsSharedClass },
>>>     {CC"areSharedStringsIgnored",           CC"()Z", (void*)&WB_AreSharedStringsIgnored },
>>>     {CC"getResolvedReferences", CC"(Ljava/lang/Class;)Ljava/lang/Object;", (void*)&WB_GetResolvedReferences},
>>> +   {CC"openArchiveHeapObjectsMapped",      CC"()Z", (void*)&WB_OpenArchiveHeapObjectsMapped},
>>>
>>> Thanks
>>> - Ioi
>>>
>>>> On 11/3/17 4:46 PM, Jiangli Zhou wrote:
>>>> Please review the fix for 8189840. CheckCachedResolvedReferencesApp currently is still a closed AppCDS test. The following webrev only contains the WhiteBox change with the new API (WhiteBox.openrchiveHeapObjectsMapped()) added. CheckCachedResolvedReferencesApp calls the new API to detect if the ‘open archive’ heap objects are mapped successfully in the current JVM execution. CheckCachedResolvedReferencesApp test change is not included in the webrev.
>>>>
>>>> webrev: http://cr.openjdk.java.net/~jiangli/8189840/webrev.00/<http://cr.openjdk.java.net/~jiangli/8189840/webrev.00/>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8189840?filter=14921<https://bugs.openjdk.java.net/browse/JDK-8189840?filter=14921>
>>>>
>>>> Tested on linux-x64. Also running hs-tier1, hs-tier2 tests.
>>>>
>>>> Thanks,
>>>> Jiangli