RFR(S) 8227440: Implement fix to JDK-8224642 on all platforms

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(S) 8227440: Implement fix to JDK-8224642 on all platforms

Schmelter, Ralf
Could you please review this change, which makes the close() method of InpuStreams returned from VirtualMachineImpl methods safe to be called more than once.

webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8227440/webrev.0/
bugreport: https://bugs.openjdk.java.net/browse/JDK-8227440

Best regards,
Ralf
Reply | Threaded
Open this post in threaded view
|

Re: RFR(S) 8227440: Implement fix to JDK-8224642 on all platforms

serguei.spitsyn@oracle.com
Hi Ralf,

This fix looks good to me.

Thanks,
Serguei


On 7/15/19 03:15, Schmelter, Ralf wrote:
> Could you please review this change, which makes the close() method of InpuStreams returned from VirtualMachineImpl methods safe to be called more than once.
>
> webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8227440/webrev.0/
> bugreport: https://bugs.openjdk.java.net/browse/JDK-8227440
>
> Best regards,
> Ralf

Reply | Threaded
Open this post in threaded view
|

RE: RFR(S) 8227440: Implement fix to JDK-8224642 on all platforms

Langer, Christoph
Hi Ralf,

looks good. Thanks for doing this.

In the AIX file you should update the SAP copyright header prior to pushing.

Best regards
Christoph


> -----Original Message-----
> From: serviceability-dev <[hidden email]> On
> Behalf Of [hidden email]
> Sent: Montag, 15. Juli 2019 12:33
> To: Schmelter, Ralf <[hidden email]>; OpenJDK Serviceability
> <[hidden email]>
> Subject: Re: RFR(S) 8227440: Implement fix to JDK-8224642 on all platforms
>
> Hi Ralf,
>
> This fix looks good to me.
>
> Thanks,
> Serguei
>
>
> On 7/15/19 03:15, Schmelter, Ralf wrote:
> > Could you please review this change, which makes the close() method of
> InpuStreams returned from VirtualMachineImpl methods safe to be called
> more than once.
> >
> > webrev:
> http://cr.openjdk.java.net/~rschmelter/webrevs/8227440/webrev.0/
> > bugreport: https://bugs.openjdk.java.net/browse/JDK-8227440
> >
> > Best regards,
> > Ralf

Reply | Threaded
Open this post in threaded view
|

RE: RFR(S) 8227440: Implement fix to JDK-8224642 on all platforms

Schmelter, Ralf
Thanks for the reviews. I will submit it with the changed copyright header.

Best regards,
Ralf