RFR [S] JDK-8179624 [REDO] Avoid repeated calls to JavaThread::last_frame in InterpreterRuntime

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR [S] JDK-8179624 [REDO] Avoid repeated calls to JavaThread::last_frame in InterpreterRuntime

Ioi Lam
Hi,

Please review the following change. It's a redo of a previous botched
attempt (JDK-8179305) that had a typo which caused JIT-related crashes.

Thanks to Dean for spotting the typo.

+ Bug
https://bugs.openjdk.java.net/browse/JDK-8179624


+ The full changeset:
http://cr.openjdk.java.net/~iklam/jdk10/8179624-redo-8179305-avoid-last-frame.v01.full/


+ The delta from the botched attempt
   (fixing the typo with monitor_begin/monitor_end):
http://cr.openjdk.java.net/~iklam/jdk10/8179624-redo-8179305-avoid-last-frame.v01.redo_delta/


+ Testing:
hotspot tier1~5 tests.


Thanks
- Ioi
Reply | Threaded
Open this post in threaded view
|

Re: RFR [S] JDK-8179624 [REDO] Avoid repeated calls to JavaThread::last_frame in InterpreterRuntime

dean.long
Looks good.

dl


On 10/26/17 2:53 PM, Ioi Lam wrote:

> Hi,
>
> Please review the following change. It's a redo of a previous botched
> attempt (JDK-8179305) that had a typo which caused JIT-related crashes.
>
> Thanks to Dean for spotting the typo.
>
> + Bug
> https://bugs.openjdk.java.net/browse/JDK-8179624
>
>
> + The full changeset:
> http://cr.openjdk.java.net/~iklam/jdk10/8179624-redo-8179305-avoid-last-frame.v01.full/ 
>
>
>
> + The delta from the botched attempt
>   (fixing the typo with monitor_begin/monitor_end):
> http://cr.openjdk.java.net/~iklam/jdk10/8179624-redo-8179305-avoid-last-frame.v01.redo_delta/ 
>
>
>
> + Testing:
> hotspot tier1~5 tests.
>
>
> Thanks
> - Ioi

Reply | Threaded
Open this post in threaded view
|

Re: RFR [S] JDK-8179624 [REDO] Avoid repeated calls to JavaThread::last_frame in InterpreterRuntime

Ioi Lam
Thanks Dean!

- Ioi


On 10/26/17 4:41 PM, [hidden email] wrote:

> Looks good.
>
> dl
>
>
> On 10/26/17 2:53 PM, Ioi Lam wrote:
>> Hi,
>>
>> Please review the following change. It's a redo of a previous botched
>> attempt (JDK-8179305) that had a typo which caused JIT-related crashes.
>>
>> Thanks to Dean for spotting the typo.
>>
>> + Bug
>> https://bugs.openjdk.java.net/browse/JDK-8179624
>>
>>
>> + The full changeset:
>> http://cr.openjdk.java.net/~iklam/jdk10/8179624-redo-8179305-avoid-last-frame.v01.full/ 
>>
>>
>>
>> + The delta from the botched attempt
>>   (fixing the typo with monitor_begin/monitor_end):
>> http://cr.openjdk.java.net/~iklam/jdk10/8179624-redo-8179305-avoid-last-frame.v01.redo_delta/ 
>>
>>
>>
>> + Testing:
>> hotspot tier1~5 tests.
>>
>>
>> Thanks
>> - Ioi
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR [S] JDK-8179624 [REDO] Avoid repeated calls to JavaThread::last_frame in InterpreterRuntime

coleen.phillimore
In reply to this post by Ioi Lam
This looks good.
Thanks,
Coleen

On 10/26/17 5:53 PM, Ioi Lam wrote:

> Hi,
>
> Please review the following change. It's a redo of a previous botched
> attempt (JDK-8179305) that had a typo which caused JIT-related crashes.
>
> Thanks to Dean for spotting the typo.
>
> + Bug
> https://bugs.openjdk.java.net/browse/JDK-8179624
>
>
> + The full changeset:
> http://cr.openjdk.java.net/~iklam/jdk10/8179624-redo-8179305-avoid-last-frame.v01.full/ 
>
>
>
> + The delta from the botched attempt
>   (fixing the typo with monitor_begin/monitor_end):
> http://cr.openjdk.java.net/~iklam/jdk10/8179624-redo-8179305-avoid-last-frame.v01.redo_delta/ 
>
>
>
> + Testing:
> hotspot tier1~5 tests.
>
>
> Thanks
> - Ioi