Quantcast

RFR(XS) [10]: 8174199: ci replay doesn't reallocate static final field of recorded klass

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR(XS) [10]: 8174199: ci replay doesn't reallocate static final field of recorded klass

Roland Westrelin-3

http://cr.openjdk.java.net/~roland/8174199/webrev.00/

On failure, ci replay records the actual type of a static final field
(when it's an instance) but on replay, it doesn't allocate a static
final field of that type but of the signature type instead.

Roland.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XS) [10]: 8174199: ci replay doesn't reallocate static final field of recorded klass

Vladimir Kozlov
Looks good.

Thank you for finding and fixing this. It looks like it was typo -
field_signature was used instead of string_value.

Vladimir

On 2/8/17 7:58 AM, Roland Westrelin wrote:
>
> http://cr.openjdk.java.net/~roland/8174199/webrev.00/
>
> On failure, ci replay records the actual type of a static final field
> (when it's an instance) but on replay, it doesn't allocate a static
> final field of that type but of the signature type instead.
>
> Roland.
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XS) [10]: 8174199: ci replay doesn't reallocate static final field of recorded klass

Roland Westrelin-3

Thanks for reviewing this, Vladimir. Anyone to sponsor it?

Roland.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XS) [10]: 8174199: ci replay doesn't reallocate static final field of recorded klass

Tobias Hartmann-2
Hi Roland,

On 09.02.2017 09:58, Roland Westrelin wrote:
>
> Thanks for reviewing this, Vladimir. Anyone to sponsor it?

I can sponsor it, please send me the changeset.

Best regards,
Tobias
Loading...