RFR (XS) 8068317: No_Safepoint_Verifier is not necessary in Rewriter::scan_method

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR (XS) 8068317: No_Safepoint_Verifier is not necessary in Rewriter::scan_method

coleen.phillimore
Summary: remove NSV, Method* can't move or be redefined while being
rewritten

One down, lots more to look at.

open webrev at http://cr.openjdk.java.net/~coleenp/8068317.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8068317

Tested with tier1 testing on linux/x64.  Will run JPRT.

Thanks,
Coleen
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (XS) 8068317: No_Safepoint_Verifier is not necessary in Rewriter::scan_method

Aleksey Shipilev-4
On 08/09/2017 07:39 PM, [hidden email] wrote:
> open webrev at http://cr.openjdk.java.net/~coleenp/8068317.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8068317

Ok, so code_base mentioned in comment is still there, but allocated in Metaspace. Looks good.

Thanks,
-Aleksey

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (XS) 8068317: No_Safepoint_Verifier is not necessary in Rewriter::scan_method

Jiangli Zhou
In reply to this post by coleen.phillimore
Looks good.

Jiangli

> On Aug 9, 2017, at 10:39 AM, [hidden email] wrote:
>
> Summary: remove NSV, Method* can't move or be redefined while being rewritten
>
> One down, lots more to look at.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8068317.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8068317
>
> Tested with tier1 testing on linux/x64.  Will run JPRT.
>
> Thanks,
> Coleen

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (XS) 8068317: No_Safepoint_Verifier is not necessary in Rewriter::scan_method

coleen.phillimore
In reply to this post by Aleksey Shipilev-4


On 8/9/17 1:45 PM, Aleksey Shipilev wrote:
> On 08/09/2017 07:39 PM, [hidden email] wrote:
>> open webrev at http://cr.openjdk.java.net/~coleenp/8068317.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8068317
> Ok, so code_base mentioned in comment is still there, but allocated in Metaspace. Looks good.

Yes.  Metaspace objects don't move (except during CDS dumping).

Thanks for the quick review.
Coleen

>
> Thanks,
> -Aleksey
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (XS) 8068317: No_Safepoint_Verifier is not necessary in Rewriter::scan_method

coleen.phillimore
In reply to this post by Jiangli Zhou
Thanks, Jiangli!
Coleen

On 8/9/17 1:46 PM, Jiangli Zhou wrote:

> Looks good.
>
> Jiangli
>
>> On Aug 9, 2017, at 10:39 AM, [hidden email] wrote:
>>
>> Summary: remove NSV, Method* can't move or be redefined while being rewritten
>>
>> One down, lots more to look at.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8068317.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8068317
>>
>> Tested with tier1 testing on linux/x64.  Will run JPRT.
>>
>> Thanks,
>> Coleen

Loading...