RFR(XS) : 8172457: JarDirTest.java fails after recent change

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(XS) : 8172457: JarDirTest.java fails after recent change

Igor Ignatyev
Hi all,

Could you please review this small fix?

The test passes an asterisk symbol to a new spawn jvm process via ProcessTools. On windows, an asterisk is expand to files in a directory, but the test expects that the spawn jvm gets the symbol as is.
The problem is fixed by escaping asterisk symbol on windows.

JBS: https://bugs.openjdk.java.net/browse/JDK-8172457
Webrev: http://cr.openjdk.java.net/~iignatyev/8172457/webrev.01
Testing: affected tests on windows and non windows platform

Thanks,
— Igor
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS) : 8172457: JarDirTest.java fails after recent change

Igor Veresov
Looks good.

igor

> On Mar 3, 2017, at 9:37 PM, Igor Ignatyev <[hidden email]> wrote:
>
> Hi all,
>
> Could you please review this small fix?
>
> The test passes an asterisk symbol to a new spawn jvm process via ProcessTools. On windows, an asterisk is expand to files in a directory, but the test expects that the spawn jvm gets the symbol as is.
> The problem is fixed by escaping asterisk symbol on windows.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8172457
> Webrev: http://cr.openjdk.java.net/~iignatyev/8172457/webrev.01
> Testing: affected tests on windows and non windows platform
>
> Thanks,
> — Igor