Quantcast

RFR(XS) : 8178913 : CTW library does not close all opened resources

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR(XS) : 8178913 : CTW library does not close all opened resources

Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8178913/webrev.00/index.html
> 14 lines changed: 6 ins; 3 del; 5 mod;

Hi all,

could you please review this small fix for CTW library? there were several instance of resources leak in the library, this changeset fixes them by using try-w/-resource where applicable, and explicit close() call were not.

webrev: http://cr.openjdk.java.net/~iignatyev//8178913/webrev.00/index.html
JBS: https://bugs.openjdk.java.net/browse/JDK-8178913
testing: hotspot/test/testlibrary_tests/ctw

Thanks,
-- Igor
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XS) : 8178913 : CTW library does not close all opened resources

Vladimir Kozlov
Good.

Vladimir

On 4/18/17 11:33 AM, Igor Ignatyev wrote:

> http://cr.openjdk.java.net/~iignatyev//8178913/webrev.00/index.html
>> 14 lines changed: 6 ins; 3 del; 5 mod;
>
> Hi all,
>
> could you please review this small fix for CTW library? there were several instance of resources leak in the library, this changeset fixes them by using try-w/-resource where applicable, and explicit close() call were not.
>
> webrev: http://cr.openjdk.java.net/~iignatyev//8178913/webrev.00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8178913
> testing: hotspot/test/testlibrary_tests/ctw
>
> Thanks,
> -- Igor
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XS) : 8178913 : CTW library does not close all opened resources

Igor Ignatyev
Thanks for your review.
-- Igor

> On Apr 18, 2017, at 4:37 PM, Vladimir Kozlov <[hidden email]> wrote:
>
> Good.
>
> Vladimir
>
> On 4/18/17 11:33 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8178913/webrev.00/index.html
>>> 14 lines changed: 6 ins; 3 del; 5 mod;
>>
>> Hi all,
>>
>> could you please review this small fix for CTW library? there were several instance of resources leak in the library, this changeset fixes them by using try-w/-resource where applicable, and explicit close() call were not.
>>
>> webrev: http://cr.openjdk.java.net/~iignatyev//8178913/webrev.00/index.html
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8178913
>> testing: hotspot/test/testlibrary_tests/ctw
>>
>> Thanks,
>> -- Igor
>>

Loading...