Quantcast

RFR(XS) 8180324: failed JVMCI junit test NativeCallTest.java

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR(XS) 8180324: failed JVMCI junit test NativeCallTest.java

Ekaterina Pavlova
Hi,

Please review this small change that fixes compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java test.
The test missed 'native' declaration and as result failed with UnsatisfiedLinkError when '-nativepath' flag was not passed to
jtreg. Now the test will fail with "Use -nativepath to specify the location of native code" error message which is more
understandable.

Fixed also runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java and
serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java tests which had the same issue.

   bug: https://bugs.openjdk.java.net/browse/JDK-8180324
webrev: http://cr.openjdk.java.net/~epavlova//8180324/webrev.00/

Tested by running jprt plus manual testing of fixed tests.

thanks,
-katya

p.s.
 Igor Ignatyev volunteered to sponsor this change.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XS) 8180324: failed JVMCI junit test NativeCallTest.java

Igor Ignatyev
Hi Katya,

the fix looks good to me.

-- Igor

> On May 17, 2017, at 1:50 PM, Ekaterina Pavlova <[hidden email]> wrote:
>
> Hi,
>
> Please review this small change that fixes compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java test.
> The test missed 'native' declaration and as result failed with UnsatisfiedLinkError when '-nativepath' flag was not passed to
> jtreg. Now the test will fail with "Use -nativepath to specify the location of native code" error message which is more
> understandable.
>
> Fixed also runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java and
> serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java tests which had the same issue.
>
>   bug: https://bugs.openjdk.java.net/browse/JDK-8180324
> webrev: http://cr.openjdk.java.net/~epavlova//8180324/webrev.00/
>
> Tested by running jprt plus manual testing of fixed tests.
>
> thanks,
> -katya
>
> p.s.
> Igor Ignatyev volunteered to sponsor this change.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XS) 8180324: failed JVMCI junit test NativeCallTest.java

Mikhailo Seledtsov
Looks good,

Misha


On 05/17/2017 02:07 PM, Igor Ignatyev wrote:

> Hi Katya,
>
> the fix looks good to me.
>
> -- Igor
>> On May 17, 2017, at 1:50 PM, Ekaterina Pavlova <[hidden email]> wrote:
>>
>> Hi,
>>
>> Please review this small change that fixes compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java test.
>> The test missed 'native' declaration and as result failed with UnsatisfiedLinkError when '-nativepath' flag was not passed to
>> jtreg. Now the test will fail with "Use -nativepath to specify the location of native code" error message which is more
>> understandable.
>>
>> Fixed also runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java and
>> serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java tests which had the same issue.
>>
>>    bug: https://bugs.openjdk.java.net/browse/JDK-8180324
>> webrev: http://cr.openjdk.java.net/~epavlova//8180324/webrev.00/
>>
>> Tested by running jprt plus manual testing of fixed tests.
>>
>> thanks,
>> -katya
>>
>> p.s.
>> Igor Ignatyev volunteered to sponsor this change.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XS) 8180324: failed JVMCI junit test NativeCallTest.java

Vladimir Kozlov
In reply to this post by Ekaterina Pavlova
Looks good. Thank you for fixing it.

Vladimir

On 5/17/17 1:50 PM, Ekaterina Pavlova wrote:

> Hi,
>
> Please review this small change that fixes compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java test.
> The test missed 'native' declaration and as result failed with UnsatisfiedLinkError when '-nativepath' flag was not passed to
> jtreg. Now the test will fail with "Use -nativepath to specify the location of native code" error message which is more
> understandable.
>
> Fixed also runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java and
> serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java tests which had the same issue.
>
>    bug: https://bugs.openjdk.java.net/browse/JDK-8180324
> webrev: http://cr.openjdk.java.net/~epavlova//8180324/webrev.00/
>
> Tested by running jprt plus manual testing of fixed tests.
>
> thanks,
> -katya
>
> p.s.
>  Igor Ignatyev volunteered to sponsor this change.
>
Loading...