RFR(XS): 8187347: Do not abort CDS archive creation when some classes are unverifiable

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(XS): 8187347: Do not abort CDS archive creation when some classes are unverifiable

Calvin Cheung
This change is for deprecating the IgnoreUnverifiableClassesDuringDump
vm option in JDK10 and set its default value to true.

JBS:
     https://bugs.openjdk.java.net/browse/JDK-8187347

webrev:
     http://cr.openjdk.java.net/~ccheung/8187347/webrev.00/

Approved CSR:
     https://bugs.openjdk.java.net/browse/JDK-8187348

Testing:
     hs-tier1, hs-tier2 on linux-x64, macosx, sparcv9, windows-x64.

thanks,
Calvin
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS): 8187347: Do not abort CDS archive creation when some classes are unverifiable

David Holmes
Looks good.

Thanks,
David

On 3/11/2017 9:57 AM, Calvin Cheung wrote:

> This change is for deprecating the IgnoreUnverifiableClassesDuringDump
> vm option in JDK10 and set its default value to true.
>
> JBS:
>      https://bugs.openjdk.java.net/browse/JDK-8187347
>
> webrev:
>      http://cr.openjdk.java.net/~ccheung/8187347/webrev.00/
>
> Approved CSR:
>      https://bugs.openjdk.java.net/browse/JDK-8187348
>
> Testing:
>      hs-tier1, hs-tier2 on linux-x64, macosx, sparcv9, windows-x64.
>
> thanks,
> Calvin
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS): 8187347: Do not abort CDS archive creation when some classes are unverifiable

Jiangli Zhou
+1.

Thanks,
Jiangli

> On Nov 2, 2017, at 5:13 PM, David Holmes <[hidden email]> wrote:
>
> Looks good.
>
> Thanks,
> David
>
> On 3/11/2017 9:57 AM, Calvin Cheung wrote:
>> This change is for deprecating the IgnoreUnverifiableClassesDuringDump vm option in JDK10 and set its default value to true.
>> JBS:
>>     https://bugs.openjdk.java.net/browse/JDK-8187347
>> webrev:
>>     http://cr.openjdk.java.net/~ccheung/8187347/webrev.00/
>> Approved CSR:
>>     https://bugs.openjdk.java.net/browse/JDK-8187348
>> Testing:
>>     hs-tier1, hs-tier2 on linux-x64, macosx, sparcv9, windows-x64.
>> thanks,
>> Calvin

Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS): 8187347: Do not abort CDS archive creation when some classes are unverifiable

Calvin Cheung
David, Jiangli,

Thanks for your quick review.

Calvin

On 11/2/17, 5:20 PM, Jiangli Zhou wrote:

> +1.
>
> Thanks,
> Jiangli
>
>> On Nov 2, 2017, at 5:13 PM, David Holmes<[hidden email]>  wrote:
>>
>> Looks good.
>>
>> Thanks,
>> David
>>
>> On 3/11/2017 9:57 AM, Calvin Cheung wrote:
>>> This change is for deprecating the IgnoreUnverifiableClassesDuringDump vm option in JDK10 and set its default value to true.
>>> JBS:
>>>      https://bugs.openjdk.java.net/browse/JDK-8187347
>>> webrev:
>>>      http://cr.openjdk.java.net/~ccheung/8187347/webrev.00/
>>> Approved CSR:
>>>      https://bugs.openjdk.java.net/browse/JDK-8187348
>>> Testing:
>>>      hs-tier1, hs-tier2 on linux-x64, macosx, sparcv9, windows-x64.
>>> thanks,
>>> Calvin