RFR(XS): 8188855: Fix VS10 build after "8187658: Bigger buffer for GetAdaptersAddresses"

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(XS): 8188855: Fix VS10 build after "8187658: Bigger buffer for GetAdaptersAddresses"

Lindenmaier, Goetz
Hi,

could I please get reviews for this tiny change?
http://cr.openjdk.java.net/~goetz/wr17/8188855-winBuild/webrev/

Best regards,
  Goetz.
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS): 8188855: Fix VS10 build after "8187658: Bigger buffer for GetAdaptersAddresses"

Vyom Tewari
Hi Goetz,

Change looks OK to me, although i am not the official reviewer.

Thanks,

Vyom


On Friday 06 October 2017 12:18 PM, Lindenmaier, Goetz wrote:
> Hi,
>
> could I please get reviews for this tiny change?
> http://cr.openjdk.java.net/~goetz/wr17/8188855-winBuild/webrev/
>
> Best regards,
>    Goetz.

Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS): 8188855: Fix VS10 build after "8187658: Bigger buffer for GetAdaptersAddresses"

Volker Simonis
In reply to this post by Lindenmaier, Goetz
Looks good!

Thanks,
Volker


On Fri, Oct 6, 2017 at 8:48 AM, Lindenmaier, Goetz
<[hidden email]> wrote:
> Hi,
>
> could I please get reviews for this tiny change?
> http://cr.openjdk.java.net/~goetz/wr17/8188855-winBuild/webrev/
>
> Best regards,
>   Goetz.
Reply | Threaded
Open this post in threaded view
|

RE: RFR(XS): 8188855: Fix VS10 build after "8187658: Bigger buffer for GetAdaptersAddresses"

Lindenmaier, Goetz
Thanks, volker!

Best regards,
  Goetz

> -----Original Message-----
> From: Volker Simonis [mailto:[hidden email]]
> Sent: Freitag, 6. Oktober 2017 10:31
> To: Lindenmaier, Goetz <[hidden email]>
> Cc: [hidden email]
> Subject: Re: RFR(XS): 8188855: Fix VS10 build after "8187658: Bigger buffer for
> GetAdaptersAddresses"
>
> Looks good!
>
> Thanks,
> Volker
>
>
> On Fri, Oct 6, 2017 at 8:48 AM, Lindenmaier, Goetz
> <[hidden email]> wrote:
> > Hi,
> >
> > could I please get reviews for this tiny change?
> > http://cr.openjdk.java.net/~goetz/wr17/8188855-winBuild/webrev/
> >
> > Best regards,
> >   Goetz.
Reply | Threaded
Open this post in threaded view
|

RE: RFR(XS): 8188855: Fix VS10 build after "8187658: Bigger buffer for GetAdaptersAddresses"

Lindenmaier, Goetz
In reply to this post by Vyom Tewari
Thanks, Vyom!

Best regards,
  Goetz.

> -----Original Message-----
> From: net-dev [mailto:[hidden email]] On Behalf Of
> vyom tewari
> Sent: Freitag, 6. Oktober 2017 10:13
> To: [hidden email]
> Subject: Re: RFR(XS): 8188855: Fix VS10 build after "8187658: Bigger buffer for
> GetAdaptersAddresses"
>
> Hi Goetz,
>
> Change looks OK to me, although i am not the official reviewer.
>
> Thanks,
>
> Vyom
>
>
> On Friday 06 October 2017 12:18 PM, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > could I please get reviews for this tiny change?
> > http://cr.openjdk.java.net/~goetz/wr17/8188855-winBuild/webrev/
> >
> > Best regards,
> >    Goetz.