RFR(XS): 8192840: serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java failing on Windows

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(XS): 8192840: serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java failing on Windows

Chris Plummer
Hello,

Please review the changes below. I'll push once I get two reviews since
this is an integration block and would be best if it makes it into
today's nightly build.

https://bugs.openjdk.java.net/browse/JDK-8192840
diff --git
a/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
b/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
---
a/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
+++
b/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
@@ -37,7 +37,8 @@
              OutputAnalyzer output = null;

              output = executor.execute("JVMTI.agent_load " + libpath);
-            output.shouldContain("Agent_OnAttach is not available");
+            output.shouldContain("Agent_OnAttach");
+            output.shouldContain("is not available");
          } catch (Exception e) {
              throw new RuntimeException(e);
          }


I ran the test on Windows-x64, Solaris-sparc, macosx-x64, and and
linux-x64 (both product and fastdebug for all 4 platforms).

thanks,

Chris
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS): 8192840: serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java failing on Windows

Daniel D. Daugherty
On 11/30/17 4:50 PM, Chris Plummer wrote:
> Hello,
>
> Please review the changes below. I'll push once I get two reviews
> since this is an integration block and would be best if it makes it
> into today's nightly build.

test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
     No comments.

Thumbs up.

Dan

>
> https://bugs.openjdk.java.net/browse/JDK-8192840
> diff --git
> a/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
> b/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
>
> ---
> a/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
> +++
> b/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
> @@ -37,7 +37,8 @@
>              OutputAnalyzer output = null;
>
>              output = executor.execute("JVMTI.agent_load " + libpath);
> -            output.shouldContain("Agent_OnAttach is not available");
> +            output.shouldContain("Agent_OnAttach");
> +            output.shouldContain("is not available");
>          } catch (Exception e) {
>              throw new RuntimeException(e);
>          }
>
>
> I ran the test on Windows-x64, Solaris-sparc, macosx-x64, and and
> linux-x64 (both product and fastdebug for all 4 platforms).
>
> thanks,
>
> Chris

Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS): 8192840: serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java failing on Windows

David Holmes
In reply to this post by Chris Plummer
Looks good Chris!

Thanks,
David

PS. Sorry for delay but have been OOTO this morning

On 1/12/2017 7:50 AM, Chris Plummer wrote:

> Hello,
>
> Please review the changes below. I'll push once I get two reviews since
> this is an integration block and would be best if it makes it into
> today's nightly build.
>
> https://bugs.openjdk.java.net/browse/JDK-8192840
> diff --git
> a/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
> b/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
>
> ---
> a/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
>
> +++
> b/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
>
> @@ -37,7 +37,8 @@
>               OutputAnalyzer output = null;
>
>               output = executor.execute("JVMTI.agent_load " + libpath);
> -            output.shouldContain("Agent_OnAttach is not available");
> +            output.shouldContain("Agent_OnAttach");
> +            output.shouldContain("is not available");
>           } catch (Exception e) {
>               throw new RuntimeException(e);
>           }
>
>
> I ran the test on Windows-x64, Solaris-sparc, macosx-x64, and and
> linux-x64 (both product and fastdebug for all 4 platforms).
>
> thanks,
>
> Chris
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS): 8192840: serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java failing on Windows

serguei.spitsyn@oracle.com
In reply to this post by Chris Plummer
Hi Chris,

It looks good.

Thanks,
Serguei

On 11/30/17 13:50, Chris Plummer wrote:

> Hello,
>
> Please review the changes below. I'll push once I get two reviews
> since this is an integration block and would be best if it makes it
> into today's nightly build.
>
> https://bugs.openjdk.java.net/browse/JDK-8192840
> diff --git
> a/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
> b/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
>
> ---
> a/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
> +++
> b/test/hotspot/jtreg/serviceability/dcmd/jvmti/AttachFailed/AttachNoEntry.java
> @@ -37,7 +37,8 @@
>              OutputAnalyzer output = null;
>
>              output = executor.execute("JVMTI.agent_load " + libpath);
> -            output.shouldContain("Agent_OnAttach is not available");
> +            output.shouldContain("Agent_OnAttach");
> +            output.shouldContain("is not available");
>          } catch (Exception e) {
>              throw new RuntimeException(e);
>          }
>
>
> I ran the test on Windows-x64, Solaris-sparc, macosx-x64, and and
> linux-x64 (both product and fastdebug for all 4 platforms).
>
> thanks,
>
> Chris