RFR(XS) 8192870: [Testbug] runtime/handshake/HandshakeTransitionTest throws NPE

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(XS) 8192870: [Testbug] runtime/handshake/HandshakeTransitionTest throws NPE

dean.long
https://bugs.openjdk.java.net/browse/JDK-8192870
http://cr.openjdk.java.net/~dlong/8192870/webrev/

When we query WhiteBox.getBooleanVMFlag("UseJVMCICompiler"), we need to
check for null, in case JVMCI is not included in the build.

dl
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS) 8192870: [Testbug] runtime/handshake/HandshakeTransitionTest throws NPE

David Holmes
Hi Dean,

On 5/12/2017 6:48 AM, [hidden email] wrote:
> https://bugs.openjdk.java.net/browse/JDK-8192870
> http://cr.openjdk.java.net/~dlong/8192870/webrev/
>
> When we query WhiteBox.getBooleanVMFlag("UseJVMCICompiler"), we need to
> check for null, in case JVMCI is not included in the build.

Looks good.

Thanks,
David

> dl
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS) 8192870: [Testbug] runtime/handshake/HandshakeTransitionTest throws NPE

dean.long
Thanks David.

dl


On 12/4/17 2:07 PM, David Holmes wrote:

> Hi Dean,
>
> On 5/12/2017 6:48 AM, [hidden email] wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8192870
>> http://cr.openjdk.java.net/~dlong/8192870/webrev/
>>
>> When we query WhiteBox.getBooleanVMFlag("UseJVMCICompiler"), we need
>> to check for null, in case JVMCI is not included in the build.
>
> Looks good.
>
> Thanks,
> David
>
>> dl

Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS) 8192870: [Testbug] runtime/handshake/HandshakeTransitionTest throws NPE

Robbin Ehn
In reply to this post by dean.long
On 12/04/2017 09:48 PM, [hidden email] wrote:
> https://bugs.openjdk.java.net/browse/JDK-8192870
> http://cr.openjdk.java.net/~dlong/8192870/webrev/

Looks good and thanks for fixing!

/Robbin

>
> When we query WhiteBox.getBooleanVMFlag("UseJVMCICompiler"), we need to check
> for null, in case JVMCI is not included in the build.
>
> dl
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS) 8192870: [Testbug] runtime/handshake/HandshakeTransitionTest throws NPE

dean.long
Thanks Robbin!

dl


On 12/5/17 1:59 AM, Robbin Ehn wrote:

> On 12/04/2017 09:48 PM, [hidden email] wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8192870
>> http://cr.openjdk.java.net/~dlong/8192870/webrev/
>
> Looks good and thanks for fixing!
>
> /Robbin
>
>>
>> When we query WhiteBox.getBooleanVMFlag("UseJVMCICompiler"), we need
>> to check for null, in case JVMCI is not included in the build.
>>
>> dl