RFR(XS): 8193363: TestDumpReplay.java fails with product builds

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(XS): 8193363: TestDumpReplay.java fails with product builds

Tobias Hartmann-2
Hi,

please review the following patch that adds a missing -XX:+IgnoreUnrecognizedVMOptions to the test:
https://bugs.openjdk.java.net/browse/JDK-8193363
http://cr.openjdk.java.net/~thartmann/8193363/webrev.00/

Thanks,
Tobias
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS): 8193363: TestDumpReplay.java fails with product builds

Vladimir Kozlov
Good. One review is fine.

Thanks,
Vladimir

On 12/12/17 2:24 AM, Tobias Hartmann wrote:
> Hi,
>
> please review the following patch that adds a missing -XX:+IgnoreUnrecognizedVMOptions to the test:
> https://bugs.openjdk.java.net/browse/JDK-8193363
> http://cr.openjdk.java.net/~thartmann/8193363/webrev.00/
>
> Thanks,
> Tobias
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS): 8193363: TestDumpReplay.java fails with product builds

Tobias Hartmann-2
Hi Vladimir,

On 12.12.2017 18:15, Vladimir Kozlov wrote:
> Good. One review is fine.

Thanks for the review. Should I push this to jdk/jdk directly?

Best regards,
Tobias

> On 12/12/17 2:24 AM, Tobias Hartmann wrote:
>> Hi,
>>
>> please review the following patch that adds a missing -XX:+IgnoreUnrecognizedVMOptions to the test:
>> https://bugs.openjdk.java.net/browse/JDK-8193363
>> http://cr.openjdk.java.net/~thartmann/8193363/webrev.00/
>>
>> Thanks,
>> Tobias
>>
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS): 8193363: TestDumpReplay.java fails with product builds

Vladimir Kozlov
You can push into jdk/hs:

"FYI, Mark sent out the announcement below around RDP1. I'm happy to
highlight that this announcement states that all main JDK repositories
(which includes jdk/hs) will enter RDP1 at the same date, December 14th.

We have agreed on a process to allow pushes made to the jdk/hs
repository all the way up to December 14th to get integrated to the JDK
10 stabilization repository. This gives you another week to fix those
last critical P4-P5 bugs."

Vladimir

On 12/12/17 9:28 AM, Tobias Hartmann wrote:

> Hi Vladimir,
>
> On 12.12.2017 18:15, Vladimir Kozlov wrote:
>> Good. One review is fine.
>
> Thanks for the review. Should I push this to jdk/jdk directly?
>
> Best regards,
> Tobias
>> On 12/12/17 2:24 AM, Tobias Hartmann wrote:
>>> Hi,
>>>
>>> please review the following patch that adds a missing -XX:+IgnoreUnrecognizedVMOptions to the test:
>>> https://bugs.openjdk.java.net/browse/JDK-8193363
>>> http://cr.openjdk.java.net/~thartmann/8193363/webrev.00/
>>>
>>> Thanks,
>>> Tobias
>>>
Reply | Threaded
Open this post in threaded view
|

Re: RFR(XS): 8193363: TestDumpReplay.java fails with product builds

Tobias Hartmann-2

On 12.12.2017 18:59, Vladimir Kozlov wrote:
> You can push into jdk/hs:
>
> "FYI, Mark sent out the announcement below around RDP1. I'm happy to highlight that this announcement states that all
> main JDK repositories (which includes jdk/hs) will enter RDP1 at the same date, December 14th.
>
> We have agreed on a process to allow pushes made to the jdk/hs repository all the way up to December 14th to get
> integrated to the JDK 10 stabilization repository. This gives you another week to fix those last critical P4-P5 bugs."

Thanks, I'll push to jdk/hs then.

Best regards,
Tobias

> On 12/12/17 9:28 AM, Tobias Hartmann wrote:
>> Hi Vladimir,
>>
>> On 12.12.2017 18:15, Vladimir Kozlov wrote:
>>> Good. One review is fine.
>>
>> Thanks for the review. Should I push this to jdk/jdk directly?
>>
>> Best regards,
>> Tobias
>>> On 12/12/17 2:24 AM, Tobias Hartmann wrote:
>>>> Hi,
>>>>
>>>> please review the following patch that adds a missing -XX:+IgnoreUnrecognizedVMOptions to the test:
>>>> https://bugs.openjdk.java.net/browse/JDK-8193363
>>>> http://cr.openjdk.java.net/~thartmann/8193363/webrev.00/
>>>>
>>>> Thanks,
>>>> Tobias
>>>>