Quantcast

RFR (XS): JDK-8177070 - Quarantine tests due to JDK-8177069

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR (XS): JDK-8177070 - Quarantine tests due to JDK-8177069

Jesper Wilhelmsson
Hi,

Four AOT tests was not prepared to run on windows and are now failing in JPRT when I merge recent JDK 9 changes into JDK 10.
I'll quarantine the tests for now to be able to integrate 10/10 to 10/hs.

Bug: https://bugs.openjdk.java.net/browse/JDK-8177070 <https://bugs.openjdk.java.net/browse/JDK-8177070>
Patch for jdk10/hs/hotspot:

diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++ b/test/ProblemList.txt
@@ -106,6 +106,11 @@
 compiler/aot/calls/fromCompiled/CompiledInvokeDynamic2AotTest.java 8175791 windows-all
 compiler/aot/DeoptimizationTest.java 8175791 windows-all

+# aot tests failing due to JDK-8177069
+compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/ClassSourceTest.java
+compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/SearchPathTest.java
+compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/jar/JarSourceProviderTest.java
+compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/module/ModuleSourceProviderTest.java

 #############################################################################

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (XS): JDK-8177070 - Quarantine tests due to JDK-8177069

Igor Veresov
Looks good!

igor

> On Mar 17, 2017, at 9:26 PM, [hidden email] wrote:
>
> Hi,
>
> Four AOT tests was not prepared to run on windows and are now failing in JPRT when I merge recent JDK 9 changes into JDK 10.
> I'll quarantine the tests for now to be able to integrate 10/10 to 10/hs.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8177070 <https://bugs.openjdk.java.net/browse/JDK-8177070>
> Patch for jdk10/hs/hotspot:
>
> diff --git a/test/ProblemList.txt b/test/ProblemList.txt
> --- a/test/ProblemList.txt
> +++ b/test/ProblemList.txt
> @@ -106,6 +106,11 @@
> compiler/aot/calls/fromCompiled/CompiledInvokeDynamic2AotTest.java 8175791 windows-all
> compiler/aot/DeoptimizationTest.java 8175791 windows-all
>
> +# aot tests failing due to JDK-8177069
> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/ClassSourceTest.java
> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/SearchPathTest.java
> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/jar/JarSourceProviderTest.java
> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/module/ModuleSourceProviderTest.java
>
> #############################################################################
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (XS): JDK-8177070 - Quarantine tests due to JDK-8177069

Jesper Wilhelmsson
Thanks!
/Jesper

> On 17 Mar 2017, at 21:59, Igor Veresov <[hidden email]> wrote:
>
> Looks good!
>
> igor
>
>> On Mar 17, 2017, at 9:26 PM, [hidden email] wrote:
>>
>> Hi,
>>
>> Four AOT tests was not prepared to run on windows and are now failing in JPRT when I merge recent JDK 9 changes into JDK 10.
>> I'll quarantine the tests for now to be able to integrate 10/10 to 10/hs.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8177070 <https://bugs.openjdk.java.net/browse/JDK-8177070>
>> Patch for jdk10/hs/hotspot:
>>
>> diff --git a/test/ProblemList.txt b/test/ProblemList.txt
>> --- a/test/ProblemList.txt
>> +++ b/test/ProblemList.txt
>> @@ -106,6 +106,11 @@
>> compiler/aot/calls/fromCompiled/CompiledInvokeDynamic2AotTest.java 8175791 windows-all
>> compiler/aot/DeoptimizationTest.java 8175791 windows-all
>>
>> +# aot tests failing due to JDK-8177069
>> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/ClassSourceTest.java
>> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/SearchPathTest.java
>> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/jar/JarSourceProviderTest.java
>> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/module/ModuleSourceProviderTest.java
>>
>> #############################################################################
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (XS): JDK-8177070 - Quarantine tests due to JDK-8177069

Igor Ignatyev
In reply to this post by Jesper Wilhelmsson
Hi Jesper,

The right syntax for quarantining tests in ProblemList.txt is <test_name> <bug_id> <platform_keywords>, so it will be

> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/ClassSourceTest.java 8177069 generic-all
> …
And since they fail only on windows, it should be
> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/ClassSourceTest.java 8177069 windows-all
> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/SearchPathTest.java 8177069 windows-all
> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/jar/JarSourceProviderTest.java 8177069 windows-all
> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/module/ModuleSourceProviderTest.java 8177069 windows-all

Thanks,
— Igor

> On Mar 17, 2017, at 9:26 PM, [hidden email] wrote:
>
> Hi,
>
> Four AOT tests was not prepared to run on windows and are now failing in JPRT when I merge recent JDK 9 changes into JDK 10.
> I'll quarantine the tests for now to be able to integrate 10/10 to 10/hs.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8177070 <https://bugs.openjdk.java.net/browse/JDK-8177070>
> Patch for jdk10/hs/hotspot:
>
> diff --git a/test/ProblemList.txt b/test/ProblemList.txt
> --- a/test/ProblemList.txt
> +++ b/test/ProblemList.txt
> @@ -106,6 +106,11 @@
> compiler/aot/calls/fromCompiled/CompiledInvokeDynamic2AotTest.java 8175791 windows-all
> compiler/aot/DeoptimizationTest.java 8175791 windows-all
>
> +# aot tests failing due to JDK-8177069
> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/ClassSourceTest.java
> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/SearchPathTest.java
> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/jar/JarSourceProviderTest.java
> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/module/ModuleSourceProviderTest.java
>
> #############################################################################
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR (XS): JDK-8177070 - Quarantine tests due to JDK-8177069

Jesper Wilhelmsson
Thanks for catching that Igor!
/Jesper

> On 18 Mar 2017, at 17:54, Igor Ignatyev <[hidden email]> wrote:
>
> Hi Jesper,
>
> The right syntax for quarantining tests in ProblemList.txt is <test_name> <bug_id> <platform_keywords>, so it will be
>
>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/ClassSourceTest.java 8177069 generic-all
>> …
> And since they fail only on windows, it should be
>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/ClassSourceTest.java 8177069 windows-all
>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/SearchPathTest.java 8177069 windows-all
>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/jar/JarSourceProviderTest.java 8177069 windows-all
>> compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/module/ModuleSourceProviderTest.java 8177069 windows-all
>
> Thanks,
> — Igor
>
>> On Mar 17, 2017, at 9:26 PM, [hidden email] wrote:
>>
>> Hi,
>>
>> Four AOT tests was not prepared to run on windows and are now failing in JPRT when I merge recent JDK 9 changes into JDK 10.
>> I'll quarantine the tests for now to be able to integrate 10/10 to 10/hs.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8177070 <https://bugs.openjdk.java.net/browse/JDK-8177070>
>> Patch for jdk10/hs/hotspot:
>>
>> diff --git a/test/ProblemList.txt b/test/ProblemList.txt
>> --- a/test/ProblemList.txt
>> +++ b/test/ProblemList.txt
>> @@ -106,6 +106,11 @@
>> compiler/aot/calls/fromCompiled/CompiledInvokeDynamic2AotTest.java 8175791 windows-all
>> compiler/aot/DeoptimizationTest.java 8175791 windows-all
>>
>> +# aot tests failing due to JDK-8177069
>> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/ClassSourceTest.java
>> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/SearchPathTest.java
>> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/jar/JarSourceProviderTest.java
>> +compiler/aot/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/module/ModuleSourceProviderTest.java
>>
>> #############################################################################
>>
>

Loading...