Quantcast

RFR: XS: URGENT: JDK-8180129, , Bundles.gmk:181: *** unterminated call to function 'filter-out': missing ')'

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR: XS: URGENT: JDK-8180129, , Bundles.gmk:181: *** unterminated call to function 'filter-out': missing ')'

Tim Bell
A fix for packaging changes in the closed files missed one line
continuation in an open file, and without this all builds fail:

% hg diff
diff --git a/make/Bundles.gmk b/make/Bundles.gmk
--- a/make/Bundles.gmk
+++ b/make/Bundles.gmk
@@ -183,7 +183,7 @@
            $(JDK_SYMBOLS_EXCLUDE_PATTERN) \
            $(JDK_EXTRA_EXCLUDES) \
            $(SYMBOLS_EXCLUDE_PATTERN) \
-          $(JDK_IMAGE_HOMEDIR)/demo/%
+          $(JDK_IMAGE_HOMEDIR)/demo/% \
            , \
            $(ALL_JDK_FILES) \
        )

Already reviewed in person by erikj.  I am sending to the open build
list to complete the loop.

Thanks in advance-

Tim
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: XS: URGENT: JDK-8180129, , Bundles.gmk:181: *** unterminated call to function 'filter-out': missing ')'

Erik Joelsson
Looks good. Thanks for fixing this!

/Erik


On 2017-05-10 15:06, Tim Bell wrote:

> A fix for packaging changes in the closed files missed one line
> continuation in an open file, and without this all builds fail:
>
> % hg diff
> diff --git a/make/Bundles.gmk b/make/Bundles.gmk
> --- a/make/Bundles.gmk
> +++ b/make/Bundles.gmk
> @@ -183,7 +183,7 @@
>            $(JDK_SYMBOLS_EXCLUDE_PATTERN) \
>            $(JDK_EXTRA_EXCLUDES) \
>            $(SYMBOLS_EXCLUDE_PATTERN) \
> -          $(JDK_IMAGE_HOMEDIR)/demo/%
> +          $(JDK_IMAGE_HOMEDIR)/demo/% \
>            , \
>            $(ALL_JDK_FILES) \
>        )
>
> Already reviewed in person by erikj.  I am sending to the open build
> list to complete the loop.
>
> Thanks in advance-
>
> Tim

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: XS: URGENT: JDK-8180129, , Bundles.gmk:181: *** unterminated call to function 'filter-out': missing ')'

Brad R. Wetmore
In reply to this post by Tim Bell
Looks good.

Brad


On 5/10/2017 3:06 PM, Tim Bell wrote:

> A fix for packaging changes in the closed files missed one line
> continuation in an open file, and without this all builds fail:
>
> % hg diff
> diff --git a/make/Bundles.gmk b/make/Bundles.gmk
> --- a/make/Bundles.gmk
> +++ b/make/Bundles.gmk
> @@ -183,7 +183,7 @@
>            $(JDK_SYMBOLS_EXCLUDE_PATTERN) \
>            $(JDK_EXTRA_EXCLUDES) \
>            $(SYMBOLS_EXCLUDE_PATTERN) \
> -          $(JDK_IMAGE_HOMEDIR)/demo/%
> +          $(JDK_IMAGE_HOMEDIR)/demo/% \
>            , \
>            $(ALL_JDK_FILES) \
>        )
>
> Already reviewed in person by erik.  I am sending to the open build
> list to complete the loop.
>
> Thanks in advance-
>
> Tim
Loading...