Quantcast

RFR(XXS) : 8180004: jdk.test.lib.DynamicVMOption should be moved to jdk.test.lib.management

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR(XXS) : 8180004: jdk.test.lib.DynamicVMOption should be moved to jdk.test.lib.management

Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8180004/webrev.00/index.html
> 8 lines changed: 1 ins; 0 del; 7 mod;

Hi all,

could you please review this tiny patch which moves jdk.test.lib.DynamicVMOption class to jdk.test.lib.management package and updates the tests which use it?
j.t.l.DynamicVMOption uses classes from jdk.management module, so having it in common testlibrary package might cause redundant module dependencies.

webrev: http://cr.openjdk.java.net/~iignatyev//8180004/webrev.00/index.html
jbs: https://bugs.openjdk.java.net/browse/JDK-8180004
testing: :hotspot_all

Thanks,
-- Igor  

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XXS) : 8180004: jdk.test.lib.DynamicVMOption should be moved to jdk.test.lib.management

Mikhailo Seledtsov
Looks good to me,

Misha


On 05/09/2017 02:05 PM, Igor Ignatyev wrote:

> http://cr.openjdk.java.net/~iignatyev//8180004/webrev.00/index.html
>> 8 lines changed: 1 ins; 0 del; 7 mod;
> Hi all,
>
> could you please review this tiny patch which moves jdk.test.lib.DynamicVMOption class to jdk.test.lib.management package and updates the tests which use it?
> j.t.l.DynamicVMOption uses classes from jdk.management module, so having it in common testlibrary package might cause redundant module dependencies.
>
> webrev: http://cr.openjdk.java.net/~iignatyev//8180004/webrev.00/index.html
> jbs: https://bugs.openjdk.java.net/browse/JDK-8180004
> testing: :hotspot_all
>
> Thanks,
> -- Igor
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR(XXS) : 8180183: Confusing javadoc comment to the getOutput(ProcessBuilder processBuilder) method of jdk.test.lib.process.ProcessTools

Dmitry Fazunenko
In reply to this post by Igor Ignatyev
http://cr.openjdk.java.net/~dfazunen/8180183/webrev.00/
> 1 line changed: 0 ins; 0 del; 1 mod;

Hi everyone,

a tiny patch is waiting for reviewers.

Thanks,
Dima


http://cr.openjdk.java.net/~dfazunen/8180183/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8180183

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XXS) : 8180183: Confusing javadoc comment to the getOutput(ProcessBuilder processBuilder) method of jdk.test.lib.process.ProcessTools

Aleksey Shipilev-4
On 05/11/2017 06:40 PM, Dmitry Fazunenko wrote:
> http://cr.openjdk.java.net/~dfazunen/8180183/webrev.00/
>> 1 line changed: 0 ins; 0 del; 1 mod;

Looks good.

Thanks,
-Aleksey


Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XXS) : 8180183: Confusing javadoc comment to the getOutput(ProcessBuilder processBuilder) method of jdk.test.lib.process.ProcessTools

Dmitry Fazunenko
Thanks, Aleksey!

On 11.05.2017 19:42, Aleksey Shipilev wrote:
> On 05/11/2017 06:40 PM, Dmitry Fazunenko wrote:
>> http://cr.openjdk.java.net/~dfazunen/8180183/webrev.00/
>>> 1 line changed: 0 ins; 0 del; 1 mod;
> Looks good.
>
> Thanks,
> -Aleksey
>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XXS) : 8180004: jdk.test.lib.DynamicVMOption should be moved to jdk.test.lib.management

Vladimir Ivanov
In reply to this post by Igor Ignatyev
Reviewed.

Best regards,
Vladimir Ivanov

On 5/10/17 12:05 AM, Igor Ignatyev wrote:

> http://cr.openjdk.java.net/~iignatyev//8180004/webrev.00/index.html
>> 8 lines changed: 1 ins; 0 del; 7 mod;
>
> Hi all,
>
> could you please review this tiny patch which moves jdk.test.lib.DynamicVMOption class to jdk.test.lib.management package and updates the tests which use it?
> j.t.l.DynamicVMOption uses classes from jdk.management module, so having it in common testlibrary package might cause redundant module dependencies.
>
> webrev: http://cr.openjdk.java.net/~iignatyev//8180004/webrev.00/index.html
> jbs: https://bugs.openjdk.java.net/browse/JDK-8180004
> testing: :hotspot_all
>
> Thanks,
> -- Igor
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR(XXS) : 8180183: Confusing javadoc comment to the getOutput(ProcessBuilder processBuilder) method of jdk.test.lib.process.ProcessTools

serguei.spitsyn@oracle.com
In reply to this post by Aleksey Shipilev-4
+1

Thanks,
Serguei


On 5/11/17 09:42, Aleksey Shipilev wrote:
> On 05/11/2017 06:40 PM, Dmitry Fazunenko wrote:
>> http://cr.openjdk.java.net/~dfazunen/8180183/webrev.00/
>>> 1 line changed: 0 ins; 0 del; 1 mod;
> Looks good.
>
> Thanks,
> -Aleksey
>
>

Loading...