RFR[XXS]: 8186778 Make obsolete VM options for shared region size control

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR[XXS]: 8186778 Make obsolete VM options for shared region size control

Ioi Lam
Hi,

Please review this very small change. These VM arguments are no longer
used when creating a CDS archive, so they should be declared obsolete:

https://bugs.openjdk.java.net/browse/JDK-8186778
http://cr.openjdk.java.net/~iklam/jdk10/8186778-make-onsolete-shared-region-size-args.v01/

Thanks
- Ioi

-----
$ java -XX:SharedReadWriteSize=123  -XX:SharedReadOnlySize=123
-XX:SharedMiscDataSize=123 -XX:SharedMiscCodeSize=123 -version
Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option
SharedReadWriteSize; support was removed in 10.0
Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option
SharedReadOnlySize; support was removed in 10.0
Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option
SharedMiscDataSize; support was removed in 10.0
Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option
SharedMiscCodeSize; support was removed in 10.0
java version "10-internal"
Java(TM) SE Runtime Environment (build 10-internal+0-adhoc.iklam.open)
Java HotSpot(TM) 64-Bit Server VM (build 10-internal+0-adhoc.iklam.open,
mixed mode)

Reply | Threaded
Open this post in threaded view
|

Re: RFR[XXS]: 8186778 Make obsolete VM options for shared region size control

David Holmes
Hi Ioi,

On 8/11/2017 3:33 AM, Ioi Lam wrote:
> Hi,
>
> Please review this very small change. These VM arguments are no longer
> used when creating a CDS archive, so they should be declared obsolete:
>
> https://bugs.openjdk.java.net/browse/JDK-8186778
> http://cr.openjdk.java.net/~iklam/jdk10/8186778-make-onsolete-shared-region-size-args.v01/ 


Okay. This is correcting an oversight made when the flags actually
stopped being examined.

Thanks,
David

>
> Thanks
> - Ioi
>
> -----
> $ java -XX:SharedReadWriteSize=123  -XX:SharedReadOnlySize=123
> -XX:SharedMiscDataSize=123 -XX:SharedMiscCodeSize=123 -version
> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option
> SharedReadWriteSize; support was removed in 10.0
> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option
> SharedReadOnlySize; support was removed in 10.0
> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option
> SharedMiscDataSize; support was removed in 10.0
> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option
> SharedMiscCodeSize; support was removed in 10.0
> java version "10-internal"
> Java(TM) SE Runtime Environment (build 10-internal+0-adhoc.iklam.open)
> Java HotSpot(TM) 64-Bit Server VM (build 10-internal+0-adhoc.iklam.open,
> mixed mode)
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR[XXS]: 8186778 Make obsolete VM options for shared region size control

Jiangli Zhou
In reply to this post by Ioi Lam
Looks good.

Thanks,
Jiangli

> On Nov 7, 2017, at 9:33 AM, Ioi Lam <[hidden email]> wrote:
>
> Hi,
>
> Please review this very small change. These VM arguments are no longer used when creating a CDS archive, so they should be declared obsolete:
>
> https://bugs.openjdk.java.net/browse/JDK-8186778
> http://cr.openjdk.java.net/~iklam/jdk10/8186778-make-onsolete-shared-region-size-args.v01/
>
> Thanks
> - Ioi
>
> -----
> $ java -XX:SharedReadWriteSize=123  -XX:SharedReadOnlySize=123 -XX:SharedMiscDataSize=123 -XX:SharedMiscCodeSize=123 -version
> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option SharedReadWriteSize; support was removed in 10.0
> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option SharedReadOnlySize; support was removed in 10.0
> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option SharedMiscDataSize; support was removed in 10.0
> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option SharedMiscCodeSize; support was removed in 10.0
> java version "10-internal"
> Java(TM) SE Runtime Environment (build 10-internal+0-adhoc.iklam.open)
> Java HotSpot(TM) 64-Bit Server VM (build 10-internal+0-adhoc.iklam.open, mixed mode)
>