Quantcast

RFR: (XXS): JDK-8175135: Header template correction for year

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR: (XXS): JDK-8175135: Header template correction for year

Gerard Ziemski
hi all,

Please review this extra small bug fix, that adds comma to the copyright header as required by the GPL header template.

Verified with the jdk/make/scripts/lic_check.sh script and JPRT build.

issue:  https://bugs.openjdk.java.net/browse/JDK-8175135
webrev: http://cr.openjdk.java.net/~gziemski/8175135_rev1/

Thank you
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: (XXS): JDK-8175135: Header template correction for year

Daniel D. Daugherty
Thumbs up!

This change qualifies for a single (R)eviewer under HotSpot's trivial
change rule.

Dan


On 2/22/17 10:13 AM, Gerard Ziemski wrote:

> hi all,
>
> Please review this extra small bug fix, that adds comma to the copyright header as required by the GPL header template.
>
> Verified with the jdk/make/scripts/lic_check.sh script and JPRT build.
>
> issue:  https://bugs.openjdk.java.net/browse/JDK-8175135
> webrev: http://cr.openjdk.java.net/~gziemski/8175135_rev1/
>
> Thank you

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: (XXS): JDK-8175135: Header template correction for year

Gerald Thornbrugh
In reply to this post by Gerard Ziemski
Hi Gerard,

Your change looks good.

Jerry

> On Feb 22, 2017, at 10:13 AM, Gerard Ziemski <[hidden email]> wrote:
>
> hi all,
>
> Please review this extra small bug fix, that adds comma to the copyright header as required by the GPL header template.
>
> Verified with the jdk/make/scripts/lic_check.sh script and JPRT build.
>
> issue:  https://bugs.openjdk.java.net/browse/JDK-8175135
> webrev: http://cr.openjdk.java.net/~gziemski/8175135_rev1/
>
> Thank you

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: (XXS): JDK-8175135: Header template correction for year

Gerard Ziemski
In reply to this post by Daniel D. Daugherty
Thank you Dan!

> On Feb 22, 2017, at 11:15 AM, Daniel D. Daugherty <[hidden email]> wrote:
>
> Thumbs up!
>
> This change qualifies for a single (R)eviewer under HotSpot's trivial
> change rule.
>
> Dan
>
>
> On 2/22/17 10:13 AM, Gerard Ziemski wrote:
>> hi all,
>>
>> Please review this extra small bug fix, that adds comma to the copyright header as required by the GPL header template.
>>
>> Verified with the jdk/make/scripts/lic_check.sh script and JPRT build.
>>
>> issue:  https://bugs.openjdk.java.net/browse/JDK-8175135
>> webrev: http://cr.openjdk.java.net/~gziemski/8175135_rev1/
>>
>> Thank you
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: (XXS): JDK-8175135: Header template correction for year

Gerard Ziemski
In reply to this post by Gerald Thornbrugh
Thank you Jerry!

> On Feb 22, 2017, at 11:16 AM, Gerald Thornbrugh <[hidden email]> wrote:
>
> Hi Gerard,
>
> Your change looks good.
>
> Jerry
>> On Feb 22, 2017, at 10:13 AM, Gerard Ziemski <[hidden email]> wrote:
>>
>> hi all,
>>
>> Please review this extra small bug fix, that adds comma to the copyright header as required by the GPL header template.
>>
>> Verified with the jdk/make/scripts/lic_check.sh script and JPRT build.
>>
>> issue:  https://bugs.openjdk.java.net/browse/JDK-8175135
>> webrev: http://cr.openjdk.java.net/~gziemski/8175135_rev1/
>>
>> Thank you
>

Loading...