RFR (XXS): JDK-8190745 - AARCH64: fix for JDK-8189176 may break a build

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR (XXS): JDK-8190745 - AARCH64: fix for JDK-8189176 may break a build

Dmitry Chuyko-2
Hello.

I'm sorry, the webrev version of the fix for JDK-8189176 (aarch64) had
missing semicolon in one of loop bindings.
Please review a trivial fix, I'll also need a sponsorship for making a
push. Details are at the bottom.

-Dmitry

bug: https://bugs.openjdk.java.net/browse/JDK-8190745
patch:

diff -r d85284ccd1bd src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
--- a/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp    Fri Nov 03
17:09:25 2017 -0700
+++ b/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp    Sun Nov 05
18:16:48 2017 +0300
@@ -2942,7 +2942,7 @@
    BIND(CRC_less64);
      adds(len, len, 128-32);
      br(Assembler::GE, CRC_by32_loop);
-  BIND(CRC_less32)
+  BIND(CRC_less32);
      adds(len, len, 32-4);
      br(Assembler::GE, CRC_by4_loop);
      adds(len, len, 4);



Reply | Threaded
Open this post in threaded view
|

Re: Fwd: RFR (XXS): JDK-8190745 - AARCH64: fix for JDK-8189176 may break a build

Dmitry Samersoff-3
Dmitry,

The fix looks good to me.

I'll sponsor the push as soon as the build finishes.

-Dmitry

On 11/05/2017 07:33 PM, Dmitry Chuyko wrote:

> Hello.
>
> I'm sorry, the webrev version of the fix for JDK-8189176 (aarch64) had
> missing semicolon in one of loop bindings.
> Please review a trivial fix, I'll also need a sponsorship for making a
> push. Details are at the bottom.
>
> -Dmitry
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8190745
> patch:
>
> diff -r d85284ccd1bd src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
> --- a/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp    Fri Nov 03
> 17:09:25 2017 -0700
> +++ b/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp    Sun Nov 05
> 18:16:48 2017 +0300
> @@ -2942,7 +2942,7 @@
>    BIND(CRC_less64);
>      adds(len, len, 128-32);
>      br(Assembler::GE, CRC_by32_loop);
> -  BIND(CRC_less32)
> +  BIND(CRC_less32);
>      adds(len, len, 32-4);
>      br(Assembler::GE, CRC_by4_loop);
>      adds(len, len, 4);
>
>
>