RFR(XXXS): 8192810 - EnableThreadSMRStatistics should be default off in release builds

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(XXXS): 8192810 - EnableThreadSMRStatistics should be default off in release builds

Daniel D. Daugherty
Greetings,

Trivial fix here so I need a single (R)eviewer for this one.

8192810 EnableThreadSMRStatistics should be default off in release builds
https://bugs.openjdk.java.net/browse/JDK-8192810

$ hg diff
diff -r 61a14b5cb1c6 src/hotspot/share/runtime/globals.hpp
--- a/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 18:19:39 2017
+0530
+++ b/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 10:15:47 2017
-0500
@@ -2488,7 +2488,7 @@
    diagnostic(bool, EnableThreadSMRExtraValidityChecks,
true,                \
               "Enable Thread SMR extra validity
checks")                     \
\
-  diagnostic(bool, EnableThreadSMRStatistics,
true,                         \
+  diagnostic(bool, EnableThreadSMRStatistics,
trueInDebug,                  \
               "Enable Thread SMR
Statistics")                                \
\
    product(bool, Inline,
true,                                               \


Thanks, in advance, for a quick review.

Dan

Reply | Threaded
Open this post in threaded view
|

Re: RFR(XXXS): 8192810 - EnableThreadSMRStatistics should be default off in release builds

George Triantafillou
Hi Dan,

Looks good!

-George


On 12/1/2017 10:18 AM, Daniel D. Daugherty wrote:

> Greetings,
>
> Trivial fix here so I need a single (R)eviewer for this one.
>
> 8192810 EnableThreadSMRStatistics should be default off in release builds
> https://bugs.openjdk.java.net/browse/JDK-8192810
>
> $ hg diff
> diff -r 61a14b5cb1c6 src/hotspot/share/runtime/globals.hpp
> --- a/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 18:19:39
> 2017 +0530
> +++ b/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 10:15:47
> 2017 -0500
> @@ -2488,7 +2488,7 @@
>    diagnostic(bool, EnableThreadSMRExtraValidityChecks,
> true,                \
>               "Enable Thread SMR extra validity
> checks")                     \
> \
> -  diagnostic(bool, EnableThreadSMRStatistics,
> true,                         \
> +  diagnostic(bool, EnableThreadSMRStatistics,
> trueInDebug,                  \
>               "Enable Thread SMR
> Statistics")                                \
> \
>    product(bool, Inline,
> true,                                               \
>
>
> Thanks, in advance, for a quick review.
>
> Dan
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR(XXXS): 8192810 - EnableThreadSMRStatistics should be default off in release builds

Daniel D. Daugherty
Thanks George!

Dan


On 12/1/17 10:49 AM, George Triantafillou wrote:

> Hi Dan,
>
> Looks good!
>
> -George
>
>
> On 12/1/2017 10:18 AM, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> Trivial fix here so I need a single (R)eviewer for this one.
>>
>> 8192810 EnableThreadSMRStatistics should be default off in release
>> builds
>> https://bugs.openjdk.java.net/browse/JDK-8192810
>>
>> $ hg diff
>> diff -r 61a14b5cb1c6 src/hotspot/share/runtime/globals.hpp
>> --- a/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 18:19:39
>> 2017 +0530
>> +++ b/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 10:15:47
>> 2017 -0500
>> @@ -2488,7 +2488,7 @@
>>    diagnostic(bool, EnableThreadSMRExtraValidityChecks,
>> true,                \
>>               "Enable Thread SMR extra validity
>> checks")                     \
>> \
>> -  diagnostic(bool, EnableThreadSMRStatistics,
>> true,                         \
>> +  diagnostic(bool, EnableThreadSMRStatistics,
>> trueInDebug,                  \
>>               "Enable Thread SMR
>> Statistics")                                \
>> \
>>    product(bool, Inline,
>> true,                                               \
>>
>>
>> Thanks, in advance, for a quick review.
>>
>> Dan
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR(XXXS): 8192810 - EnableThreadSMRStatistics should be default off in release builds

coleen.phillimore
In reply to this post by Daniel D. Daugherty
Yes, this looks good.  Thank you for fixing this so quickly!
Coleen

On 12/1/17 10:18 AM, Daniel D. Daugherty wrote:

> Greetings,
>
> Trivial fix here so I need a single (R)eviewer for this one.
>
> 8192810 EnableThreadSMRStatistics should be default off in release builds
> https://bugs.openjdk.java.net/browse/JDK-8192810
>
> $ hg diff
> diff -r 61a14b5cb1c6 src/hotspot/share/runtime/globals.hpp
> --- a/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 18:19:39
> 2017 +0530
> +++ b/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 10:15:47
> 2017 -0500
> @@ -2488,7 +2488,7 @@
>    diagnostic(bool, EnableThreadSMRExtraValidityChecks,
> true,                \
>               "Enable Thread SMR extra validity
> checks")                     \
> \
> -  diagnostic(bool, EnableThreadSMRStatistics,
> true,                         \
> +  diagnostic(bool, EnableThreadSMRStatistics,
> trueInDebug,                  \
>               "Enable Thread SMR
> Statistics")                                \
> \
>    product(bool, Inline,
> true,                                               \
>
>
> Thanks, in advance, for a quick review.
>
> Dan
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR(XXXS): 8192810 - EnableThreadSMRStatistics should be default off in release builds

Daniel D. Daugherty
Thanks Coleen!

Dan


On 12/1/17 10:52 AM, [hidden email] wrote:

> Yes, this looks good.  Thank you for fixing this so quickly!
> Coleen
>
> On 12/1/17 10:18 AM, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> Trivial fix here so I need a single (R)eviewer for this one.
>>
>> 8192810 EnableThreadSMRStatistics should be default off in release
>> builds
>> https://bugs.openjdk.java.net/browse/JDK-8192810
>>
>> $ hg diff
>> diff -r 61a14b5cb1c6 src/hotspot/share/runtime/globals.hpp
>> --- a/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 18:19:39
>> 2017 +0530
>> +++ b/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 10:15:47
>> 2017 -0500
>> @@ -2488,7 +2488,7 @@
>>    diagnostic(bool, EnableThreadSMRExtraValidityChecks,
>> true,                \
>>               "Enable Thread SMR extra validity
>> checks")                     \
>> \
>> -  diagnostic(bool, EnableThreadSMRStatistics,
>> true,                         \
>> +  diagnostic(bool, EnableThreadSMRStatistics,
>> trueInDebug,                  \
>>               "Enable Thread SMR
>> Statistics")                                \
>> \
>>    product(bool, Inline,
>> true,                                               \
>>
>>
>> Thanks, in advance, for a quick review.
>>
>> Dan
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR(XXXS): 8192810 - EnableThreadSMRStatistics should be default off in release builds

Erik Österlund-2
In reply to this post by Daniel D. Daugherty
Hi,

Looks good.

Thanks,
/Erik

On 2017-12-01 16:18, Daniel D. Daugherty wrote:

> Greetings,
>
> Trivial fix here so I need a single (R)eviewer for this one.
>
> 8192810 EnableThreadSMRStatistics should be default off in release builds
> https://bugs.openjdk.java.net/browse/JDK-8192810
>
> $ hg diff
> diff -r 61a14b5cb1c6 src/hotspot/share/runtime/globals.hpp
> --- a/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 18:19:39
> 2017 +0530
> +++ b/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 10:15:47
> 2017 -0500
> @@ -2488,7 +2488,7 @@
>    diagnostic(bool, EnableThreadSMRExtraValidityChecks,
> true,                \
>               "Enable Thread SMR extra validity
> checks")                     \
> \
> -  diagnostic(bool, EnableThreadSMRStatistics,
> true,                         \
> +  diagnostic(bool, EnableThreadSMRStatistics,
> trueInDebug,                  \
>               "Enable Thread SMR
> Statistics")                                \
> \
>    product(bool, Inline,
> true,                                               \
>
>
> Thanks, in advance, for a quick review.
>
> Dan
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR(XXXS): 8192810 - EnableThreadSMRStatistics should be default off in release builds

Daniel D. Daugherty
Thanks Erik!

Dan


On 12/1/17 11:00 AM, Erik Österlund wrote:

> Hi,
>
> Looks good.
>
> Thanks,
> /Erik
>
> On 2017-12-01 16:18, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> Trivial fix here so I need a single (R)eviewer for this one.
>>
>> 8192810 EnableThreadSMRStatistics should be default off in release
>> builds
>> https://bugs.openjdk.java.net/browse/JDK-8192810
>>
>> $ hg diff
>> diff -r 61a14b5cb1c6 src/hotspot/share/runtime/globals.hpp
>> --- a/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 18:19:39
>> 2017 +0530
>> +++ b/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 10:15:47
>> 2017 -0500
>> @@ -2488,7 +2488,7 @@
>>    diagnostic(bool, EnableThreadSMRExtraValidityChecks,
>> true,                \
>>               "Enable Thread SMR extra validity
>> checks")                     \
>> \
>> -  diagnostic(bool, EnableThreadSMRStatistics,
>> true,                         \
>> +  diagnostic(bool, EnableThreadSMRStatistics,
>> trueInDebug,                  \
>>               "Enable Thread SMR
>> Statistics")                                \
>> \
>>    product(bool, Inline,
>> true,                                               \
>>
>>
>> Thanks, in advance, for a quick review.
>>
>> Dan
>>
>