RFR of JDK-8177553: Address removal lint warnings in the JDK build

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR of JDK-8177553: Address removal lint warnings in the JDK build

joe darcy
Hello,

As a continuation of the warnings cleanup of JEP 212 (JDK-8042878), the
new-in-9 lint category of "removal" warnings for use of deprecated for
removal items should be enable as a fatal warning in the build.

I have out for review under various subtasks the code changes needed to
suppress the removal warnings (JDK-8177682, JDK-8177683, JDK-8177684, etc.).

Assuming those changes are in, please review the patch needed to enable
the warning in the build:

diff -r c38c6b270ccc make/common/SetupJavaCompilers.gmk
--- a/make/common/SetupJavaCompilers.gmk    Thu Mar 23 22:56:58 2017 +0000
+++ b/make/common/SetupJavaCompilers.gmk    Tue Mar 28 18:57:57 2017 -0700
@@ -32,7 +32,7 @@

  # If warnings needs to be non-fatal for testing purposes use a command
like:
  # make JAVAC_WARNINGS="-Xlint:all -Xmaxwarns 10000"
-JAVAC_WARNINGS := -Xlint:all,-removal -Werror
+JAVAC_WARNINGS := -Xlint:all -Werror

  # The BOOT_JAVAC setup uses the boot jdk compiler to compile the tools
  # and the interim javac, to be run by the boot jdk.

I'd prefer to get this bug and its subtasks addressed in JDK 9; however,
if that is not approved as part of rampdown 2, I'll push the associated
changes to JDK 10 instead.

Thanks,

-Joe

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR of JDK-8177553: Address removal lint warnings in the JDK build

Mandy Chung
Looks good to me.
Mandy

> On Mar 28, 2017, at 6:59 PM, joe darcy <[hidden email]> wrote:
>
> Hello,
>
> As a continuation of the warnings cleanup of JEP 212 (JDK-8042878), the new-in-9 lint category of "removal" warnings for use of deprecated for removal items should be enable as a fatal warning in the build.
>
> I have out for review under various subtasks the code changes needed to suppress the removal warnings (JDK-8177682, JDK-8177683, JDK-8177684, etc.).
>
> Assuming those changes are in, please review the patch needed to enable the warning in the build:
>
> diff -r c38c6b270ccc make/common/SetupJavaCompilers.gmk
> --- a/make/common/SetupJavaCompilers.gmk    Thu Mar 23 22:56:58 2017 +0000
> +++ b/make/common/SetupJavaCompilers.gmk    Tue Mar 28 18:57:57 2017 -0700
> @@ -32,7 +32,7 @@
>
> # If warnings needs to be non-fatal for testing purposes use a command like:
> # make JAVAC_WARNINGS="-Xlint:all -Xmaxwarns 10000"
> -JAVAC_WARNINGS := -Xlint:all,-removal -Werror
> +JAVAC_WARNINGS := -Xlint:all -Werror
>
> # The BOOT_JAVAC setup uses the boot jdk compiler to compile the tools
> # and the interim javac, to be run by the boot jdk.
>
> I'd prefer to get this bug and its subtasks addressed in JDK 9; however, if that is not approved as part of rampdown 2, I'll push the associated changes to JDK 10 instead.
>
> Thanks,
>
> -Joe
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR of JDK-8177553: Address removal lint warnings in the JDK build

Erik Joelsson
In reply to this post by joe darcy
Looks good.

/Erik


On 2017-03-29 03:59, joe darcy wrote:

> Hello,
>
> As a continuation of the warnings cleanup of JEP 212 (JDK-8042878),
> the new-in-9 lint category of "removal" warnings for use of deprecated
> for removal items should be enable as a fatal warning in the build.
>
> I have out for review under various subtasks the code changes needed
> to suppress the removal warnings (JDK-8177682, JDK-8177683,
> JDK-8177684, etc.).
>
> Assuming those changes are in, please review the patch needed to
> enable the warning in the build:
>
> diff -r c38c6b270ccc make/common/SetupJavaCompilers.gmk
> --- a/make/common/SetupJavaCompilers.gmk    Thu Mar 23 22:56:58 2017
> +0000
> +++ b/make/common/SetupJavaCompilers.gmk    Tue Mar 28 18:57:57 2017
> -0700
> @@ -32,7 +32,7 @@
>
>  # If warnings needs to be non-fatal for testing purposes use a
> command like:
>  # make JAVAC_WARNINGS="-Xlint:all -Xmaxwarns 10000"
> -JAVAC_WARNINGS := -Xlint:all,-removal -Werror
> +JAVAC_WARNINGS := -Xlint:all -Werror
>
>  # The BOOT_JAVAC setup uses the boot jdk compiler to compile the tools
>  # and the interim javac, to be run by the boot jdk.
>
> I'd prefer to get this bug and its subtasks addressed in JDK 9;
> however, if that is not approved as part of rampdown 2, I'll push the
> associated changes to JDK 10 instead.
>
> Thanks,
>
> -Joe
>

Loading...