RFR (xs) 8190491: SA tests failed after 8189610 changes

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR (xs) 8190491: SA tests failed after 8189610 changes

coleen.phillimore
Summary: Changed a type in hotspot not reflected in SA code.

open webrev at http://cr.openjdk.java.net/~coleenp/8190491.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8190491

Ran test/hotspot/serviceability/sa and gc/metaspace tests locally with
fix, tier1 testing locally in progress.  I'll run more tests if we wish
to wait.

Thanks,
Coleen
Reply | Threaded
Open this post in threaded view
|

Re: RFR (xs) 8190491: SA tests failed after 8189610 changes

harold seigel
Hi Coleen,

The fix looks good.

Harold


On 11/1/2017 4:29 PM, [hidden email] wrote:

> Summary: Changed a type in hotspot not reflected in SA code.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8190491.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8190491
>
> Ran test/hotspot/serviceability/sa and gc/metaspace tests locally with
> fix, tier1 testing locally in progress.  I'll run more tests if we
> wish to wait.
>
> Thanks,
> Coleen

Reply | Threaded
Open this post in threaded view
|

Re: RFR (xs) 8190491: SA tests failed after 8189610 changes

Jiangli Zhou
In reply to this post by coleen.phillimore
Looks good.

Thanks,
Jiangli

> On Nov 1, 2017, at 1:29 PM, [hidden email] wrote:
>
> Summary: Changed a type in hotspot not reflected in SA code.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8190491.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8190491
>
> Ran test/hotspot/serviceability/sa and gc/metaspace tests locally with fix, tier1 testing locally in progress.  I'll run more tests if we wish to wait.
>
> Thanks,
> Coleen

Reply | Threaded
Open this post in threaded view
|

Re: RFR (xs) 8190491: SA tests failed after 8189610 changes

harold seigel
Thanks Jiangli!

I went ahead and pushed the change for Coleen.

Harold


On 11/1/2017 6:57 PM, Jiangli Zhou wrote:

> Looks good.
>
> Thanks,
> Jiangli
>
>> On Nov 1, 2017, at 1:29 PM, [hidden email] wrote:
>>
>> Summary: Changed a type in hotspot not reflected in SA code.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8190491.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8190491
>>
>> Ran test/hotspot/serviceability/sa and gc/metaspace tests locally with fix, tier1 testing locally in progress.  I'll run more tests if we wish to wait.
>>
>> Thanks,
>> Coleen

Reply | Threaded
Open this post in threaded view
|

Re: RFR (xs) 8190491: SA tests failed after 8189610 changes

coleen.phillimore
Thanks for the review and pushing the change!
Coleen

On 11/1/17 7:44 PM, harold seigel wrote:

> Thanks Jiangli!
>
> I went ahead and pushed the change for Coleen.
>
> Harold
>
>
> On 11/1/2017 6:57 PM, Jiangli Zhou wrote:
>> Looks good.
>>
>> Thanks,
>> Jiangli
>>
>>> On Nov 1, 2017, at 1:29 PM, [hidden email] wrote:
>>>
>>> Summary: Changed a type in hotspot not reflected in SA code.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8190491.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8190491
>>>
>>> Ran test/hotspot/serviceability/sa and gc/metaspace tests locally
>>> with fix, tier1 testing locally in progress.  I'll run more tests if
>>> we wish to wait.
>>>
>>> Thanks,
>>> Coleen
>