RFR(xs): 8195000: Clean out left-overs in arguments.hpp

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(xs): 8195000: Clean out left-overs in arguments.hpp

Per Liden
Hi,

The refactoring done in JDK-8189171 moved some functions out from
Arguments to separate classes, but the function declarations were left.
These should just be removed.

Bug: https://bugs.openjdk.java.net/browse/JDK-8195000
Webrev: http://cr.openjdk.java.net/~pliden/8195000/webrev.0/

/Per
Reply | Threaded
Open this post in threaded view
|

Re: RFR(xs): 8195000: Clean out left-overs in arguments.hpp

Stefan Karlsson
Looks good.

StefanK

On 2018-01-12 15:29, Per Liden wrote:

> Hi,
>
> The refactoring done in JDK-8189171 moved some functions out from
> Arguments to separate classes, but the function declarations were left.
> These should just be removed.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8195000
> Webrev: http://cr.openjdk.java.net/~pliden/8195000/webrev.0/
>
> /Per
Reply | Threaded
Open this post in threaded view
|

Re: RFR(xs): 8195000: Clean out left-overs in arguments.hpp

Per Liden
Thanks Stefan. I consider this a trivial change, so I'll push now.

cheers,
Per

On 01/12/2018 03:42 PM, Stefan Karlsson wrote:

> Looks good.
>
> StefanK
>
> On 2018-01-12 15:29, Per Liden wrote:
>> Hi,
>>
>> The refactoring done in JDK-8189171 moved some functions out from
>> Arguments to separate classes, but the function declarations were
>> left. These should just be removed.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8195000
>> Webrev: http://cr.openjdk.java.net/~pliden/8195000/webrev.0/
>>
>> /Per