RFR(xs): 8205390: jtreg: Fix failing TestRTMSpinLoopCount on PPC64

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR(xs): 8205390: jtreg: Fix failing TestRTMSpinLoopCount on PPC64

Gustavo Romero
Hi,

Could the following change be reviewed please?

bug   : https://bugs.openjdk.java.net/browse/JDK-8205390
webrev: http://cr.openjdk.java.net/~gromero/8205390/v1/

It adds a new throttling sequence for PPC64 because the last value on current
sequence does not fit on PPC64.

By using the new sequence the following test is fixed:

+Passed: compiler/rtm/locking/TestRTMSpinLoopCount.java
       

Thank you and best regards,
Gustavo

Reply | Threaded
Open this post in threaded view
|

Re: RFR(xs): 8205390: jtreg: Fix failing TestRTMSpinLoopCount on PPC64

Vladimir Kozlov
Good.

Thanks,
Vladimir

On 6/25/18 1:31 AM, Gustavo Romero wrote:

> Hi,
>
> Could the following change be reviewed please?
>
> bug   : https://bugs.openjdk.java.net/browse/JDK-8205390
> webrev: http://cr.openjdk.java.net/~gromero/8205390/v1/
>
> It adds a new throttling sequence for PPC64 because the last value on
> current
> sequence does not fit on PPC64.
>
> By using the new sequence the following test is fixed:
>
> +Passed: compiler/rtm/locking/TestRTMSpinLoopCount.java
>
>
> Thank you and best regards,
> Gustavo
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR(xs): 8205390: jtreg: Fix failing TestRTMSpinLoopCount on PPC64

Gustavo Romero
On 06/25/2018 02:21 PM, Vladimir Kozlov wrote:
> Good.

Thanks for reviewing it Vladimir!

Regards,
Gustavo
 

> Thanks,
> Vladimir
>
> On 6/25/18 1:31 AM, Gustavo Romero wrote:
>> Hi,
>>
>> Could the following change be reviewed please?
>>
>> bug   : https://bugs.openjdk.java.net/browse/JDK-8205390
>> webrev: http://cr.openjdk.java.net/~gromero/8205390/v1/
>>
>> It adds a new throttling sequence for PPC64 because the last value on current
>> sequence does not fit on PPC64.
>>
>> By using the new sequence the following test is fixed:
>>
>> +Passed: compiler/rtm/locking/TestRTMSpinLoopCount.java
>>
>>
>> Thank you and best regards,
>> Gustavo
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR(xs): 8205390: jtreg: Fix failing TestRTMSpinLoopCount on PPC64

Igor Ignatyev
In reply to this post by Vladimir Kozlov
+1

-- Igor

> On Jun 25, 2018, at 10:21 AM, Vladimir Kozlov <[hidden email]> wrote:
>
> Good.
>
> Thanks,
> Vladimir
>
> On 6/25/18 1:31 AM, Gustavo Romero wrote:
>> Hi,
>> Could the following change be reviewed please?
>> bug   : https://bugs.openjdk.java.net/browse/JDK-8205390
>> webrev: http://cr.openjdk.java.net/~gromero/8205390/v1/
>> It adds a new throttling sequence for PPC64 because the last value on current
>> sequence does not fit on PPC64.
>> By using the new sequence the following test is fixed:
>> +Passed: compiler/rtm/locking/TestRTMSpinLoopCount.java
>> Thank you and best regards,
>> Gustavo

Reply | Threaded
Open this post in threaded view
|

Re: RFR(xs): 8205390: jtreg: Fix failing TestRTMSpinLoopCount on PPC64

Gustavo Romero
Hi,

I'm going to push it to jdk/jdk11 after running the tests if there are no objections.


Thanks,
Gustavo

On 06/26/2018 05:56 PM, Igor Ignatyev wrote:

> +1
>
> -- Igor
>
>> On Jun 25, 2018, at 10:21 AM, Vladimir Kozlov <[hidden email]> wrote:
>>
>> Good.
>>
>> Thanks,
>> Vladimir
>>
>> On 6/25/18 1:31 AM, Gustavo Romero wrote:
>>> Hi,
>>> Could the following change be reviewed please?
>>> bug   : https://bugs.openjdk.java.net/browse/JDK-8205390
>>> webrev: http://cr.openjdk.java.net/~gromero/8205390/v1/
>>> It adds a new throttling sequence for PPC64 because the last value on current
>>> sequence does not fit on PPC64.
>>> By using the new sequence the following test is fixed:
>>> +Passed: compiler/rtm/locking/TestRTMSpinLoopCount.java
>>> Thank you and best regards,
>>> Gustavo
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR(xs): 8205390: jtreg: Fix failing TestRTMSpinLoopCount on PPC64

Gustavo Romero
On 07/17/2018 04:10 AM, Gustavo Romero wrote:
> I'm going to push it to jdk/jdk11 after running the tests if there are no objections.

All tests passed:

mach5-one-gromero-JDK-8205390-20180718-1940-31577: Build tasks PASSED. Test tasks SUCCESSFUL.

Pushing it.

Thanks,
Gustavo

>
> Thanks,
> Gustavo
>
> On 06/26/2018 05:56 PM, Igor Ignatyev wrote:
>> +1
>>
>> -- Igor
>>
>>> On Jun 25, 2018, at 10:21 AM, Vladimir Kozlov <[hidden email]> wrote:
>>>
>>> Good.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 6/25/18 1:31 AM, Gustavo Romero wrote:
>>>> Hi,
>>>> Could the following change be reviewed please?
>>>> bug   : https://bugs.openjdk.java.net/browse/JDK-8205390
>>>> webrev: http://cr.openjdk.java.net/~gromero/8205390/v1/
>>>> It adds a new throttling sequence for PPC64 because the last value on current
>>>> sequence does not fit on PPC64.
>>>> By using the new sequence the following test is fixed:
>>>> +Passed: compiler/rtm/locking/TestRTMSpinLoopCount.java
>>>> Thank you and best regards,
>>>> Gustavo
>>
>