Re: RFR: 8227086: Use AS_NO_KEEPALIVE loads in HeapDumper

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8227086: Use AS_NO_KEEPALIVE loads in HeapDumper

Kim Barrett
> On Jul 2, 2019, at 9:53 AM, Stefan Karlsson <[hidden email]> wrote:
>
> Hi all,
>
> Please review this patch to read objects with AS_NO_KEEPALIVE in the HeapDumper.
>
> http://cr.openjdk.java.net/~stefank/8227086/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8227086
>
> Found this while running some extra verification code through our barriers. This is one place where we use ON_UNKNOWN_OOP_REF without AS_NO_KEEPALIVE. The current code isn't wrong, but we could just as well use the more light-weight load barrier here.
>
> Tested with tier 1-7
>
> Thanks,
> StefanK

Looks good.

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8227086: Use AS_NO_KEEPALIVE loads in HeapDumper

Stefan Karlsson
Thanks, Serguei.

StefanK

On 2019-07-02 17:57, [hidden email] wrote:

> Hi Stefan,
>
> It looks good.
>
> Thanks,
> Serguei
>
>
>
> On 7/2/19 06:53, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review this patch to read objects with AS_NO_KEEPALIVE in the
>> HeapDumper.
>>
>> http://cr.openjdk.java.net/~stefank/8227086/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8227086
>>
>> Found this while running some extra verification code through our
>> barriers. This is one place where we use ON_UNKNOWN_OOP_REF without
>> AS_NO_KEEPALIVE. The current code isn't wrong, but we could just as
>> well use the more light-weight load barrier here.
>>
>> Tested with tier 1-7
>>
>> Thanks,
>> StefanK
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8227086: Use AS_NO_KEEPALIVE loads in HeapDumper

Stefan Karlsson
In reply to this post by Kim Barrett
Thanks, Kim.

StefanK

On 2019-07-03 00:11, Kim Barrett wrote:

>> On Jul 2, 2019, at 9:53 AM, Stefan Karlsson <[hidden email]> wrote:
>>
>> Hi all,
>>
>> Please review this patch to read objects with AS_NO_KEEPALIVE in the HeapDumper.
>>
>> http://cr.openjdk.java.net/~stefank/8227086/webrev.01/
>> https://bugs.openjdk.java.net/browse/JDK-8227086
>>
>> Found this while running some extra verification code through our barriers. This is one place where we use ON_UNKNOWN_OOP_REF without AS_NO_KEEPALIVE. The current code isn't wrong, but we could just as well use the more light-weight load barrier here.
>>
>> Tested with tier 1-7
>>
>> Thanks,
>> StefanK
> Looks good.
>