Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v31]

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v31]

Jim Laskey-3
On Mon, 15 Mar 2021 23:07:53 GMT, Joe Darcy <[hidden email]> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   Missing @since
>
> src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java line 62:
>
>> 60:     @Retention(RetentionPolicy.RUNTIME)
>> 61:     @Target(ElementType.TYPE)
>> 62:     public @interface RandomGeneratorProperties {
>
> Should the is-deprecated information be stored here?

I don't think so. That would require the deprecation state be stored in two places. I think it's sufficient to rely on the presence of @Deprecated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1292
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v31]

Jim Laskey-3
On Mon, 15 Mar 2021 23:02:33 GMT, Joe Darcy <[hidden email]> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   Missing @since
>
> src/java.base/share/classes/java/util/Random.java line 135:
>
>> 133:      * number generator which is maintained by method {@link #next}.
>> 134:      *
>> 135:      * @implSpec <p>The invocation {@code new Random(seed)} is equivalent to:
>
> This is not conventional formatting for an implSpec section. I suggest putting implSpec on its own line and then left-justifying the text as normal. A new paragraph tag is no needed at the beginning of implSpec.

Adjusted

-------------

PR: https://git.openjdk.java.net/jdk/pull/1292
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v31]

Jim Laskey-3
In reply to this post by Jim Laskey-3
On Thu, 18 Mar 2021 12:57:16 GMT, Jim Laskey <[hidden email]> wrote:

>> src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java line 62:
>>
>>> 60:     @Retention(RetentionPolicy.RUNTIME)
>>> 61:     @Target(ElementType.TYPE)
>>> 62:     public @interface RandomGeneratorProperties {
>>
>> Should the is-deprecated information be stored here?
>
> I don't think so. That would require the deprecation state be stored in two places. I think it's sufficient to rely on the presence of @Deprecated.

isDeprecated was added

-------------

PR: https://git.openjdk.java.net/jdk/pull/1292