Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8]

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8]

Vladimir Kempik-3
On Mon, 1 Feb 2021 18:44:48 GMT, Andrew Haley <[hidden email]> wrote:

>> Anton Kozlov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 62 commits:
>>
>>  - Merge branch 'master' into jdk-macos
>>  - Update copyright year for BsdAARCH64ThreadContext.java
>>  - Fix inclusing of StubRoutines header
>>  - Redo buildsys fix
>>  - Revert harfbuzz changes, disable warnings for it
>>  - Little adjustement of SlowSignatureHandler
>>  - Partially bring previous commit
>>  - Revert "Address feedback for signature generators"
>>    
>>    This reverts commit 50b55f6684cd21f8b532fa979b7b6fbb4613266d.
>>  - Refactor CDS disabling
>>  - Redo builsys support for aarch64-darwin
>>  - ... and 52 more: https://git.openjdk.java.net/jdk/compare/8a9004da...b421e0b4
>
> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 839:
>
>> 837:           // The code unable to handle this, bailout.
>> 838:           return -1;
>> 839: #endif
>
> This looks like a bug to me. The caller doesn't necessarily check the return value. See CallRuntimeNode::calling_convention.

Hello, we have updated PR, now this bailout is used only by the code which can handle it (native wrapper generator), for the rest it will cause guarantee failed if this bailout is triggered

-------------

PR: https://git.openjdk.java.net/jdk/pull/2200