Re: RFR: 8263754: HexFormat 'fromHex' methods should be static [v2]

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263754: HexFormat 'fromHex' methods should be static [v2]

Roger Riggs-2
> A number of HexFormat methods converting from strings to numbers do not use delimiter, prefix, suffix, and uppercase parameters and would be more convenient if the methods were static.
>
> These  APIs were added early in JDK 17 and are being updated before GA.
> This PR updates existing uses in the JDK but there may be compiler warnings in non-JDK source files.
>
>    public boolean isHexDigit(int);
>    public int fromHexDigit(int);
>    public int fromHexDigits(java.lang.CharSequence);
>    public int fromHexDigits(java.lang.CharSequence, int, int);
>    public long fromHexDigitsToLong(java.lang.CharSequence);
>    public long fromHexDigitsToLong(java.lang.CharSequence, int, int);

Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:

  Remove unused HexFormat instances

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3205/files
  - new: https://git.openjdk.java.net/jdk/pull/3205/files/050495a9..042dc18b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3205&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3205&range=00-01

  Stats: 7 lines in 4 files changed: 0 ins; 7 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3205.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3205/head:pull/3205

PR: https://git.openjdk.java.net/jdk/pull/3205
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263754: HexFormat 'fromHex' methods should be static [v2]

Claes Redestad-2
On Fri, 26 Mar 2021 14:39:47 GMT, Roger Riggs <[hidden email]> wrote:

>> A number of HexFormat methods converting from strings to numbers do not use delimiter, prefix, suffix, and uppercase parameters and would be more convenient if the methods were static.
>>
>> These  APIs were added early in JDK 17 and are being updated before GA.
>> This PR updates existing uses in the JDK but there may be compiler warnings in non-JDK source files.
>>
>>    public boolean isHexDigit(int);
>>    public int fromHexDigit(int);
>>    public int fromHexDigits(java.lang.CharSequence);
>>    public int fromHexDigits(java.lang.CharSequence, int, int);
>>    public long fromHexDigitsToLong(java.lang.CharSequence);
>>    public long fromHexDigitsToLong(java.lang.CharSequence, int, int);
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
>   Remove unused HexFormat instances

Marked as reviewed by redestad (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3205