Re: RFR: 8264109: Add vectorized implementation for VectorMask.andNot()

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264109: Add vectorized implementation for VectorMask.andNot()

Paul Sandoz-2
On Fri, 26 Mar 2021 01:50:33 GMT, Xiaohong Gong <[hidden email]> wrote:

> Currently "VectorMask.andNot()" is not vectorized:
>     public VectorMask<E> andNot(VectorMask<E> m) {
>         // FIXME: Generate good code here.
>         return bOp(m, (i, a, b) -> a && !b);
>     }
> This can be implemented with` "and(m.not())" `directly. Since `"VectorMask.and()/not()" `have been vectorized in hotspot, `"andNot"`
> can be vectorized as well by calling them.
>
> The performance gain is >100% for such a simple JMH:
>   @Benchmark
>   public Object andNot(Blackhole bh) {
>     boolean[] mask = fm.apply(SPECIES.length());
>     boolean[] r = fmt.apply(SPECIES.length());
>     VectorMask<Byte> rm = VectorMask.fromArray(SPECIES, r, 0);
>
>     for (int ic = 0; ic < INVOC_COUNT; ic++) {
>       for (int i = 0; i < mask.length; i += SPECIES.length()) {
>         VectorMask<Byte> vmask = VectorMask.fromArray(SPECIES, mask, i);
>           rm = rm.andNot(vmask);
>         }
>     }
>     return rm;
>   }

Would you mind updating the existing `AbstractMask.andNot` implementation? rather than changing `VectorMask.andNot`. That fits in with the current implementation pattern.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3211
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264109: Add vectorized implementation for VectorMask.andNot() [v2]

Xiaohong Gong
On Wed, 31 Mar 2021 16:42:09 GMT, Paul Sandoz <[hidden email]> wrote:

> Would you mind updating the existing `AbstractMask.andNot` implementation? rather than changing `VectorMask.andNot`. That fits in with the current implementation pattern.

Hi @PaulSandoz , thanks for looking at this PR. I'v updated the patch according to your comments. Would you mind having look at it again? Thanks so much!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3211
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264109: Add vectorized implementation for VectorMask.andNot() [v2]

Xiaohong Gong
On Fri, 2 Apr 2021 09:59:31 GMT, Ningsheng Jian <[hidden email]> wrote:

>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   Move the changing to AbstractMask.andNot and revert changes in VectorMask
>>  
>>   Change-Id: Ie3ec8f53cb24526c8e1ccc68038355d024910818
>>   CustomizedGitHooks: yes
>
> LGTM

Thanks for the review @nsjian !

-------------

PR: https://git.openjdk.java.net/jdk/pull/3211