Re: RFR: 8264711: More runtime TRAPS cleanups [v4]

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264711: More runtime TRAPS cleanups [v4]

Harold Seigel-2
On Mon, 5 Apr 2021 19:08:38 GMT, Patricio Chilano Mateo <[hidden email]> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   remove unneeded statement
>
> src/hotspot/share/runtime/synchronizer.cpp line 609:
>
>> 607:   // intentionally do not use CHECK on check_owner because we must exit the
>> 608:   // monitor even if an exception was already pending.
>> 609:   if (monitor->check_owner(current)) {
>
> We can actually throw IMSE from check_owner() if this thread is not the real owner.

I reverted this change.  Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3345
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264711: More runtime TRAPS cleanups [v4]

David Holmes-2
On Wed, 7 Apr 2021 14:19:50 GMT, Harold Seigel <[hidden email]> wrote:

>> Please review this additional cleanup of use of TRAPS in hotspot runtime code.  The changes were tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows and Mach5 tiers 3-5 on Linux x64.
>>
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>
>   remove unneeded statement

Hi Harold,

Updates seem fine.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3345
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264711: More runtime TRAPS cleanups [v4]

Harold Seigel-2
On Thu, 8 Apr 2021 10:10:00 GMT, David Holmes <[hidden email]> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   remove unneeded statement
>
> Hi Harold,
>
> Updates seem fine.
>
> Thanks,
> David

Thanks Lois, Patricio, David, and Dan for reviewing this!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3345